You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/10/19 23:09:44 UTC

[GitHub] Ben-Zvi commented on issue #1508: DRILL-6804: Simplify usage of OperatorPhase in HashAgg.

Ben-Zvi commented on issue #1508: DRILL-6804: Simplify usage of OperatorPhase in HashAgg.
URL: https://github.com/apache/drill/pull/1508#issuecomment-431523825
 
 
   I don't understand the purpose of this Jira - the changed code does not look simpler than the original.   E.g., is was much simpler to read `is2ndPhase` than now `popConfig.getAggPhase().isSecondPhase()` .  
      The enum `OperatorPhase` is not adding any functionality. The only issue is the debug string `getPhaseName()` which can be implemented as a private one line method. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services