[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #6667: fix: correct wrong test and ignore it.

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener commented on code in PR #6667:
URL: https://github.com/apache/arrow-datafusion/pull/6667#discussion_r1230363558


##########
datafusion/core/tests/dataframe.rs:
##########
@@ -245,7 +248,7 @@ async fn test_count_wildcard_on_where_scalar_subquery() -> Result<()> {
                     .await?
                     .filter(out_ref_col(DataType::UInt32, "t1.a").eq(col("t2.a")))?
                     .aggregate(vec![], vec![count(lit(COUNT_STAR_EXPANSION))])?
-                    .select(vec![count(lit(COUNT_STAR_EXPANSION))])?
+                    .select(vec![col("COUNT(*)")])?

Review Comment:
   A great idea!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org