You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/28 03:45:09 UTC

[GitHub] [flink] KarmaGYZ opened a new pull request #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

KarmaGYZ opened a new pull request #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249
 
 
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   Remove unnecessary indents and blank lines in code blocks.
   
   ## Brief change log
   
   Remove unnecessary indents and blank lines in code blocks
   
   ## Verifying this change
   
   Build the doc and check the relevant code blocks.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   
   cc @zentol 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#issuecomment-592447624
 
 
   > That's a lot of whitespace...
   
   Yes. That's why I open a new ticket instead of fixing it in FLINK-15562.
   
   Thanks for the review. I've updated the PR. @zentol 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#issuecomment-592299096
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit fe25cef13c65c9f584b53aa7216347ee1b3e8f16 (Fri Feb 28 03:47:18 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#issuecomment-592302102
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150955168",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5715",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fe25cef13c65c9f584b53aa7216347ee1b3e8f16 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150955168) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5715) 
   * ffbbb8ff27af46c58e2b359a3a9166797281c718 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#issuecomment-592302102
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150955168",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5715",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/151001490",
       "triggerID" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5731",
       "triggerID" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b54985a37e96cbfa4fab2ae8a47187fed5d25398",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b54985a37e96cbfa4fab2ae8a47187fed5d25398",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ffbbb8ff27af46c58e2b359a3a9166797281c718 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/151001490) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5731) 
   * b54985a37e96cbfa4fab2ae8a47187fed5d25398 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#issuecomment-592302102
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fe25cef13c65c9f584b53aa7216347ee1b3e8f16 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#issuecomment-592466577
 
 
   You missed the chinese document

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#discussion_r385592449
 
 

 ##########
 File path: docs/dev/batch/index.md
 ##########
 @@ -588,9 +588,9 @@ val output: DataSet[(Int, String, Double)] = input.sum(0).min(2)
       <td>
         <p>Returns the distinct elements of a data set. It removes the duplicate entries
         from the input DataSet, with respect to all fields of the elements, or a subset of fields.</p>
-      {% highlight scala %}
-         data.distinct()
-      {% endhighlight %}
+{% highlight scala %}
 
 Review comment:
   In this file there's also some unnecessary whitespace in the Java Dataset Aggregate transformation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#issuecomment-592467776
 
 
   > You missed the chinese document (docs/dev/batch/index.zh.md)
   
   Oops. Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#issuecomment-592302102
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150955168",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5715",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/151001490",
       "triggerID" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5731",
       "triggerID" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b54985a37e96cbfa4fab2ae8a47187fed5d25398",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b54985a37e96cbfa4fab2ae8a47187fed5d25398",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fe25cef13c65c9f584b53aa7216347ee1b3e8f16 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150955168) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5715) 
   * ffbbb8ff27af46c58e2b359a3a9166797281c718 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151001490) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5731) 
   * b54985a37e96cbfa4fab2ae8a47187fed5d25398 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#issuecomment-592302102
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150955168",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5715",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fe25cef13c65c9f584b53aa7216347ee1b3e8f16 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150955168) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5715) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#issuecomment-592302102
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150955168",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5715",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fe25cef13c65c9f584b53aa7216347ee1b3e8f16 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150955168) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5715) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#issuecomment-592302102
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150955168",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5715",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/151001490",
       "triggerID" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5731",
       "triggerID" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fe25cef13c65c9f584b53aa7216347ee1b3e8f16 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150955168) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5715) 
   * ffbbb8ff27af46c58e2b359a3a9166797281c718 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151001490) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5731) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
zentol edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#issuecomment-592466577
 
 
   You missed the chinese document (docs/dev/batch/index.zh.md)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#issuecomment-592428183
 
 
   That's a lot of whitespace...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol merged pull request #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#issuecomment-592302102
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150955168",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5715",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fe25cef13c65c9f584b53aa7216347ee1b3e8f16 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150955168) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5715) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#discussion_r385592515
 
 

 ##########
 File path: docs/dev/batch/index.zh.md
 ##########
 @@ -588,9 +588,9 @@ val output: DataSet[(Int, String, Double)] = input.sum(0).min(2)
       <td>
         <p>Returns the distinct elements of a data set. It removes the duplicate entries
         from the input DataSet, with respect to all fields of the elements, or a subset of fields.</p>
-      {% highlight scala %}
-         data.distinct()
-      {% endhighlight %}
+{% highlight scala %}
 
 Review comment:
   same as above likely

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11249: [FLINK-16297] Remove unnecessary indents and blank lines in code blocks
URL: https://github.com/apache/flink/pull/11249#issuecomment-592302102
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150955168",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5715",
       "triggerID" : "fe25cef13c65c9f584b53aa7216347ee1b3e8f16",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "status" : "CANCELED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/151001490",
       "triggerID" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5731",
       "triggerID" : "ffbbb8ff27af46c58e2b359a3a9166797281c718",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b54985a37e96cbfa4fab2ae8a47187fed5d25398",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b54985a37e96cbfa4fab2ae8a47187fed5d25398",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ffbbb8ff27af46c58e2b359a3a9166797281c718 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/151001490) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5731) 
   * b54985a37e96cbfa4fab2ae8a47187fed5d25398 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services