You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "yongwww (via GitHub)" <gi...@apache.org> on 2023/10/06 19:22:51 UTC

[PR] [Unity] Replace relax_vm/memory_manager with memory/memory_manager [Do Not Merge] [tvm]

yongwww opened a new pull request, #15882:
URL: https://github.com/apache/tvm/pull/15882

   We can unify the `runtime/relax_vm/memory_manager` and `runtime/memory/memory_manager` by replacing the former with the latter. 
   
   DO NOT merge it, this PR should not be merged until PR #15833 is merged into unity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Unity] Replace relax_vm/memory_manager with memory/memory_manager [tvm]

Posted by "yongwww (via GitHub)" <gi...@apache.org>.
yongwww commented on PR #15882:
URL: https://github.com/apache/tvm/pull/15882#issuecomment-1757764486

   cc: @tqchen @srkreddy1238 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Unity] Replace relax_vm/memory_manager with memory/memory_manager [tvm]

Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #15882:
URL: https://github.com/apache/tvm/pull/15882#issuecomment-1796225353

   This change has resulted in breakage [here](https://github.com/mlc-ai/mlc-llm/blame/main/cpp/llm_chat.cc#L1424) in MLC-LLM, due to the removal of the `"vm.builtin.memory_manager.clear"` packed func.  Is there a renamed version of this function?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Unity] Replace relax_vm/memory_manager with memory/memory_manager [tvm]

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen merged PR #15882:
URL: https://github.com/apache/tvm/pull/15882


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Do Not Merge][Unity] Replace relax_vm/memory_manager with memory/memory_manager [tvm]

Posted by "yongwww (via GitHub)" <gi...@apache.org>.
yongwww commented on code in PR #15882:
URL: https://github.com/apache/tvm/pull/15882#discussion_r1355061713


##########
src/runtime/memory/memory_manager.cc:
##########
@@ -101,6 +100,11 @@ NDArray StorageObj::AllocNDArray(size_t offset, ShapeTuple shape, DLDataType dty
   // buffer intact.
   container->manager_ctx = reinterpret_cast<void*>(this);
 
+  // The only change we make w.r.t offset is modifying the data pointer
+  // of the backing tensor to point into the buffer instead of its start.
+  auto offset_ptr = reinterpret_cast<uint8_t*>(this->buffer.data) + offset;

Review Comment:
   This change has been submitted to main: https://github.com/apache/tvm/pull/15912



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org