You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "LuGuangming (via GitHub)" <gi...@apache.org> on 2024/01/20 14:24:41 UTC
[PR] [fix][bug] FE web exists insecure cookie setting [doris]
LuGuangming opened a new pull request, #30183:
URL: https://github.com/apache/doris/pull/30183
## Proposed changes
Issue Number: close #30180
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix][bug] FE web exists insecure cookie setting [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30183:
URL: https://github.com/apache/doris/pull/30183#issuecomment-1902124081
<details>
<summary>TPC-DS: <b>Total hot run time: 237826 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 916fc6e868e97aa6d3986fd0fdb60ad4179e73d4, data reload: false
query1 922 394 386 386
query2 6524 2304 1980 1980
query3 6918 201 196 196
query4 20274 17918 17903 17903
query5 19727 6262 6245 6245
query6 278 215 218 215
query7 4144 290 309 290
query8 261 249 244 244
query9 3108 2699 2627 2627
query10 403 301 288 288
query11 11369 10633 10552 10552
query12 125 71 72 71
query13 5682 668 621 621
query14 17506 13359 13253 13253
query15 365 237 244 237
query16 6448 261 267 261
query17 3187 881 894 881
query18 2268 413 406 406
query19 208 144 141 141
query20 71 76 75 75
query21 187 95 91 91
query22 5202 5100 4968 4968
query23 32597 31993 31822 31822
query24 6993 6486 6468 6468
query25 520 432 426 426
query26 618 166 155 155
query27 2012 293 294 293
query28 6096 2269 2218 2218
query29 2986 2785 2629 2629
query30 244 161 162 161
query31 900 731 732 731
query32 61 59 59 59
query33 387 255 253 253
query34 852 475 472 472
query35 1114 893 937 893
query36 2169 1487 1393 1393
query37 87 63 61 61
query38 3134 2869 2902 2869
query39 1365 1316 1326 1316
query40 200 95 90 90
query41 35 32 35 32
query42 98 84 89 84
query43 658 573 605 573
query44 1137 713 721 713
query45 243 231 231 231
query46 1229 958 979 958
query47 1776 1654 1833 1654
query48 967 682 669 669
query49 629 369 355 355
query50 867 641 594 594
query51 5580 5572 5543 5543
query52 96 75 80 75
query53 437 325 310 310
query54 2395 2285 2253 2253
query55 86 71 77 71
query56 211 186 209 186
query57 1131 1091 1058 1058
query58 225 203 197 197
query59 3412 3189 3286 3189
query60 208 184 214 184
query61 84 87 80 80
query62 858 508 446 446
query63 465 345 343 343
query64 2044 1296 1281 1281
query65 3660 3611 3632 3611
query66 826 359 357 357
query67 15657 15878 15893 15878
query68 8079 645 642 642
query69 557 352 334 334
query70 1736 1828 1512 1512
query71 365 299 293 293
query72 4502 3245 3291 3245
query73 715 321 319 319
query74 6253 5920 5868 5868
query75 4340 3537 3588 3537
query76 4621 1197 1164 1164
query77 554 241 244 241
query78 33489 48769 47771 47771
query79 14693 666 642 642
query80 4182 377 374 374
query81 570 223 228 223
query82 733 98 91 91
query83 322 138 127 127
query84 261 68 70 68
query85 2122 273 277 273
query86 444 381 375 375
query87 3238 3010 2980 2980
query88 6705 2315 2296 2296
query89 383 312 293 293
query90 2470 210 205 205
query91 148 115 121 115
query92 66 42 50 42
query93 4126 604 548 548
query94 1625 198 203 198
query95 1105 1077 1065 1065
query96 641 328 322 322
query97 6505 6479 6394 6394
query98 187 174 169 169
query99 3733 950 935 935
Total cold run time: 341996 ms
Total hot run time: 237826 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix][bug] FE web exists insecure cookie setting [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #30183:
URL: https://github.com/apache/doris/pull/30183#issuecomment-1903387731
is there same problem in master branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix][bug] FE web exists insecure cookie setting [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30183:
URL: https://github.com/apache/doris/pull/30183#issuecomment-1902125378
<details>
<summary>ClickBench: <b>Total hot run time: 30.33 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 916fc6e868e97aa6d3986fd0fdb60ad4179e73d4, data reload: false
query1 0.03 0.02 0.02
query2 0.06 0.02 0.02
query3 0.25 0.05 0.04
query4 1.83 0.06 0.06
query5 0.53 0.52 0.52
query6 1.24 0.62 0.61
query7 0.01 0.01 0.01
query8 0.04 0.02 0.02
query9 0.53 0.49 0.48
query10 0.55 0.54 0.54
query11 0.11 0.09 0.09
query12 0.11 0.09 0.09
query13 0.63 0.60 0.61
query14 0.83 0.79 0.79
query15 0.77 0.75 0.78
query16 0.36 0.36 0.36
query17 0.99 0.99 1.03
query18 0.24 0.25 0.26
query19 1.94 1.81 1.87
query20 0.02 0.01 0.01
query21 15.48 0.56 0.55
query22 1.79 1.99 1.19
query23 17.24 0.92 1.06
query24 6.50 1.01 0.89
query25 2.19 0.16 0.15
query26 0.16 0.13 0.14
query27 0.14 0.16 0.15
query28 6.27 0.77 0.72
query29 12.75 2.24 2.33
query30 0.62 0.53 0.51
query31 2.82 0.38 0.38
query32 3.43 0.50 0.48
query33 3.10 3.06 3.05
query34 15.24 4.81 4.84
query35 4.87 4.84 4.85
query36 1.05 1.03 1.01
query37 0.06 0.05 0.05
query38 0.03 0.02 0.02
query39 0.01 0.02 0.01
query40 0.15 0.14 0.14
query41 0.07 0.01 0.01
query42 0.01 0.02 0.01
query43 0.03 0.02 0.01
Total cold run time: 105.08 s
Total hot run time: 30.33 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix][bug] FE web exists insecure cookie setting [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30183:
URL: https://github.com/apache/doris/pull/30183#issuecomment-1902117652
<details>
<summary>TPC-H: <b>Total hot run time: 50164 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 916fc6e868e97aa6d3986fd0fdb60ad4179e73d4, data reload: false
------ Round 1 ----------------------------------
q1 17555 4476 4350 4350
q2 2036 150 141 141
q3 10476 1923 1982 1923
q4 10357 1231 1338 1231
q5 8430 3937 4007 3937
q6 230 127 130 127
q7 2079 1640 1658 1640
q8 9500 2704 2728 2704
q9 14144 11119 10440 10440
q10 8646 3566 3562 3562
q11 413 234 241 234
q12 465 301 313 301
q13 18336 3986 4016 3986
q14 364 321 324 321
q15 508 462 469 462
q16 691 595 599 595
q17 1132 961 916 916
q18 7298 7009 6998 6998
q19 1697 1566 1494 1494
q20 530 307 304 304
q21 4446 4106 4144 4106
q22 491 392 415 392
Total cold run time: 119824 ms
Total hot run time: 50164 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4366 4367 4323 4323
q2 317 227 227 227
q3 4174 4182 4140 4140
q4 2755 2751 2768 2751
q5 7304 7189 7239 7189
q6 238 117 118 117
q7 3248 2862 2915 2862
q8 4359 4492 4512 4492
q9 17113 16909 17011 16909
q10 4230 4253 4280 4253
q11 762 675 678 675
q12 1036 864 841 841
q13 6820 3749 3765 3749
q14 454 422 417 417
q15 488 463 455 455
q16 761 704 701 701
q17 3790 3870 3903 3870
q18 8934 8799 8719 8719
q19 1728 1689 1694 1689
q20 2375 2173 2140 2140
q21 8508 8492 8570 8492
q22 1015 979 981 979
Total cold run time: 84775 ms
Total hot run time: 79990 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix][bug] FE web exists insecure cookie setting [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #30183:
URL: https://github.com/apache/doris/pull/30183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix][bug] FE web exists insecure cookie setting [doris]
Posted by "LuGuangming (via GitHub)" <gi...@apache.org>.
LuGuangming commented on PR #30183:
URL: https://github.com/apache/doris/pull/30183#issuecomment-1902113104
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix][bug] FE web exists insecure cookie setting [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30183:
URL: https://github.com/apache/doris/pull/30183#issuecomment-1902126059
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 916fc6e868e97aa6d3986fd0fdb60ad4179e73d4 with default session variables
Stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 21.4 seconds inserted 10000000 Rows, about 467K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix][bug] FE web exists insecure cookie setting [doris]
Posted by "LuGuangming (via GitHub)" <gi...@apache.org>.
LuGuangming commented on PR #30183:
URL: https://github.com/apache/doris/pull/30183#issuecomment-1909283189
> is there same problem in master branch?
Yes, master has been fix merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix][bug] FE web exists insecure cookie setting [doris]
Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #30183:
URL: https://github.com/apache/doris/pull/30183#issuecomment-1909411079
> > is there same problem in master branch?
> Yes, master has been fix merged
So it's better to have a link to master's fix patch in the pr's description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org