You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "Bruce Wen (JIRA)" <ji...@apache.org> on 2019/03/03 20:29:00 UTC
[jira] [Commented] (LOG4J2-2561) In log4j-core AbstractStringLayout
java version detection is not JEP223 compatible
[ https://issues.apache.org/jira/browse/LOG4J2-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782854#comment-16782854 ]
Bruce Wen commented on LOG4J2-2561:
-----------------------------------
_Existing code that compares version numbers by parsing their elements and comparing them numerically will continue to work._ — this is the best way to compare versions so far.
> In log4j-core AbstractStringLayout java version detection is not JEP223 compatible
> ----------------------------------------------------------------------------------
>
> Key: LOG4J2-2561
> URL: https://issues.apache.org/jira/browse/LOG4J2-2561
> Project: Log4j 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.11.2
> Reporter: Ulrich Enslin
> Priority: Major
> Labels: easyfix, pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The function isPreJava8() will detect java 9 and higher as being pre java 8, because the logic does not take JEP223 into account.
>
> The same logic is correct in org.apache.logging.log4j.util.Constants#getMajorVersion, so simply modified the logic in AbstractStringLayout to work the same in the PR.
>
> This seems like a small change, but it prevents log4j from being JDK 9 and up compatible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)