You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/28 06:49:39 UTC
[GitHub] [spark] HeartSaVioR opened a new pull request #34417: [MINOR][SS] Remove unused config "pauseBackgroundWorkForCommit" from RocksDB
HeartSaVioR opened a new pull request #34417:
URL: https://github.com/apache/spark/pull/34417
### What changes were proposed in this pull request?
This PR proposes to remove unused config "pauseBackgroundWorkForCommit".
### Why are the changes needed?
That is unused config which actually has to be always "true" even if it's being used.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing UTs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #34417: [MINOR][SS] Remove unused config "pauseBackgroundWorkForCommit" from RocksDB
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #34417:
URL: https://github.com/apache/spark/pull/34417#issuecomment-955603934
Thanks! Merging to master/3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34417: [MINOR][SS] Remove unused config "pauseBackgroundWorkForCommit" from RocksDB
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34417:
URL: https://github.com/apache/spark/pull/34417#issuecomment-953565787
**[Test build #144699 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144699/testReport)** for PR 34417 at commit [`dbe0c2f`](https://github.com/apache/spark/commit/dbe0c2f1308ef39f2b6ca88edc32802e73117a8b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR closed pull request #34417: [MINOR][SS] Remove unused config "pauseBackgroundWorkForCommit" from RocksDB
Posted by GitBox <gi...@apache.org>.
HeartSaVioR closed pull request #34417:
URL: https://github.com/apache/spark/pull/34417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34417: [MINOR][SS] Remove unused config "pauseBackgroundWorkForCommit" from RocksDB
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34417:
URL: https://github.com/apache/spark/pull/34417#issuecomment-953565787
**[Test build #144699 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144699/testReport)** for PR 34417 at commit [`dbe0c2f`](https://github.com/apache/spark/commit/dbe0c2f1308ef39f2b6ca88edc32802e73117a8b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34417: [MINOR][SS] Remove unused config "pauseBackgroundWorkForCommit" from RocksDB
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34417:
URL: https://github.com/apache/spark/pull/34417#issuecomment-953780883
**[Test build #144699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144699/testReport)** for PR 34417 at commit [`dbe0c2f`](https://github.com/apache/spark/commit/dbe0c2f1308ef39f2b6ca88edc32802e73117a8b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34417: [MINOR][SS] Remove unused config "pauseBackgroundWorkForCommit" from RocksDB
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34417:
URL: https://github.com/apache/spark/pull/34417#issuecomment-953602593
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49168/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34417: [MINOR][SS] Remove unused config "pauseBackgroundWorkForCommit" from RocksDB
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34417:
URL: https://github.com/apache/spark/pull/34417#issuecomment-955613125
+1, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34417: [MINOR][SS] Remove unused config "pauseBackgroundWorkForCommit" from RocksDB
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34417:
URL: https://github.com/apache/spark/pull/34417#issuecomment-953785179
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144699/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34417: [MINOR][SS] Remove unused config "pauseBackgroundWorkForCommit" from RocksDB
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34417:
URL: https://github.com/apache/spark/pull/34417#issuecomment-953659315
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49168/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34417: [MINOR][SS] Remove unused config "pauseBackgroundWorkForCommit" from RocksDB
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34417:
URL: https://github.com/apache/spark/pull/34417#issuecomment-953785179
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144699/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #34417: [MINOR][SS] Remove unused config "pauseBackgroundWorkForCommit" from RocksDB
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #34417:
URL: https://github.com/apache/spark/pull/34417#issuecomment-953821791
cc. @zsxwing @viirya @xuanyuanking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34417: [MINOR][SS] Remove unused config "pauseBackgroundWorkForCommit" from RocksDB
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34417:
URL: https://github.com/apache/spark/pull/34417#issuecomment-953644858
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49168/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34417: [MINOR][SS] Remove unused config "pauseBackgroundWorkForCommit" from RocksDB
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34417:
URL: https://github.com/apache/spark/pull/34417#issuecomment-953659315
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49168/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org