You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/12 17:14:40 UTC

[GitHub] [cloudstack] JoaoJandre commented on a diff in pull request #6245: Fix VM stats inconsistencies

JoaoJandre commented on code in PR #6245:
URL: https://github.com/apache/cloudstack/pull/6245#discussion_r848676611


##########
ui/public/locales/pl.json:
##########
@@ -623,8 +623,8 @@
 "label.diskiopswriterate": "Disk Write Rate (IOPS)",
 "label.diskioread": "Disk Read (IO)",
 "label.diskiowrite": "Disk Write (IO)",
-"label.diskkbsread": "Disk Read (Bytes)",
-"label.diskkbswrite": "Disk Write (Bytes)",
+"label.diskkbsread": "Disk Read",
+"label.diskkbswrite": "Disk Write",

Review Comment:
   They shouldn't, because these labels are used as column titles in instances tab when the metrics toggle is on. And to maintain the same pattern with the other columns, the units of measurements should be alongside the values, not the title.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org