[GitHub] williaster commented on a change in pull request #3993: [Explore view] Use POST method for charting requests

[GitBox <gi...@apache.org>]

williaster commented on a change in pull request #3993: [Explore view] Use POST method for charting requests
URL: https://github.com/apache/incubator-superset/pull/3993#discussion_r161931574
 
 

 ##########
 File path: superset/assets/javascripts/SqlLab/components/VisualizeModal.jsx
 ##########
 @@ -9,7 +9,7 @@ import { Alert, Button, Col, Modal } from 'react-bootstrap';
 import Select from 'react-select';
 import { Table } from 'reactable';
 import shortid from 'shortid';
-import { getExploreUrl } from '../../explore/exploreUtils';
+import { exportChart } from '../../explore/exploreUtils';
 
 Review comment:
   should this be called `exploreChart`?  not `export`? if the default behavior is not to export the data, it seems like `explore` is more readable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services