You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chris Cameron <ch...@contractor.verio.net> on 2013/10/30 00:02:41 UTC
Review Request 15068: Change labels for VLAN to vNet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15068/
-----------------------------------------------------------
Review request for cloudstack and Toshiaki Hatano.
Repository: cloudstack-git
Description
-------
We would like to change the labels for VLAN to vNet to make the term more generic for VXLAN and VLAN. This relates to the work being done to add in VXLAN support to Cloudstack.
Diffs
-----
client/WEB-INF/classes/resources/messages.properties 3210aca
ui/dictionary.jsp 35cba22
ui/scripts/network.js 12e5389
ui/scripts/system.js 479883c
Diff: https://reviews.apache.org/r/15068/diff/
Testing
-------
Thanks,
Chris Cameron
Re: Review Request 15068: Change labels for VLAN to vNet
Posted by Marcus Sorensen <sh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15068/#review27750
-----------------------------------------------------------
I agree with the spirit of what's being done here, but something about changing vlan to vnet just doesn't seem quite right. I guess it just doesn't pass the "obviousness" test... if someone is navigating and they see "vNet range(s)" they either have to guess that it's ok to put vlan ids in there or look up the documentation. People may assume that it refers to vxnet or some other isolation method. Ideally we'd change the label based on the network's isolation method, but if that's too much work, would it be ok to change it to "VLAN/VNI Range", or something along those lines? Most of the other labels are longer than that, so it seems like there'd be room.
- Marcus Sorensen
On Oct. 29, 2013, 11:02 p.m., Chris Cameron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15068/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 11:02 p.m.)
>
>
> Review request for cloudstack and Toshiaki Hatano.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> We would like to change the labels for VLAN to vNet to make the term more generic for VXLAN and VLAN. This relates to the work being done to add in VXLAN support to Cloudstack.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 3210aca
> ui/dictionary.jsp 35cba22
> ui/scripts/network.js 12e5389
> ui/scripts/system.js 479883c
>
> Diff: https://reviews.apache.org/r/15068/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Cameron
>
>
Re: Review Request 15068: Change labels for VLAN to vNet
Posted by Yoshikazu Nojima <ma...@ynojima.net>.
> On Nov. 4, 2013, 10:24 p.m., Jessica Wang wrote:
> > Ship It!
>
> Animesh Chaturvedi wrote:
> Has this been applied?
Yes, it has.
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=5ccf3a90abb79eace839a8e61cf950248aa913c8
- Yoshikazu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15068/#review28144
-----------------------------------------------------------
On Nov. 1, 2013, 4:52 p.m., Chris Cameron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15068/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 4:52 p.m.)
>
>
> Review request for cloudstack, Brian Federle, Jessica Wang, Marcus Sorensen, Pranav Saxena, and Toshiaki Hatano.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> We would like to change the labels for VLAN to vNet to make the term more generic for VXLAN and VLAN. This relates to the work being done to add in VXLAN support to Cloudstack.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 3210aca
> ui/dictionary.jsp 35cba22
> ui/scripts/network.js 12e5389
> ui/scripts/system.js 479883c
>
> Diff: https://reviews.apache.org/r/15068/diff/
>
>
> Testing
> -------
>
> Checked through the GUI for changed elements.
>
>
> Thanks,
>
> Chris Cameron
>
>
Re: Review Request 15068: Change labels for VLAN to vNet
Posted by Animesh Chaturvedi <An...@citrix.com>.
> On Nov. 4, 2013, 10:24 p.m., Jessica Wang wrote:
> > Ship It!
Has this been applied?
- Animesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15068/#review28144
-----------------------------------------------------------
On Nov. 1, 2013, 4:52 p.m., Chris Cameron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15068/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 4:52 p.m.)
>
>
> Review request for cloudstack, Brian Federle, Jessica Wang, Marcus Sorensen, Pranav Saxena, and Toshiaki Hatano.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> We would like to change the labels for VLAN to vNet to make the term more generic for VXLAN and VLAN. This relates to the work being done to add in VXLAN support to Cloudstack.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 3210aca
> ui/dictionary.jsp 35cba22
> ui/scripts/network.js 12e5389
> ui/scripts/system.js 479883c
>
> Diff: https://reviews.apache.org/r/15068/diff/
>
>
> Testing
> -------
>
> Checked through the GUI for changed elements.
>
>
> Thanks,
>
> Chris Cameron
>
>
Re: Review Request 15068: Change labels for VLAN to vNet
Posted by Jessica Wang <je...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15068/#review28144
-----------------------------------------------------------
Ship it!
Ship It!
- Jessica Wang
On Nov. 1, 2013, 4:52 p.m., Chris Cameron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15068/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 4:52 p.m.)
>
>
> Review request for cloudstack, Brian Federle, Jessica Wang, Marcus Sorensen, Pranav Saxena, and Toshiaki Hatano.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> We would like to change the labels for VLAN to vNet to make the term more generic for VXLAN and VLAN. This relates to the work being done to add in VXLAN support to Cloudstack.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 3210aca
> ui/dictionary.jsp 35cba22
> ui/scripts/network.js 12e5389
> ui/scripts/system.js 479883c
>
> Diff: https://reviews.apache.org/r/15068/diff/
>
>
> Testing
> -------
>
> Checked through the GUI for changed elements.
>
>
> Thanks,
>
> Chris Cameron
>
>
Re: Review Request 15068: Change labels for VLAN to vNet
Posted by Chris Cameron <ch...@contractor.verio.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15068/
-----------------------------------------------------------
(Updated Nov. 1, 2013, 4:52 p.m.)
Review request for cloudstack, Brian Federle, Jessica Wang, Marcus Sorensen, Pranav Saxena, and Toshiaki Hatano.
Changes
-------
Update the testing and people assigned.
Repository: cloudstack-git
Description
-------
We would like to change the labels for VLAN to vNet to make the term more generic for VXLAN and VLAN. This relates to the work being done to add in VXLAN support to Cloudstack.
Diffs
-----
client/WEB-INF/classes/resources/messages.properties 3210aca
ui/dictionary.jsp 35cba22
ui/scripts/network.js 12e5389
ui/scripts/system.js 479883c
Diff: https://reviews.apache.org/r/15068/diff/
Testing (updated)
-------
Checked through the GUI for changed elements.
Thanks,
Chris Cameron
Re: Review Request 15068: Change labels for VLAN to vNet
Posted by Toshiaki Hatano <ha...@haeena.net>.
> On Nov. 1, 2013, 1:28 a.m., Toshiaki Hatano wrote:
> > I suppose this should be reviewed by UI devs too.
> > Could you add UI devs in reviewers?
Other than that, this patch looks OK for me.
But this patch makes changes in UI, so I suppose it's better to check with UI ppl.
- Toshiaki
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15068/#review27992
-----------------------------------------------------------
On Oct. 30, 2013, 8:46 p.m., Chris Cameron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15068/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 8:46 p.m.)
>
>
> Review request for cloudstack and Toshiaki Hatano.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> We would like to change the labels for VLAN to vNet to make the term more generic for VXLAN and VLAN. This relates to the work being done to add in VXLAN support to Cloudstack.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 3210aca
> ui/dictionary.jsp 35cba22
> ui/scripts/network.js 12e5389
> ui/scripts/system.js 479883c
>
> Diff: https://reviews.apache.org/r/15068/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Cameron
>
>
Re: Review Request 15068: Change labels for VLAN to vNet
Posted by Sebastien Goasguen <ru...@gmail.com>.
Pinging Jessica and Brian on this review,
On Oct 31, 2013, at 9:28 PM, Toshiaki Hatano <ha...@haeena.net> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15068/#review27992
> -----------------------------------------------------------
>
>
> I suppose this should be reviewed by UI devs too.
> Could you add UI devs in reviewers?
>
> - Toshiaki Hatano
>
>
> On Oct. 30, 2013, 8:46 p.m., Chris Cameron wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/15068/
>> -----------------------------------------------------------
>>
>> (Updated Oct. 30, 2013, 8:46 p.m.)
>>
>>
>> Review request for cloudstack and Toshiaki Hatano.
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> We would like to change the labels for VLAN to vNet to make the term more generic for VXLAN and VLAN. This relates to the work being done to add in VXLAN support to Cloudstack.
>>
>>
>> Diffs
>> -----
>>
>> client/WEB-INF/classes/resources/messages.properties 3210aca
>> ui/dictionary.jsp 35cba22
>> ui/scripts/network.js 12e5389
>> ui/scripts/system.js 479883c
>>
>> Diff: https://reviews.apache.org/r/15068/diff/
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Chris Cameron
>>
>>
>
Re: Review Request 15068: Change labels for VLAN to vNet
Posted by Toshiaki Hatano <ha...@haeena.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15068/#review27992
-----------------------------------------------------------
I suppose this should be reviewed by UI devs too.
Could you add UI devs in reviewers?
- Toshiaki Hatano
On Oct. 30, 2013, 8:46 p.m., Chris Cameron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15068/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 8:46 p.m.)
>
>
> Review request for cloudstack and Toshiaki Hatano.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> We would like to change the labels for VLAN to vNet to make the term more generic for VXLAN and VLAN. This relates to the work being done to add in VXLAN support to Cloudstack.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 3210aca
> ui/dictionary.jsp 35cba22
> ui/scripts/network.js 12e5389
> ui/scripts/system.js 479883c
>
> Diff: https://reviews.apache.org/r/15068/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Cameron
>
>
Re: Review Request 15068: Change labels for VLAN to vNet
Posted by Chris Cameron <ch...@contractor.verio.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15068/
-----------------------------------------------------------
(Updated Oct. 30, 2013, 8:46 p.m.)
Review request for cloudstack and Toshiaki Hatano.
Changes
-------
I made the changes from vNet to VLAN/VNI.
Repository: cloudstack-git
Description
-------
We would like to change the labels for VLAN to vNet to make the term more generic for VXLAN and VLAN. This relates to the work being done to add in VXLAN support to Cloudstack.
Diffs (updated)
-----
client/WEB-INF/classes/resources/messages.properties 3210aca
ui/dictionary.jsp 35cba22
ui/scripts/network.js 12e5389
ui/scripts/system.js 479883c
Diff: https://reviews.apache.org/r/15068/diff/
Testing
-------
Thanks,
Chris Cameron