[jira] Commented: (DBCP-292) Adds an mbean for exposing metrics around a BasicDataSource via JMX

["Karl Palsson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DBCP-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762678#action_12762678 ] 

Karl Palsson commented on DBCP-292:
-----------------------------------

If you're using spring, you don't even need this patch, you can directly register the datasource itself as an mbean.  All this patch adds is "synchronised" around all the methods, which is arguably not essential.

If you're not using spring, then yes, you still need something to register the beans for you.

> Adds an mbean for exposing metrics around a BasicDataSource via JMX
> -------------------------------------------------------------------
>
>                 Key: DBCP-292
>                 URL: https://issues.apache.org/jira/browse/DBCP-292
>             Project: Commons Dbcp
>          Issue Type: New Feature
>    Affects Versions: 1.2.2
>            Reporter: David Horne
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: BasicDataSourceMBean.patch
>
>
> The attached patch adds an mbean that exposes the following metrics of a BasicDataSource via jmx: numActive, numIdle, maxActive, maxIdle, minIdle & maxWait.
> I have put it in a new package: org.apache.commons.dbcp.management but feel free to put it in any package you see fit.
> If using Spring the bean can be configured a little something like this:
> <bean id="dataSource" class="org.apache.commons.dbcp.BasicDataSource">
>  ...
> </bean>
> <bean id="dataSourceMBean" class="org.apache.commons.dbcp.management.BasicDataSourceMBean">
> 	<constructor-arg ref="dataSource"/>
> </bean>
> <bean id="mbeanExporter" class="org.springframework.jmx.export.MBeanExporter">
> 	<property name="beans">
> 		<map>
> 			<entry key="DBCP:name=dataSource" value-ref="dataSourceMBean"/>
> 		</map>
> 	</property>
> </bean>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.