[GitHub] [superset] simcha90 commented on a change in pull request #15644: chore: Reverts reset form in native filters

[GitBox <gi...@apache.org>]

simcha90 commented on a change in pull request #15644:
URL: https://github.com/apache/superset/pull/15644#discussion_r668525104



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
##########
@@ -164,6 +164,16 @@ export function FiltersConfigModal({
     addFilter,
   );
 
+  // After this, it should be as if the modal was just opened fresh.
+  // Called when the modal is closed.
+  const resetForm = () => {
+    form.resetFields();

Review comment:
       I think we don't need this line (`form.resetFields();`) because it cause issue that described in previous PR...
   Also form will be destroyed automatically, after modal closed
   
   
   But other line of this function is good to have - to reset local state :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org