You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by cloudsadhu <gi...@git.apache.org> on 2015/11/09 11:58:08 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...
GitHub user cloudsadhu opened a pull request:
https://github.com/apache/cloudstack/pull/1048
CLOUDSTACK-8731-checking usage event for delete volume
checking usage event for delete volume. I have incorporated all the suggested changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudsadhu/cloudstack sadhutest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1048.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1048
----
commit 635f7c272e7889cfaaa0af812d9b80d9a90f72a2
Author: sadhu suresh <sa...@citrix.com>
Date: 2015-11-09T10:49:14Z
CLOUDSTACK-8731-checking usage event for delete volume
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1048#issuecomment-164736785
can you please share test result ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1048
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1048#issuecomment-175679311
LGTM
Merging based on review, 2+LGTM and test result shared in comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...
Posted by cloudsadhu <gi...@git.apache.org>.
Github user cloudsadhu commented on the pull request:
https://github.com/apache/cloudstack/pull/1048#issuecomment-164737419
Sure please find the test results below:
@summary: Test volume delete event generation in error state condition ... === TestName: test_volume_delete_event_errorState | Status : SUCCESS ===
ok
Ran 1 test in 450.221s
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8731-checking usage event for ...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1048#issuecomment-164740710
LGTM based on code review and test case result
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---