You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/08/01 07:31:12 UTC
[james-project] 19/20: JAMES-2838 Improve rowToData readability
with variable extraction
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit f01bf2ec87d73b3c2b8aa1f481fd8ec3ad09e3e4
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Wed Jul 31 12:18:15 2019 +0200
JAMES-2838 Improve rowToData readability with variable extraction
---
.../java/org/apache/james/blob/cassandra/CassandraBucketDAO.java | 5 +++--
.../org/apache/james/blob/cassandra/CassandraDefaultBucketDAO.java | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/server/blob/blob-cassandra/src/main/java/org/apache/james/blob/cassandra/CassandraBucketDAO.java b/server/blob/blob-cassandra/src/main/java/org/apache/james/blob/cassandra/CassandraBucketDAO.java
index 0c6771a..8d355bf 100644
--- a/server/blob/blob-cassandra/src/main/java/org/apache/james/blob/cassandra/CassandraBucketDAO.java
+++ b/server/blob/blob-cassandra/src/main/java/org/apache/james/blob/cassandra/CassandraBucketDAO.java
@@ -174,8 +174,9 @@ class CassandraBucketDAO {
}
private byte[] rowToData(Row row) {
- byte[] data = new byte[row.getBytes(BucketBlobParts.DATA).remaining()];
- row.getBytes(BucketBlobParts.DATA).get(data);
+ ByteBuffer byteBuffer = row.getBytes(BucketBlobParts.DATA);
+ byte[] data = new byte[byteBuffer.remaining()];
+ byteBuffer.get(data);
return data;
}
}
diff --git a/server/blob/blob-cassandra/src/main/java/org/apache/james/blob/cassandra/CassandraDefaultBucketDAO.java b/server/blob/blob-cassandra/src/main/java/org/apache/james/blob/cassandra/CassandraDefaultBucketDAO.java
index 48c125d..3bcc99e 100644
--- a/server/blob/blob-cassandra/src/main/java/org/apache/james/blob/cassandra/CassandraDefaultBucketDAO.java
+++ b/server/blob/blob-cassandra/src/main/java/org/apache/james/blob/cassandra/CassandraDefaultBucketDAO.java
@@ -144,8 +144,9 @@ public class CassandraDefaultBucketDAO {
}
private byte[] rowToData(Row row) {
- byte[] data = new byte[row.getBytes(DefaultBucketBlobParts.DATA).remaining()];
- row.getBytes(DefaultBucketBlobParts.DATA).get(data);
+ ByteBuffer byteBuffer = row.getBytes(DefaultBucketBlobParts.DATA);
+ byte[] data = new byte[byteBuffer.remaining()];
+ byteBuffer.get(data);
return data;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org