[jira] [Created] (CONTINUUM-2765) Changes since last success appears to always compute no changes

["Brent N Atkinson (JIRA)" <ji...@apache.org>]

Brent N Atkinson created CONTINUUM-2765:
-------------------------------------------

             Summary: Changes since last success appears to always compute no changes
                 Key: CONTINUUM-2765
                 URL: https://issues.apache.org/jira/browse/CONTINUUM-2765
             Project: Continuum
          Issue Type: Bug
    Affects Versions: 1.4.2, 1.5.0
            Reporter: Brent N Atkinson


While attempting to find the root cause of CONTINUUM-2762, I discovered that the code to compute the changes since the last successful build (for display on the build results page and in notification emails) will never result in changes to display.

Specifically, {{DefaultContinuum.getChangesSinceLastSuccess(...)}} appears to be implemented with an algorithm matching the following pseudocode:

{noformat}
var changes = [ ]
var results = fetchResultsBetween(lastSuccessfulResult, currentBuildResult)
var currentBuildIndex = results.indexOf(currentBuildResult)
if (currentBuildIndex > 0) {
  for (var result in results, starting at currentBuildIndex) {
    changes.addUniqueChanges(result)
  }
}
return changes
{noformat}

The problem with this algorithm is that the fetched results never include the current build result, so no changes are ever computed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)