[jira] [Commented] (BEAM-3454) Make Unbounded to Bounded conversions on IOs able to trigger on maxNumRecords and maxReadTime combined

["Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322405#comment-16322405 ] 

Jean-Baptiste Onofré commented on BEAM-3454:
--------------------------------------------

I created another Jira related to that: https://issues.apache.org/jira/browse/BEAM-671

Actually, it doesn't make sense to have this in each unbounded IOs: it can goes in the UnboundedSource directly and dealt there, inherited by the IOs.

> Make Unbounded to Bounded conversions on IOs able to trigger on maxNumRecords and maxReadTime combined
> ------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-3454
>                 URL: https://issues.apache.org/jira/browse/BEAM-3454
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-extensions
>            Reporter: Ismaël Mejía
>            Assignee: Ryan Skraba
>            Priority: Minor
>
> Some Beam IOs expose the ability to turn an unbounded source into a bounded source. These IOs have two methods withMaxNumRecords and withMaxReadTime. Both methods are exclusive at runtime but they shouldn't be because BoundedReadFromUnboundedSource supports to combine the options so the first condition reached can stop the source if the user provides both..
> There is already a ticket for KafkaIO and a fix for KinesisIO on the works, this ticket is to add this to the other Sources (e.g. MqttIO, JmsIO, etc).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)