You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/13 07:24:37 UTC

[GitHub] [spark] grundprinzip commented on a diff in pull request #38227: [SPARK-40774][CONNECT] Add Sample to proto and Connect DSL

grundprinzip commented on code in PR #38227:
URL: https://github.com/apache/spark/pull/38227#discussion_r994254021


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -167,3 +168,11 @@ message LocalRelation {
   repeated Expression.QualifiedAttribute attributes = 1;
   // TODO: support local data.
 }
+
+message Sample {

Review Comment:
   Doc please



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org