[GitHub] [pinot] walterddr commented on a diff in pull request #8856: BUGFIX: Adding util for getting URL from InstanceConfig

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #8856:
URL: https://github.com/apache/pinot/pull/8856#discussion_r916029077


##########
pinot-common/src/main/java/org/apache/pinot/common/helix/ExtraInstanceConfig.java:
##########
@@ -44,4 +45,31 @@ public String getTlsPort() {
   public void setTlsPort(String tlsPort) {
     _proxy.getRecord().setSimpleField(PinotInstanceConfigProperty.PINOT_TLS_PORT.toString(), tlsPort);
   }
+
+  /**
+   * Returns an instance URL from the InstanceConfig. Will set the appropriate protocol and port. Returns null
+   * if the URL cannot be constructed.
+   */
+  public String getComponentUrl() {

Review Comment:
   the javadoc is not clear. is getComponentUrl returning the URL (host/port) for the component? if so. which one would it be for broker/server ? for example I think REST API calls to server should route to "adminPort" but not "port". 
   
   should we give it a better javadoc / name?



##########
pinot-controller/src/main/java/org/apache/pinot/controller/tuner/RealTimeAutoIndexTuner.java:
##########
@@ -42,4 +42,10 @@ public TableConfig apply(PinotHelixResourceManager pinotHelixResourceManager,
     initialIndexingConfig.setNoDictionaryColumns(schema.getMetricNames());
     return tableConfig;
   }
+
+  @Override
+  public TableConfig apply(PinotHelixResourceManager pinotHelixResourceManager,
+      TableConfig tableConfig, Schema schema, Map<String, String> extraProperties, Map<String, String> httpHeaders) {
+    return apply(pinotHelixResourceManager, tableConfig, schema, extraProperties);

Review Comment:
   are we ignoring the httpHeaders here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org