You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Marc Wirth (JIRA)" <ji...@codehaus.org> on 2011/01/12 17:10:57 UTC

[jira] Created: (ARCHETYPE-360) Wrong assignment in loop results in wrong debug log output

Wrong assignment in loop results in wrong debug log output
----------------------------------------------------------

                 Key: ARCHETYPE-360
                 URL: http://jira.codehaus.org/browse/ARCHETYPE-360
             Project: Maven Archetype
          Issue Type: Bug
          Components: Generator
    Affects Versions: 2.0
            Reporter: Marc Wirth
            Priority: Trivial
         Attachments: wrong_assignment.patch

The "artifactId" parameter in the processFilesetModule() method is reassigned in the while loop iterating over submodules, but the parameter is not used in the loop.

The only consequence of that is that the artifact ID logged by the {{ getLogger().debug( "Processed " + artifactId );}} line at the end of the method does not match the artifact ID logged at the start of the method {{getLogger().debug( "Processing module " + artifactId );}} if there are submodules.

Proposal: Just delete the line, see attached patch file.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (ARCHETYPE-360) Wrong assignment in loop results in wrong debug log output

Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/ARCHETYPE-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Herve Boutemy closed ARCHETYPE-360.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1
         Assignee: Herve Boutemy

patch applied in [r1063055|http://svn.apache.org/viewvc?rev=1063055&view=rev]
thank you

> Wrong assignment in loop results in wrong debug log output
> ----------------------------------------------------------
>
>                 Key: ARCHETYPE-360
>                 URL: http://jira.codehaus.org/browse/ARCHETYPE-360
>             Project: Maven Archetype
>          Issue Type: Bug
>          Components: Generator
>    Affects Versions: 2.0
>            Reporter: Marc Wirth
>            Assignee: Herve Boutemy
>            Priority: Trivial
>             Fix For: 2.1
>
>         Attachments: wrong_assignment.patch
>
>
> The "artifactId" parameter in the processFilesetModule() method is reassigned in the while loop iterating over submodules, but the parameter is not used in the loop.
> The only consequence of that is that the artifact ID logged by the {{getLogger().debug( "Processed " + artifactId );}} line at the end of the method does not match the artifact ID logged at the start of the method {{getLogger().debug( "Processing module " + artifactId );}} if there are submodules.
> Proposal: Just delete the line, see attached patch file.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (ARCHETYPE-360) Wrong assignment in loop results in wrong debug log output

Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/ARCHETYPE-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Herve Boutemy updated ARCHETYPE-360:
------------------------------------

    Description: 
The "artifactId" parameter in the processFilesetModule() method is reassigned in the while loop iterating over submodules, but the parameter is not used in the loop.

The only consequence of that is that the artifact ID logged by the {{getLogger().debug( "Processed " + artifactId );}} line at the end of the method does not match the artifact ID logged at the start of the method {{getLogger().debug( "Processing module " + artifactId );}} if there are submodules.

Proposal: Just delete the line, see attached patch file.

  was:
The "artifactId" parameter in the processFilesetModule() method is reassigned in the while loop iterating over submodules, but the parameter is not used in the loop.

The only consequence of that is that the artifact ID logged by the {{ getLogger().debug( "Processed " + artifactId );}} line at the end of the method does not match the artifact ID logged at the start of the method {{getLogger().debug( "Processing module " + artifactId );}} if there are submodules.

Proposal: Just delete the line, see attached patch file.


> Wrong assignment in loop results in wrong debug log output
> ----------------------------------------------------------
>
>                 Key: ARCHETYPE-360
>                 URL: http://jira.codehaus.org/browse/ARCHETYPE-360
>             Project: Maven Archetype
>          Issue Type: Bug
>          Components: Generator
>    Affects Versions: 2.0
>            Reporter: Marc Wirth
>            Priority: Trivial
>         Attachments: wrong_assignment.patch
>
>
> The "artifactId" parameter in the processFilesetModule() method is reassigned in the while loop iterating over submodules, but the parameter is not used in the loop.
> The only consequence of that is that the artifact ID logged by the {{getLogger().debug( "Processed " + artifactId );}} line at the end of the method does not match the artifact ID logged at the start of the method {{getLogger().debug( "Processing module " + artifactId );}} if there are submodules.
> Proposal: Just delete the line, see attached patch file.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira