You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/20 01:10:47 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #36914: [SPARK-39516][INFRA] Set a scheduled build for branch-3.3
HyukjinKwon opened a new pull request, #36914:
URL: https://github.com/apache/spark/pull/36914
### What changes were proposed in this pull request?
This PR creates a scheduled job for branch-3.3.
### Why are the changes needed?
To make sure branch-3.3 build fine.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
This is a copy of branch-3.2. Should work. Also, scheduled jobs are already broken now. I will fix them in parallel to recover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #36914: [SPARK-39516][INFRA] Set a scheduled build for branch-3.3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36914:
URL: https://github.com/apache/spark/pull/36914#issuecomment-1160025931
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36914: [SPARK-39516][INFRA] Set a scheduled build for branch-3.3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #36914:
URL: https://github.com/apache/spark/pull/36914#discussion_r901223900
##########
.github/workflows/build_and_test.yml:
##########
@@ -99,6 +101,12 @@ jobs:
echo '::set-output name=type::scheduled'
echo '::set-output name=envs::{"SKIP_MIMA": "true", "SKIP_UNIDOC": "true"}'
echo '::set-output name=hadoop::hadoop3'
+ elif [ "${{ github.event.schedule }}" = "0 19 * * *" ]; then
+ echo '::set-output name=java::8'
+ echo '::set-output name=branch::branch-3.3'
+ echo '::set-output name=type::scheduled'
+ echo '::set-output name=envs::{"SCALA_PROFILE": "scala2.13"}'
+ echo '::set-output name=hadoop::hadoop3.3'
Review Comment:
According to `run-tests.py`, `hadoop3` instead of `hadoop3.3`?
https://github.com/apache/spark/blob/77339dc6a49d1d9d2a7a3aae966610acbe1a5d6e/dev/run-tests.py#L219-L222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #36914: [SPARK-39516][INFRA] Set a scheduled build for branch-3.3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #36914: [SPARK-39516][INFRA] Set a scheduled build for branch-3.3
URL: https://github.com/apache/spark/pull/36914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36914: [SPARK-39516][INFRA] Set a scheduled build for branch-3.3
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36914:
URL: https://github.com/apache/spark/pull/36914#issuecomment-1159932681
BTW, I will work on making each scheduled build as each workflow so we can easily navigate in https://github.com/apache/spark/actions (https://issues.apache.org/jira/browse/SPARK-39521). Will have to touch these build files more there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36914: [SPARK-39516][INFRA] Set a scheduled build for branch-3.3
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #36914:
URL: https://github.com/apache/spark/pull/36914#discussion_r901226921
##########
.github/workflows/build_and_test.yml:
##########
@@ -99,6 +101,12 @@ jobs:
echo '::set-output name=type::scheduled'
echo '::set-output name=envs::{"SKIP_MIMA": "true", "SKIP_UNIDOC": "true"}'
echo '::set-output name=hadoop::hadoop3'
+ elif [ "${{ github.event.schedule }}" = "0 19 * * *" ]; then
+ echo '::set-output name=java::8'
+ echo '::set-output name=branch::branch-3.3'
+ echo '::set-output name=type::scheduled'
+ echo '::set-output name=envs::{"SCALA_PROFILE": "scala2.13"}'
+ echo '::set-output name=hadoop::hadoop3.3'
Review Comment:
Oh, yes..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36914: [SPARK-39516][INFRA] Set a scheduled build for branch-3.3
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #36914:
URL: https://github.com/apache/spark/pull/36914#discussion_r901227018
##########
.github/workflows/build_and_test.yml:
##########
@@ -99,6 +101,12 @@ jobs:
echo '::set-output name=type::scheduled'
echo '::set-output name=envs::{"SKIP_MIMA": "true", "SKIP_UNIDOC": "true"}'
echo '::set-output name=hadoop::hadoop3'
+ elif [ "${{ github.event.schedule }}" = "0 19 * * *" ]; then
+ echo '::set-output name=java::8'
+ echo '::set-output name=branch::branch-3.3'
+ echo '::set-output name=type::scheduled'
+ echo '::set-output name=envs::{"SCALA_PROFILE": "scala2.13"}'
+ echo '::set-output name=hadoop::hadoop3.3'
Review Comment:
```suggestion
echo '::set-output name=hadoop::hadoop3'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org