You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Dongjoon Hyun (JIRA)" <ji...@apache.org> on 2016/03/18 21:43:33 UTC

[jira] [Created] (SPARK-14011) Enable `LineLength` Java checkstyle rule

Dongjoon Hyun created SPARK-14011:
-------------------------------------

             Summary: Enable `LineLength` Java checkstyle rule
                 Key: SPARK-14011
                 URL: https://issues.apache.org/jira/browse/SPARK-14011
             Project: Spark
          Issue Type: Task
          Components: Examples
            Reporter: Dongjoon Hyun
            Priority: Minor


[Spark Coding Style Guide|https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide] has 100-character limit on lines, but it's disabled for Java since 11/09/15.

This issue enable *LineLength* checkstyle again. For that, this also introduces *RedundantImport* and *RedundantModifier*, too.

{code:title=dev/checkstyle.xml|borderStyle=solid}
-        <!-- TODO: 11/09/15 disabled - the lengths are currently > 100 in many places -->
-        <!--
         <module name="LineLength">
             <property name="max" value="100"/>
             <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
         </module>
-        -->
         <module name="NoLineWrap"/>
         <module name="EmptyBlock">
             <property name="option" value="TEXT"/>
@@ -167,5 +164,7 @@
         </module>
         <module name="CommentsIndentation"/>
         <module name="UnusedImports"/>
+        <module name="RedundantImport"/>
+        <module name="RedundantModifier"/>
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org