You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/10/24 04:11:45 UTC
[kudu-CR] [master] update placement logic for RF % 2 == 0
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11763
Change subject: [master] update placement logic for RF % 2 == 0
......................................................................
[master] update placement logic for RF % 2 == 0
Updated replica placement logic to properly handle even replication
factors. Added corresponding unit tests as well.
It's possible to configure Kudu to allow creation of tables with even
replication factor. I think it's easier to implement the handling
of those cases instead of adding paragraphs into relase notes and
handling possible inconsistencies in the rebalancer and other tools.
Change-Id: I4259f805090dd350f31bf3bf2b6477898214ece4
---
M src/kudu/master/placement_policy-test.cc
M src/kudu/master/placement_policy.cc
M src/kudu/master/placement_policy.h
3 files changed, 137 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/11763/1
--
To view, visit http://gerrit.cloudera.org:8080/11763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4259f805090dd350f31bf3bf2b6477898214ece4
Gerrit-Change-Number: 11763
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [master] update placement logic for RF % 2 == 0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11763 )
Change subject: [master] update placement logic for RF % 2 == 0
......................................................................
[master] update placement logic for RF % 2 == 0
Updated the logic of the replica placement in master to properly handle
even replication factors. Added corresponding unit tests as well.
It's possible to configure Kudu to allow creation of tables with an
even replication factor. I think it's easier to implement the handling
of those cases instead of handling possible inconsistencies in
the rebalancer and other tools and adding extra paragraphs into release
notes.
Change-Id: I4259f805090dd350f31bf3bf2b6477898214ece4
Reviewed-on: http://gerrit.cloudera.org:8080/11763
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/master/placement_policy-test.cc
M src/kudu/master/placement_policy.cc
M src/kudu/master/placement_policy.h
3 files changed, 137 insertions(+), 5 deletions(-)
Approvals:
Kudu Jenkins: Verified
Will Berkeley: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4259f805090dd350f31bf3bf2b6477898214ece4
Gerrit-Change-Number: 11763
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [master] update placement logic for RF % 2 == 0
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11763 )
Change subject: [master] update placement logic for RF % 2 == 0
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4259f805090dd350f31bf3bf2b6477898214ece4
Gerrit-Change-Number: 11763
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 29 Oct 2018 17:48:21 +0000
Gerrit-HasComments: No
[kudu-CR] [master] update placement logic for RF % 2 == 0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11763
to look at the new patch set (#2).
Change subject: [master] update placement logic for RF % 2 == 0
......................................................................
[master] update placement logic for RF % 2 == 0
Updated the logic of the replica placement in master to properly handle
even replication factors. Added corresponding unit tests as well.
It's possible to configure Kudu to allow creation of tables with an
even replication factor. I think it's easier to implement the handling
of those cases instead of handling possible inconsistencies in
the rebalancer and other tools and adding extra paragraphs into release
notes.
Change-Id: I4259f805090dd350f31bf3bf2b6477898214ece4
---
M src/kudu/master/placement_policy-test.cc
M src/kudu/master/placement_policy.cc
M src/kudu/master/placement_policy.h
3 files changed, 137 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/11763/2
--
To view, visit http://gerrit.cloudera.org:8080/11763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4259f805090dd350f31bf3bf2b6477898214ece4
Gerrit-Change-Number: 11763
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>