You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/13 04:58:40 UTC

[GitHub] [incubator-nuttx] btashton opened a new pull request #2290: [BACKPORT #2281] sim: Remove cxxtest specifial Make.defs

btashton opened a new pull request #2290:
URL: https://github.com/apache/incubator-nuttx/pull/2290


   ## Summary
   Backports #2281 
   
   ## Impact
   
   ## Testing
   sim:cxxtesting


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #2290: [BACKPORT #2281] sim: Remove cxxtest specifial Make.defs

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2290:
URL: https://github.com/apache/incubator-nuttx/pull/2290#issuecomment-726567173


   > @btashton please cherry-pick these patches: https://github.com/apache/incubator-nuttx/pull/2267, https://github.com/apache/incubator-nuttx/pull/2265.
   
   Thanks I'll update it in a bit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #2290: [BACKPORT #2265/#2267/#2281] sim: Remove cxxtest specifial Make.defs

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2290:
URL: https://github.com/apache/incubator-nuttx/pull/2290#issuecomment-726582843


   @xiaoxiang781216 I have added all three patches and tested it locally. Thank you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2290: [BACKPORT #2281] sim: Remove cxxtest specifial Make.defs

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2290:
URL: https://github.com/apache/incubator-nuttx/pull/2290#issuecomment-726564993


   @btashton please cherry-pick these patches: https://github.com/apache/incubator-nuttx/pull/2267, https://github.com/apache/incubator-nuttx/pull/2265.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #2290: [BACKPORT #2281] sim: Remove cxxtest specifial Make.defs

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2290:
URL: https://github.com/apache/incubator-nuttx/pull/2290#issuecomment-726515266


   @xiaoxiang781216 I think there is something else necessary for this backport besides what was in the PR:
   
   ```
   cxxtest_main.cxx: In function ‘void test_rtti()’:
   cxxtest_main.cxx:193:15: error: ‘dynamic_cast’ not permitted with ‘-fno-rtti’
     193 |   Extend *t = dynamic_cast<Extend *>(a);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~
   cxxtest_main.cxx:196:7: error: ‘dynamic_cast’ not permitted with ‘-fno-rtti’
     196 |   t = dynamic_cast<Extend *>(b);
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2290: [BACKPORT #2265/#2267/#2281] sim: Remove cxxtest specifial Make.defs

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #2290:
URL: https://github.com/apache/incubator-nuttx/pull/2290


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org