You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/21 01:36:41 UTC
[GitHub] [airflow] mik-laj opened a new issue #11705: External Redis database
mik-laj opened a new issue #11705:
URL: https://github.com/apache/airflow/issues/11705
Hello
Some users do not want to use Redis provided by Helm Chart, but want to use an external database (installed on the same cluster or in a remote service such as [Cloud Memorystore for Redis](https://cloud.google.com/memorystore/docs/redis)). It would be useful to be able to configure the deployment so that such a database would be used by Celery.
Best regards,
Kamil Breguła
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab edited a comment on issue #11705: External Redis database in the Helm Chart
Posted by GitBox <gi...@apache.org>.
FloChehab edited a comment on issue #11705:
URL: https://github.com/apache/airflow/issues/11705#issuecomment-713817609
Ok, once this is tested in pre-production on our side, i'll come back to this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on issue #11705: External Redis database in the Helm Chart
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on issue #11705:
URL: https://github.com/apache/airflow/issues/11705#issuecomment-757449095
As I mentioned in https://github.com/apache/airflow/pull/12010#issuecomment-757448775 , I'm not sure if this really needs any change in the Chart.
If I'm not wrong in my comment above, we only need a few additional lines in the doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #11705: External Redis database in the Helm Chart
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #11705:
URL: https://github.com/apache/airflow/issues/11705#issuecomment-713820149
@FloChehab This is nothing urgent for me. I wanted to create a ticket to fill in the missing functions before this Helm Chart was released. I think you can wait to release this change as we are changing the unit test framework for Helm Chart. [The new framework](https://github.com/apache/airflow/issues/11657) will be much more convenient and easy, so you can fix your defects much faster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj closed issue #11705: External Redis database in the Helm Chart
Posted by GitBox <gi...@apache.org>.
mik-laj closed issue #11705:
URL: https://github.com/apache/airflow/issues/11705
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on issue #11705: External Redis database in the Helm Chart
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #11705:
URL: https://github.com/apache/airflow/issues/11705#issuecomment-713820149
@FloChehab This is urgent for me. I wanted to create a ticket to fill in the missing feature before this Helm Chart was released. I think you can wait to release this change as we are changing the unit test framework for Helm Chart. [The new framework](https://github.com/apache/airflow/issues/11657) will be much more convenient and easy, so you can fix your defects much faster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab commented on issue #11705: External Redis database in the Helm Chart
Posted by GitBox <gi...@apache.org>.
FloChehab commented on issue #11705:
URL: https://github.com/apache/airflow/issues/11705#issuecomment-713806922
Hello, just came across this issue.
Just wanted to let you know that we have started working on it a couple days ago: https://github.com/MeilleursAgents/airflow/commit/fb421f80264556e8c07be012ccb837bc82f5ae68 (it should work).
We plan on upstreaming this change at some point.
If the change roughly looks good to you, I can work on upstreaming this a bit earlier than I thought.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab edited a comment on issue #11705: External Redis database in the Helm Chart
Posted by GitBox <gi...@apache.org>.
FloChehab edited a comment on issue #11705:
URL: https://github.com/apache/airflow/issues/11705#issuecomment-713806922
Hello, just came across this issue.
Just wanted to let you know that we have started working on it a couple days ago: https://github.com/MeilleursAgents/airflow/commit/fb421f80264556e8c07be012ccb837bc82f5ae68 (it should work).
We plan on upstreaming this change at some point.
If the change roughly looks good to you, I can work on upstreaming this a bit earlier than I thought (it currently lacks documentation and tests).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj closed issue #11705: External Redis database in the Helm Chart
Posted by GitBox <gi...@apache.org>.
mik-laj closed issue #11705:
URL: https://github.com/apache/airflow/issues/11705
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on issue #11705: External Redis database in the Helm Chart
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #11705:
URL: https://github.com/apache/airflow/issues/11705#issuecomment-713820149
@FloChehab This is **NOT** urgent for me. I wanted to create a ticket to fill in the missing feature before this Helm Chart was released. I think you can wait to release this change as we are changing the unit test framework for Helm Chart. [The new framework](https://github.com/apache/airflow/issues/11657) will be much more convenient and easy to use, so you can fix your defects much faster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on issue #11705: External Redis database in the Helm Chart
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #11705:
URL: https://github.com/apache/airflow/issues/11705#issuecomment-713820149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab commented on issue #11705: External Redis database in the Helm Chart
Posted by GitBox <gi...@apache.org>.
FloChehab commented on issue #11705:
URL: https://github.com/apache/airflow/issues/11705#issuecomment-713817609
Ok, once this is tested in pré-production on our side, i'll come back to this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab commented on issue #11705: External Redis database in the Helm Chart
Posted by GitBox <gi...@apache.org>.
FloChehab commented on issue #11705:
URL: https://github.com/apache/airflow/issues/11705#issuecomment-713823935
Sounds good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org