You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/04/21 17:33:44 UTC
Review Request 46461: Updated gperftools to version 2.5 (libprocess).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46461/
-----------------------------------------------------------
Review request for mesos and Kapil Arya.
Bugs: MESOS-3319
https://issues.apache.org/jira/browse/MESOS-3319
Repository: mesos
Description
-------
Updated gperftools to version 2.5 (libprocess).
Diffs
-----
3rdparty/libprocess/3rdparty/gperftools-2.0.tar.gz 13b03cae44e5e6dcfdec4756b975f425b2ea73cf
3rdparty/libprocess/3rdparty/gperftools-2.5.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/versions.am 5506eb3aeafb09226ba5b90dae194ece31285412
3rdparty/libprocess/configure.ac d27e46e37d4f341258cfa983b4b066973bab89fa
3rdparty/libprocess/src/profiler.cpp 58cf2fec119e65a74a3c75561ba0866ec88897d0
Diff: https://reviews.apache.org/r/46461/diff/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 46461: Updated gperftools to version 2.5
(libprocess).
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46461/#review130619
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On April 25, 2016, 1:25 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46461/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 1:25 p.m.)
>
>
> Review request for mesos and Kapil Arya.
>
>
> Bugs: MESOS-3319
> https://issues.apache.org/jira/browse/MESOS-3319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated gperftools to version 2.5 (libprocess).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/gperftools-2.0.tar.gz 13b03cae44e5e6dcfdec4756b975f425b2ea73cf
> 3rdparty/libprocess/3rdparty/gperftools-2.5.tar.gz PRE-CREATION
> 3rdparty/libprocess/3rdparty/versions.am 5506eb3
>
> Diff: https://reviews.apache.org/r/46461/diff/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 46461: Updated gperftools to version 2.5
(libprocess).
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46461/
-----------------------------------------------------------
(Updated April 25, 2016, 5:25 p.m.)
Review request for mesos and Kapil Arya.
Changes
-------
Split build system changes into a separate commit.
Bugs: MESOS-3319
https://issues.apache.org/jira/browse/MESOS-3319
Repository: mesos
Description
-------
Updated gperftools to version 2.5 (libprocess).
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/gperftools-2.0.tar.gz 13b03cae44e5e6dcfdec4756b975f425b2ea73cf
3rdparty/libprocess/3rdparty/gperftools-2.5.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/versions.am 5506eb3
Diff: https://reviews.apache.org/r/46461/diff/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 46461: Updated gperftools to version 2.5
(libprocess).
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 25, 2016, 4:01 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/configure.ac, line 853
> > <https://reviews.apache.org/r/46461/diff/2/?file=1355117#file1355117line853>
> >
> > I am wondering if we should split out this patch into two: one that updates bundled version, and second that does the HAS_GPERTOOL->ENABLE_GPERFTOOLS transition.
Good call; I split off a second review here: https://reviews.apache.org/r/46643/
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46461/#review130436
-----------------------------------------------------------
On April 25, 2016, 5:25 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46461/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 5:25 p.m.)
>
>
> Review request for mesos and Kapil Arya.
>
>
> Bugs: MESOS-3319
> https://issues.apache.org/jira/browse/MESOS-3319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated gperftools to version 2.5 (libprocess).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/gperftools-2.0.tar.gz 13b03cae44e5e6dcfdec4756b975f425b2ea73cf
> 3rdparty/libprocess/3rdparty/gperftools-2.5.tar.gz PRE-CREATION
> 3rdparty/libprocess/3rdparty/versions.am 5506eb3
>
> Diff: https://reviews.apache.org/r/46461/diff/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 46461: Updated gperftools to version 2.5
(libprocess).
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46461/#review130436
-----------------------------------------------------------
LGTM modulo the comment. Also, have you done a grep for HAS_GPERFTOOLS to ensure that there aren't any leftovers?
3rdparty/libprocess/configure.ac (line 853)
<https://reviews.apache.org/r/46461/#comment194178>
I am wondering if we should split out this patch into two: one that updates bundled version, and second that does the HAS_GPERTOOL->ENABLE_GPERFTOOLS transition.
- Kapil Arya
On April 21, 2016, 4:29 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46461/
> -----------------------------------------------------------
>
> (Updated April 21, 2016, 4:29 p.m.)
>
>
> Review request for mesos and Kapil Arya.
>
>
> Bugs: MESOS-3319
> https://issues.apache.org/jira/browse/MESOS-3319
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated gperftools to version 2.5 (libprocess).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/gperftools-2.0.tar.gz 13b03cae44e5e6dcfdec4756b975f425b2ea73cf
> 3rdparty/libprocess/3rdparty/gperftools-2.5.tar.gz PRE-CREATION
> 3rdparty/libprocess/3rdparty/versions.am 5506eb3
> 3rdparty/libprocess/configure.ac d27e46e
> 3rdparty/libprocess/src/profiler.cpp 58cf2fe
>
> Diff: https://reviews.apache.org/r/46461/diff/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 46461: Updated gperftools to version 2.5
(libprocess).
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46461/
-----------------------------------------------------------
(Updated April 21, 2016, 8:29 p.m.)
Review request for mesos and Kapil Arya.
Bugs: MESOS-3319
https://issues.apache.org/jira/browse/MESOS-3319
Repository: mesos
Description
-------
Updated gperftools to version 2.5 (libprocess).
Diffs
-----
3rdparty/libprocess/3rdparty/gperftools-2.0.tar.gz 13b03cae44e5e6dcfdec4756b975f425b2ea73cf
3rdparty/libprocess/3rdparty/gperftools-2.5.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/versions.am 5506eb3
3rdparty/libprocess/configure.ac d27e46e
3rdparty/libprocess/src/profiler.cpp 58cf2fe
Diff: https://reviews.apache.org/r/46461/diff/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 46461: Updated gperftools to version 2.5
(libprocess).
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46461/
-----------------------------------------------------------
(Updated April 21, 2016, 4:18 p.m.)
Review request for mesos and Kapil Arya.
Bugs: MESOS-3319
https://issues.apache.org/jira/browse/MESOS-3319
Repository: mesos
Description
-------
Updated gperftools to version 2.5 (libprocess).
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/gperftools-2.0.tar.gz 13b03cae44e5e6dcfdec4756b975f425b2ea73cf
3rdparty/libprocess/3rdparty/gperftools-2.5.tar.gz PRE-CREATION
3rdparty/libprocess/3rdparty/versions.am 5506eb3
3rdparty/libprocess/configure.ac d27e46e
3rdparty/libprocess/src/profiler.cpp 58cf2fe
Diff: https://reviews.apache.org/r/46461/diff/
Testing
-------
`sudo make check`
Thanks,
Greg Mann