[PATCH] You see, it did not even hurt [no more disk buffering in GetMethod]

["Kalnichevski, Oleg" <ol...@bearingpoint.com>]

Comments, critique welcome
Cheers
Oleg



-----Original Message-----
From: Ortwin Glück [mailto:ortwin.glueck@nose.ch]
Sent: Donnerstag, 23. Januar 2003 16:42
To: Commons HttpClient Project
Subject: Re: Would anyone miss GetMethod.setUseDisk()?




Jeffrey Dever wrote:
> I agree that the disk buffering methods are obsolete.  Its trivial for a 
> user to wrap our outputstream  into a fileoutputstream.  However, we 
> must remember that we are building a library as opposed to an 
> application and such be careful what we remove.  Methods that don't make 
> sense anymore should be deprecated for 2.0, but not removed untill 2.1

Good point.

> One possible enhancement to 2.1 would be to add a Cache module which 
> would work like a web browser cache to write gets to file and refers to 
> the cache before pulling the resource again.  Just a thought.

Cool, if this is something our users want. I don't want to build in 
functionality that nobody uses, though.

> <ha ha>
> Odo, like Frodo
> Ortagorn, like Aragorn
> Odomir, like Boromir
> Odli, like Gimli
> Ortrond or Elwin like Elrond
> </ha ha>

Orthanc, maybe? (hostname of my home computer actually)


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: [PATCH] You see, it did not even hurt [no more disk buffering in GetMethod]

[Jeffrey Dever <js...@sympatico.ca>]

Mike is right Oleg, that hurts more than you said!

I was just expecting a bunch of @deprecated tags and no removal of 
methods or members.  In each  @deprecated tag, it should state what 
method to use instead or how to gain equivelent functionality.

 Deprecated methods should still work, but are no longer recomended and 
are flagged for removal at a later date.

-jsd

Michael Becke wrote:

> It looks like the methods are deprecated and the functionality has 
> been removed.  I thought it was just going to be deprecated and then 
> removed in 2.1.
>
> Also, the constructors GetMethod(String path, String tempDir) and 
> GetMethod(String path, String tempDir, String tempFile) should 
> probably be deprecated.
>
> Mike
>
> Kalnichevski, Oleg wrote:
>
>> Comments, critique welcome
>> Cheers
>> Oleg
>>
>>
>>
>> -----Original Message-----
>> From: Ortwin Glück [mailto:ortwin.glueck@nose.ch]
>> Sent: Donnerstag, 23. Januar 2003 16:42
>> To: Commons HttpClient Project
>> Subject: Re: Would anyone miss GetMethod.setUseDisk()?
>>
>>
>>
>>
>> Jeffrey Dever wrote:
>>
>>> I agree that the disk buffering methods are obsolete.  Its trivial 
>>> for a user to wrap our outputstream  into a fileoutputstream.  
>>> However, we must remember that we are building a library as opposed 
>>> to an application and such be careful what we remove.  Methods that 
>>> don't make sense anymore should be deprecated for 2.0, but not 
>>> removed untill 2.1
>>
>>
>>
>> Good point.
>>
>>
>>> One possible enhancement to 2.1 would be to add a Cache module which 
>>> would work like a web browser cache to write gets to file and refers 
>>> to the cache before pulling the resource again.  Just a thought.
>>
>>
>>
>> Cool, if this is something our users want. I don't want to build in 
>> functionality that nobody uses, though.
>>
>>
>>> <ha ha>
>>> Odo, like Frodo
>>> Ortagorn, like Aragorn
>>> Odomir, like Boromir
>>> Odli, like Gimli
>>> Ortrond or Elwin like Elrond
>>> </ha ha>
>>
>>
>>
>> Orthanc, maybe? (hostname of my home computer actually)
>>
>>
>> --
>> To unsubscribe, e-mail:   
>> <ma...@jakarta.apache.org>
>> For additional commands, e-mail: 
>> <ma...@jakarta.apache.org>
>>
>>
>> ------------------------------------------------------------------------
>>
>> --
>> To unsubscribe, e-mail:   
>> <ma...@jakarta.apache.org>
>> For additional commands, e-mail: 
>> <ma...@jakarta.apache.org>
>
>
>
> --
> To unsubscribe, e-mail:   
> <ma...@jakarta.apache.org>
> For additional commands, e-mail: 
> <ma...@jakarta.apache.org>
>
>

Re: [PATCH] You see, it did not even hurt [no more disk buffering in GetMethod]

[Michael Becke <be...@u.washington.edu>]

It looks like the methods are deprecated and the functionality has been 
removed.  I thought it was just going to be deprecated and then removed 
in 2.1.

Also, the constructors GetMethod(String path, String tempDir) and 
GetMethod(String path, String tempDir, String tempFile) should probably 
be deprecated.

Mike

Kalnichevski, Oleg wrote:
> Comments, critique welcome
> Cheers
> Oleg
> 
> 
> 
> -----Original Message-----
> From: Ortwin Glück [mailto:ortwin.glueck@nose.ch]
> Sent: Donnerstag, 23. Januar 2003 16:42
> To: Commons HttpClient Project
> Subject: Re: Would anyone miss GetMethod.setUseDisk()?
> 
> 
> 
> 
> Jeffrey Dever wrote:
> 
>>I agree that the disk buffering methods are obsolete.  Its trivial for a 
>>user to wrap our outputstream  into a fileoutputstream.  However, we 
>>must remember that we are building a library as opposed to an 
>>application and such be careful what we remove.  Methods that don't make 
>>sense anymore should be deprecated for 2.0, but not removed untill 2.1
> 
> 
> Good point.
> 
> 
>>One possible enhancement to 2.1 would be to add a Cache module which 
>>would work like a web browser cache to write gets to file and refers to 
>>the cache before pulling the resource again.  Just a thought.
> 
> 
> Cool, if this is something our users want. I don't want to build in 
> functionality that nobody uses, though.
> 
> 
>><ha ha>
>>Odo, like Frodo
>>Ortagorn, like Aragorn
>>Odomir, like Boromir
>>Odli, like Gimli
>>Ortrond or Elwin like Elrond
>></ha ha>
> 
> 
> Orthanc, maybe? (hostname of my home computer actually)
> 
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
> 
> 
> ------------------------------------------------------------------------
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>