You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David Glasser <gl...@mit.edu> on 2007/07/17 14:09:44 UTC

Re: svn commit: r25768 - in branches/svnpatch-diff/subversion: include libsvn_client

On 7/17/07, cacknin@tigris.org <ca...@tigris.org> wrote:
> Author: cacknin
> Date: Tue Jul 17 06:28:55 2007
> New Revision: 25768
>
> Log:
> Import and tweak some ra_svn marshalling routines to manipulate svnpatch output
> creation.
>
> * subversion/include/svn_client.h
>   (clnt_svnpatch): add defgroup for svnpatch routines.
>
> * subversion/include/svn_client.h
> * subversion/libsvn_client/util.c
>   (svn_client_write_number, svn_client_write_string, svn_client_write_cstring,
>   svn_client_write_word, svn_client_write_proplist, svn_client_start_list,
>   svn_client_end_list, svn_client_write_tuple, svn_client_write_cmd): add
>   functions to manipulate svnpatch output.
>   (vwrite_tuple): add local function to format output.

Hmm, are these essentially duplicates of the functions in
libsvn_ra_svn/marshal.c?

If so do you have plans to eventually implement one in terms of the other?

(Note that technically the svn_ra_svn_write_* functions are in
Subversion's public interface already, though maybe we should pretend
that they aren't...)

--dave

-- 
David Glasser | glasser@mit.edu | http://www.davidglasser.net/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r25768 - in branches/svnpatch-diff/subversion: include libsvn_client

Posted by Charles Acknin <ch...@gmail.com>.
On 7/17/07, David Glasser <gl...@mit.edu> wrote:
> Hmm, are these essentially duplicates of the functions in
> libsvn_ra_svn/marshal.c?

I tweaked them a bit as svn_ra_svn_* functions are
connection-oriented, and I needed something connection-less -- that
is, I needed to write into an svn_stringbuf_t (the patch) instead of a
svn_ra_svn_conn_t.  Furthermore, I did remove all the
connection-buffer and flush stuff.

> If so do you have plans to eventually implement one in terms of the other?

If you mean to coalesce the two in one, because of the reasons I
mentioned right above it wouldn't be so trivial.

Cheers,
Charles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r25768 - in branches/svnpatch-diff/subversion: include libsvn_client

Posted by mark benedetto king <mb...@lowlatency.com>.
On Tue, Jul 17, 2007 at 04:47:52PM -0400, David Glasser wrote:
>  On 7/17/07, Daniel Rall <dl...@collab.net> wrote:
> > On Tue, 17 Jul 2007, David Glasser wrote:
> > ...
> > > (Note that technically the svn_ra_svn_write_* functions are in
> > > Subversion's public interface already, though maybe we should pretend
> > > that they aren't...)
> >
> > These days, they should live in a file like
> > include/private/svn_ra_svn_private.h, and use double-underscores.
> 
>  Right, but it's too late for that now... the question is whether or
>  not we're happy using them outside of svnserve and libsvn_ra_svn.
> 

I don't think we'd be happy using DSO symbols elsewhere.

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r25768 - in branches/svnpatch-diff/subversion: include libsvn_client

Posted by David Glasser <gl...@mit.edu>.
On 7/17/07, Daniel Rall <dl...@collab.net> wrote:
> On Tue, 17 Jul 2007, David Glasser wrote:
> ...
> > (Note that technically the svn_ra_svn_write_* functions are in
> > Subversion's public interface already, though maybe we should pretend
> > that they aren't...)
>
> These days, they should live in a file like
> include/private/svn_ra_svn_private.h, and use double-underscores.

Right, but it's too late for that now... the question is whether or
not we're happy using them outside of svnserve and libsvn_ra_svn.

--dave

-- 
David Glasser | glasser@mit.edu | http://www.davidglasser.net/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r25768 - in branches/svnpatch-diff/subversion: include libsvn_client

Posted by Daniel Rall <dl...@collab.net>.
On Tue, 17 Jul 2007, David Glasser wrote:
...
> (Note that technically the svn_ra_svn_write_* functions are in
> Subversion's public interface already, though maybe we should pretend
> that they aren't...)

These days, they should live in a file like
include/private/svn_ra_svn_private.h, and use double-underscores.