[GitHub] [tvm] leandron commented on pull request #10941: TVMC: Add new text/relay frontend

[GitBox <gi...@apache.org>]

leandron commented on PR #10941:
URL: https://github.com/apache/tvm/pull/10941#issuecomment-1095243234

   > @leandron Thank you for your feedback. I already considered using the name `relay` instead. I just though `RelayFrontend` might easy be confused with the implementations in `tvm.relay.frontend.*`.
   > 
   
   I think the package makes it clear as a distinction, so I'd be in favour or renaming `TextFrontend` to `RelayFrontend`, given it is located at `tvm.driver.tvmc.frontend.RelayFrontend`, as a module.
   
   > What do you think about adding a way to provide custom (non-constant) data for the weights? This would involve small changes to the TVMC command line as more that one input file (e.g. `mod.relay` and `mod.params`) would need to be allowed in this special case.
   
   Not sure, it feels like we should think about a file format that incorporate all these for Relay, so that we bundle all that is needed in a single file to be used and reused in TVM, rather making it a special case in tvmc? cc @areusch
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org