You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/08 15:09:00 UTC

[GitHub] [beam] nielm opened a new pull request, #21748: Add Spanner Integration tests to verify exception handling

nielm opened a new pull request, #21748:
URL: https://github.com/apache/beam/pull/21748

   Verifies that Exceptions during read should abort the pipeline.
   issue #21564
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nielm commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
nielm commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1154225701

   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1150047206

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nielm commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
nielm commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1152604885

   Unable to serialize a MapElements function?!
   Weird.
   Didn't see that in my local testing, nor when I ran integration tests on dataflow...
   
   Will investigate further...
   
   ```
   java.lang.IllegalArgumentException: unable to serialize DoFnWithExecutionInformation{doFn=org.apache.beam.sdk.transforms.MapElements$1@7e8011e2, mainOutputTag=Tag<output>, sideInputMapping={}, schemaInformation=DoFnSchemaInformation{elementConverters=[], fieldAccessDescriptor=*}}
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1157003609

   thanks! LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1152589847

   test seems broken: https://ci-beam.apache.org/job/beam_PostCommit_Java_PR/1067/testReport/junit/org.apache.beam.sdk.io.gcp.spanner/SpannerReadIT/testReadFailsBadSession/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nielm commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
nielm commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1154265321

   
   Run Java PostCommit
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1150047205

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nielm commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
nielm commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1154225812

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nielm commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
nielm commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1155155713

   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nielm commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
nielm commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1155229484

   Post Commit Tests failing on unrelated KinesisIO test: `Could not find a valid Docker environment`
   Windows Unit tests failing for unrelated reasons `Plugin [id: 'com.gradle.enterprise', version: '3.4.1', apply: false] was not found`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1150047202

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nielm commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
nielm commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1154225425

   > Unable to serialize a MapElements function?! Weird. Didn't see that in my local testing, nor when I ran integration tests on dataflow...
   
   Missed the `Caused by: java.io.NotSerializableException` lower down - I was using a lambda in a non-serializable class. Dunno how it passed my local testing /shrug 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] chamikaramj commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1151619588

   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
pabloem merged PR #21748:
URL: https://github.com/apache/beam/pull/21748


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nielm commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
nielm commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1154257202

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nielm commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
nielm commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1150048094

   r: @pabloem @chamikaramj 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1152569578

   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1154418307

   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1154422640

   phrase triggering is disabled for now it seems


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nielm commented on pull request #21748: Add Spanner Integration tests to verify exception handling

Posted by GitBox <gi...@apache.org>.
nielm commented on PR #21748:
URL: https://github.com/apache/beam/pull/21748#issuecomment-1154362024

   Run Java PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org