[GitHub] [servicecomb-kie] zhulijian1 commented on a change in pull request #121: kv history support rotate

[GitBox <gi...@apache.org>]

zhulijian1 commented on a change in pull request #121: kv history support rotate
URL: https://github.com/apache/servicecomb-kie/pull/121#discussion_r396187441
 
 

 ##########
 File path: server/service/mongo/kv/kv_dao.go
 ##########
 @@ -183,6 +183,10 @@ func deleteKV(ctx context.Context, kvID, project, domain string) error {
 	} else {
 		openlogging.Info(fmt.Sprintf("delete success,kvID=%s", kvID))
 	}
+	err = history.DeleteHistories(ctx, kvID, project, domain)
 
 Review comment:
   因为我觉得是残留数据，这个时候不删掉，就永远没办法删掉了，没有删除history的接口
   或者搞个老化机制，key删除多长时间之后清除history？

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services