[GitHub] [pulsar-helm-chart] sijie commented on a change in pull request #205: Tiered Storage config

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #205:
URL: https://github.com/apache/pulsar-helm-chart/pull/205#discussion_r788375908



##########
File path: charts/pulsar/values.yaml
##########
@@ -410,6 +410,69 @@ zookeeper:
     usePolicy: true
     maxUnavailable: 1
 
+## Tiered Storage
+##
+storageOffload: {}
+  ## General
+  ## =======
+  # bucket: <bucket>

Review comment:
       I don't think `bucket` or `region` are general settings. They don't apply to filesystem offloader.

##########
File path: charts/pulsar/values.yaml
##########
@@ -410,6 +410,69 @@ zookeeper:
     usePolicy: true
     maxUnavailable: 1
 
+## Tiered Storage
+##
+storageOffload: {}

Review comment:
       I think this section should be moved to be under `broker`. Tiered storage is a feature of the broker, not a separate component. It will make things much clearer.
   
   https://github.com/streamnative/charts/blob/master/charts/pulsar/values.yaml#L1019 is an example of how you can structure the values under `broker` section.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org