You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/30 12:24:44 UTC
[GitHub] [beam] Amar3tto opened a new pull request, #24428: [CdapIO] Update read timeout for SparkReceiverIOIT job
Amar3tto opened a new pull request, #24428:
URL: https://github.com/apache/beam/pull/24428
Relates to #24257
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24428: [CdapIO] Update read timeout for SparkReceiverIOIT job
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24428:
URL: https://github.com/apache/beam/pull/24428#issuecomment-1332544525
Test succeeded with metrics.
```
12:26:08 org.apache.beam.sdk.io.sparkreceiver.SparkReceiverIOIT > testSparkReceiverIOReadsInStreamingWithOffset STANDARD_OUT
12:26:08 Load test results for test (ID): 0f62bb8c-dd48-4ea3-9725-de202febedf9 and timestamp: 2022-11-30T16:28:36.835000000Z:
12:26:08 Metric: Value:
12:26:08 read_time 610.483
12:26:08 run_time 610.483
```
Looks like it takes 610s, in addition to setup and teardown time on dataflow so it exceeded 900s the original timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24428: [CdapIO] Update read timeout for SparkReceiverIOIT job
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24428:
URL: https://github.com/apache/beam/pull/24428#issuecomment-1334443892
Latest run passed. @Amar3tto Looks like we just need to double the timeout. Because this is a streaming pipeline and does not end itself. It will run until timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Lizzfox commented on pull request #24428: [CdapIO] Update read timeout for SparkReceiverIOIT job
Posted by GitBox <gi...@apache.org>.
Lizzfox commented on PR #24428:
URL: https://github.com/apache/beam/pull/24428#issuecomment-1332303538
@Abacn
FYI, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #24428: [CdapIO] Update read timeout for SparkReceiverIOIT job
Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #24428:
URL: https://github.com/apache/beam/pull/24428#discussion_r1036291724
##########
.test-infra/jenkins/job_PerformanceTests_SparkReceiverIO_IT.groovy:
##########
@@ -66,7 +66,7 @@ job(jobName) {
influxHost : InfluxDBCredentialsHelper.InfluxDBHostUrl,
rabbitMqBootstrapServerAddress: "amqp://guest:guest@\$${rabbitMqHostName}:5672",
streamName : 'rabbitMqTestStream',
- readTimeout : '900',
+ readTimeout : '3000',
Review Comment:
```suggestion
readTimeout : '1800',
```
##########
.test-infra/jenkins/job_PerformanceTests_SparkReceiverIO_IT.groovy:
##########
@@ -66,7 +66,7 @@ job(jobName) {
influxHost : InfluxDBCredentialsHelper.InfluxDBHostUrl,
rabbitMqBootstrapServerAddress: "amqp://guest:guest@\$${rabbitMqHostName}:5672",
streamName : 'rabbitMqTestStream',
- readTimeout : '900',
+ readTimeout : '3000',
Review Comment:
bump x2 should suffice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24428: [CdapIO] Update read timeout for SparkReceiverIOIT job
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24428:
URL: https://github.com/apache/beam/pull/24428#issuecomment-1332426659
Run Java SparkReceiverIO Performance Test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #24428: [CdapIO] Update read timeout for SparkReceiverIOIT job
Posted by GitBox <gi...@apache.org>.
Abacn merged PR #24428:
URL: https://github.com/apache/beam/pull/24428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org