You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/07 19:30:23 UTC
[GitHub] [incubator-superset] ktmud opened a new pull request #9486: feat:
change default time range in sql lab explore
ktmud opened a new pull request #9486: feat: change default time range in sql lab explore
URL: https://github.com/apache/incubator-superset/pull/9486
**Retry https://github.com/apache/incubator-superset/pull/9439 in a new branch.**
----
### CATEGORY
- [x] Enhancement (new features, refinement)
### SUMMARY
Currently when clicking on "Explore" button in SQL Lab results, it defaults the time range to "100 years ago : infinity", which is basically equivalent to no filter for most datasources. However, it has implication on how the x-axis will be plotted in certain charts (e.g., recently, the Big Number chart introduced a[ fixed range](https://github.com/apache/incubator-superset/pull/9341) option).
This PR changes the default to "No filter" so the time range filter can be more properly utilized.
There is also a global default value "[Last week](https://github.com/apache/incubator-superset/blob/893c95521b8147cce85eafade9f718867990ff75/superset-frontend/src/explore/controls.jsx#L846)", which is applied when users create a new chart from `/chart/add`. We are not changing this default value in this PR.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
When clicking on Explore in SQL Lab:
#### Before
#### After
### TEST PLAN
1. Go to any query results in SQL Lab
2. Click on "Explore"
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@kristw
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat merged pull request #9486:
feat: change default time range in sql lab explore
Posted by GitBox <gi...@apache.org>.
graceguo-supercat merged pull request #9486: feat: change default time range in sql lab explore
URL: https://github.com/apache/incubator-superset/pull/9486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw edited a comment on issue #9486: feat:
change default time range in sql lab explore
Posted by GitBox <gi...@apache.org>.
kristw edited a comment on issue #9486: feat: change default time range in sql lab explore
URL: https://github.com/apache/incubator-superset/pull/9486#issuecomment-610622202
Kinda surprise to see #9485 and #9487 passed tho. Is this the same branch or different branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on issue #9486: feat: change
default time range in sql lab explore
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #9486: feat: change default time range in sql lab explore
URL: https://github.com/apache/incubator-superset/pull/9486#issuecomment-610610915
Well... Travis passed yet GitHub integration stuck again...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro edited a comment on issue #9486:
feat: change default time range in sql lab explore
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on issue #9486: feat: change default time range in sql lab explore
URL: https://github.com/apache/incubator-superset/pull/9486#issuecomment-611181743
@ktmud would you mind trying one more rebase+force push?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on issue #9486: feat: change
default time range in sql lab explore
Posted by GitBox <gi...@apache.org>.
kristw commented on issue #9486: feat: change default time range in sql lab explore
URL: https://github.com/apache/incubator-superset/pull/9486#issuecomment-610621749
ugh........ this is frustrating.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #9486: feat:
change default time range in sql lab explore
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #9486: feat: change default time range in sql lab explore
URL: https://github.com/apache/incubator-superset/pull/9486#issuecomment-611181743
@ktmud would you mind trying one more rebase=force push?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw commented on issue #9486: feat: change
default time range in sql lab explore
Posted by GitBox <gi...@apache.org>.
kristw commented on issue #9486: feat: change default time range in sql lab explore
URL: https://github.com/apache/incubator-superset/pull/9486#issuecomment-610622202
Kinda surprise to see #9485 and #9487 passed tho.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on issue #9486: feat: change
default time range in sql lab explore
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #9486: feat: change default time range in sql lab explore
URL: https://github.com/apache/incubator-superset/pull/9486#issuecomment-611262426
OMG, this passed, too!!!!!!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on issue #9486: feat: change
default time range in sql lab explore
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #9486: feat: change default time range in sql lab explore
URL: https://github.com/apache/incubator-superset/pull/9486#issuecomment-611159855
Can someone with admin privilege just force merge this? It seems we'll never get Travis CI work for my PRs.
cc @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kristw edited a comment on issue #9486: feat:
change default time range in sql lab explore
Posted by GitBox <gi...@apache.org>.
kristw edited a comment on issue #9486: feat: change default time range in sql lab explore
URL: https://github.com/apache/incubator-superset/pull/9486#issuecomment-610622202
Kinda surprise to see #9485 and #9487 passed.
Is this PR the same branch with original PR or different branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org