You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by jmlogan <gi...@git.apache.org> on 2018/11/28 16:37:36 UTC
[GitHub] nifi pull request #3187: NIFI-5847 Added GovCloud-East region to enum list.
GitHub user jmlogan opened a pull request:
https://github.com/apache/nifi/pull/3187
NIFI-5847 Added GovCloud-East region to enum list.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmlogan/nifi NIFI-5847
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3187.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3187
----
commit a66d2066d7e16b92e05418f920c96f480cbc28a6
Author: Jonathan Logan <jm...@...>
Date: 2018-11-28T16:32:58Z
NIFI-5847 Added GovCloud-East region to enum list.
----
---
[GitHub] nifi issue #3187: NIFI-5847 Added GovCloud-East region to enum list.
Posted by zenfenan <gi...@git.apache.org>.
Github user zenfenan commented on the issue:
https://github.com/apache/nifi/pull/3187
@jmlogan It is an enum on the AWS SDK side so whatever new regions that are added to AWS cloud services, the team managing the SDK project update the enum on their side.
---
[GitHub] nifi pull request #3187: NIFI-5847 Added GovCloud-East region to enum list.
Posted by patricker <gi...@git.apache.org>.
Github user patricker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3187#discussion_r237253874
--- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/regions/AWSRegions.java ---
@@ -18,7 +18,8 @@
public enum AWSRegions {
- GovCloud("us-gov-west-1", "AWS GovCloud (US)"),
+ GovCloud("us-gov-west-1", "AWS GovCloud West (US)"),
--- End diff --
In the past, the display names have always been kept as what AWS shows.
AWS docs still show:
- AWS GovCloud (US-East)
- AWS GovCloud (US)
Maybe it would be better to revert the change to `AWS GovCloud West (US)`? Then it will match the docs.
---
[GitHub] nifi pull request #3187: NIFI-5847 Added GovCloud-East region to enum list.
Posted by jmlogan <gi...@git.apache.org>.
Github user jmlogan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3187#discussion_r237274837
--- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/regions/AWSRegions.java ---
@@ -18,7 +18,8 @@
public enum AWSRegions {
- GovCloud("us-gov-west-1", "AWS GovCloud (US)"),
+ GovCloud("us-gov-west-1", "AWS GovCloud West (US)"),
--- End diff --
I can change the display name -- what about the enum itself though? Changing the enum would break any existing flows I think? Just leave it so that GovCloud is implicitly West?
---
[GitHub] nifi issue #3187: NIFI-5847 Added GovCloud-East region to enum list.
Posted by jmlogan <gi...@git.apache.org>.
Github user jmlogan commented on the issue:
https://github.com/apache/nifi/pull/3187
There are non public regions not in that list.
On Thu, Nov 29, 2018 at 11:34 PM Sivaprasanna <no...@github.com>
wrote:
> @jmlogan <https://github.com/jmlogan> It is an enum on the AWS SDK side
> so whatever new regions that are added to AWS cloud services, the team
> managing the SDK project update the enum on their side.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/nifi/pull/3187#issuecomment-443088019>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ACILCaI6_kEJlNV4mLs4oTmBYMq0aPXNks5u0LU9gaJpZM4Y3_UK>
> .
>
---
[GitHub] nifi pull request #3187: NIFI-5847 Added GovCloud-East region to enum list.
Posted by patricker <gi...@git.apache.org>.
Github user patricker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3187#discussion_r237254575
--- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/regions/AWSRegions.java ---
@@ -18,7 +18,8 @@
public enum AWSRegions {
- GovCloud("us-gov-west-1", "AWS GovCloud (US)"),
+ GovCloud("us-gov-west-1", "AWS GovCloud West (US)"),
--- End diff --
I'm going to correct myself. Some docs say (US). Some say, `(US-West)` and `(US-East)`.
https://docs.aws.amazon.com/govcloud-us/index.html#lang/en_us
So maybe that would be better?
---
[GitHub] nifi issue #3187: NIFI-5847 Added GovCloud-East region to enum list.
Posted by jmlogan <gi...@git.apache.org>.
Github user jmlogan commented on the issue:
https://github.com/apache/nifi/pull/3187
I can close it but I was wondering how the SDK derives that list ...it
looks like it's just an enum on their side -- what about regions that
aren't in that enum? It seems like this still might be a problem for these
regions. I would imagine this is a problem that users have ran into, and
isn't being addressed in either PR.
On Thu, Nov 29, 2018 at 4:35 AM Sivaprasanna <no...@github.com>
wrote:
> *@zenfenan* commented on this pull request.
>
> As discussed in the original user mails thread, this custom enum on the
> NiFi side has to go. I raised the PR #3190
> <https://github.com/apache/nifi/pull/3190> addressing the same. With
> that, we don't have to update our enum every time there is a change.
>
> @jmlogan <https://github.com/jmlogan> Mind closing this one? If the
> intention is to have the new region added then we can update the SDK
> version in the POM which would bring the latest available regions
> automatically without even having the enum.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/nifi/pull/3187#pullrequestreview-179698941>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACILCV9sm6Poq--SUiCmjE6gAth3NHeRks5uz6pRgaJpZM4Y3_UK>
> .
>
---
[GitHub] nifi pull request #3187: NIFI-5847 Added GovCloud-East region to enum list.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/3187
---
[GitHub] nifi pull request #3187: NIFI-5847 Added GovCloud-East region to enum list.
Posted by patricker <gi...@git.apache.org>.
Github user patricker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3187#discussion_r237310352
--- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/regions/AWSRegions.java ---
@@ -18,7 +18,8 @@
public enum AWSRegions {
- GovCloud("us-gov-west-1", "AWS GovCloud (US)"),
+ GovCloud("us-gov-west-1", "AWS GovCloud West (US)"),
--- End diff --
Just the display name is all I'm worried about, everything else looks fine.
---
[GitHub] nifi issue #3187: NIFI-5847 Added GovCloud-East region to enum list.
Posted by jmlogan <gi...@git.apache.org>.
Github user jmlogan commented on the issue:
https://github.com/apache/nifi/pull/3187
The Travis build failing seems unrelated -- is there a way to trigger a rebuild?
---
[GitHub] nifi issue #3187: NIFI-5847 Added GovCloud-East region to enum list.
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/3187
Closing this PR as the original intent has been resolved with #3190. @jmlogan, if you feel like there is something to be done for additional regions that are not exposed by the AWS SDK, feel free to open a JIRA / submit a PR for that.
---