You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2014/11/18 00:53:52 UTC
Review Request 28138: Alerts UI: create unit tests for manage alert
groups
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28138/
-----------------------------------------------------------
Review request for Ambari, Aleksandr Kovalenko and Srimanth Gunturi.
Bugs: AMBARI-8359
https://issues.apache.org/jira/browse/AMBARI-8359
Repository: ambari
Description
-------
Add unit tests for manage alert groups including:
1. Testing operations on alert groups.
2. Testing operations on an alert group's definitions.
Diffs
-----
ambari-web/app/assets/test/tests.js 194a806
ambari-web/app/views/main/alert_definitions_view.js 6e9c276
ambari-web/test/controllers/main/alerts/manage_alert_groups_controller_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/28138/diff/
Testing
-------
Units tests passed
Thanks,
Xi Wang
Re: Review Request 28138: Alerts UI: create unit tests for manage
alert groups
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28138/#review62880
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Nov. 17, 2014, 11:53 p.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28138/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2014, 11:53 p.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Srimanth Gunturi.
>
>
> Bugs: AMBARI-8359
> https://issues.apache.org/jira/browse/AMBARI-8359
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add unit tests for manage alert groups including:
> 1. Testing operations on alert groups.
> 2. Testing operations on an alert group's definitions.
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js 194a806
> ambari-web/app/views/main/alert_definitions_view.js 6e9c276
> ambari-web/test/controllers/main/alerts/manage_alert_groups_controller_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28138/diff/
>
>
> Testing
> -------
>
> Units tests passed
>
>
> Thanks,
>
> Xi Wang
>
>