You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by borisroman <gi...@git.apache.org> on 2015/12/12 01:35:26 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1224
CLOUDSTACK-9146: Refactor Hypervisor KVM into default Maven directory structure.
Ping @wilderrodrigues @wido @remibergsma @miguelaferreira
Refactored the `Apache CloudStack Plugin - Hypervisor KVM` to the default Maven directory structure. Integration tests running now.
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration SUCCESS [1.130s]
[INFO] Apache CloudStack ................................. SUCCESS [0.952s]
[INFO] Apache CloudStack Maven Conventions Parent ........ SUCCESS [0.493s]
[INFO] Apache CloudStack Framework - Managed Context ..... SUCCESS [2.206s]
[INFO] Apache CloudStack Utils ........................... SUCCESS [14.631s]
[INFO] Apache CloudStack Framework ....................... SUCCESS [0.041s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [5.132s]
[INFO] Apache CloudStack Framework - Configuration ....... SUCCESS [2.746s]
[INFO] Apache CloudStack API ............................. SUCCESS [9.245s]
[INFO] Apache CloudStack Framework - REST ................ SUCCESS [1.808s]
[INFO] Apache CloudStack Framework - IPC ................. SUCCESS [2.284s]
[INFO] Apache CloudStack Cloud Engine .................... SUCCESS [0.021s]
[INFO] Apache CloudStack Cloud Engine API ................ SUCCESS [2.289s]
[INFO] Apache CloudStack Framework - Security ............ SUCCESS [1.057s]
[INFO] Apache CloudStack Core ............................ SUCCESS [12.221s]
[INFO] Apache CloudStack Agents .......................... SUCCESS [3.892s]
[INFO] Apache CloudStack Framework - Clustering .......... SUCCESS [3.063s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [1.159s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [12.131s]
[INFO] Apache CloudStack Framework - Jobs ................ SUCCESS [3.483s]
[INFO] Apache CloudStack Cloud Engine Internal Components API SUCCESS [2.743s]
[INFO] Apache CloudStack Server .......................... SUCCESS [43.936s]
[INFO] Apache CloudStack Framework - Quota ............... SUCCESS [3.422s]
[INFO] Apache CloudStack Usage Server .................... SUCCESS [4.145s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component SUCCESS [4.695s]
[INFO] Apache CloudStack Cloud Services .................. SUCCESS [0.048s]
[INFO] Apache CloudStack Secondary Storage ............... SUCCESS [0.248s]
[INFO] Apache CloudStack Secondary Storage Service ....... SUCCESS [2.592s]
[INFO] Apache CloudStack Engine Storage Component ........ SUCCESS [3.076s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [2.100s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [1.396s]
[INFO] Apache CloudStack Engine Storage Data Motion Component SUCCESS [1.213s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [1.349s]
[INFO] Apache CloudStack Engine Storage Snapshot Component SUCCESS [4.430s]
[INFO] Apache CloudStack Cloud Engine API ................ SUCCESS [1.112s]
[INFO] Apache CloudStack Cloud Engine Service ............ SUCCESS [5.387s]
[INFO] Apache CloudStack Plugin POM ...................... SUCCESS [0.468s]
[INFO] Apache CloudStack Plugin - API Rate Limit ......... SUCCESS [7.466s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider SUCCESS [3.317s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider SUCCESS [4.679s]
[INFO] Apache CloudStack Plugin - API SolidFire .......... SUCCESS [1.659s]
[INFO] Apache CloudStack Plugin - API Discovery .......... SUCCESS [2.690s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [0.940s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor SUCCESS [1.077s]
[INFO] Apache CloudStack Plugin - Explicit Dedication Processor SUCCESS [1.164s]
[INFO] Apache CloudStack Plugin - User Concentrated Pod Deployment Planner SUCCESS [0.863s]
[INFO] Apache CloudStack Plugin - User Dispersing Deployment Planner SUCCESS [0.983s]
[INFO] Apache CloudStack Plugin - Implicit Dedication Planner SUCCESS [3.363s]
[INFO] Apache CloudStack Plugin - Skip Heurestics Planner SUCCESS [1.032s]
[INFO] Apache CloudStack Plugin - Host Allocator Random .. SUCCESS [1.045s]
[INFO] Apache CloudStack Plugin - Dedicated Resources .... SUCCESS [3.140s]
[INFO] Apache CloudStack Plugin - Hypervisor OracleVM .... SUCCESS [1.455s]
[INFO] Apache CloudStack Plugin - Open vSwitch ........... SUCCESS [1.977s]
[INFO] Apache CloudStack Plugin - Hypervisor XenServer ... SUCCESS [19.840s]
[INFO] Apache CloudStack Plugin - Hypervisor KVM ......... SUCCESS [6.726s]
[INFO] Apache CloudStack Plugin - RabbitMQ Event Bus ..... SUCCESS [1.280s]
[INFO] Apache CloudStack Plugin - In Memory Event Bus .... SUCCESS [2.279s]
[INFO] Apache CloudStack Plugin - Kafka Event Bus ........ SUCCESS [1.100s]
[INFO] Apache CloudStack Plugin - Hypervisor Baremetal ... SUCCESS [2.853s]
[INFO] Apache CloudStack Plugin - Hypervisor UCS ......... SUCCESS [1.463s]
[INFO] Apache CloudStack Plugin - Hypervisor Hyper-V ..... SUCCESS [3.733s]
[INFO] Apache CloudStack Plugin - Hypervisor OracleVM3 ... SUCCESS [15.967s]
[INFO] Apache CloudStack Plugin - Network Elastic Load Balancer SUCCESS [2.659s]
[INFO] Apache CloudStack Plugin - Network Internal Load Balancer SUCCESS [5.313s]
[INFO] Apache CloudStack Framework - Spring Life Cycle ... SUCCESS [1.853s]
[INFO] Apache CloudStack Plugin - Network Juniper Contrail SUCCESS [8.393s]
[INFO] Apache CloudStack Plugin - Palo Alto .............. SUCCESS [4.205s]
[INFO] Apache CloudStack Plugin - Network Netscaler ...... SUCCESS [2.361s]
[INFO] Apache CloudStack Plugin - Network Nicira NVP ..... SUCCESS [13.078s]
[INFO] Apache CloudStack Plugin - BigSwitch Virtual Network Segment SUCCESS [6.632s]
[INFO] Apache CloudStack Plugin - Network Brocade VCS .... SUCCESS [6.946s]
[INFO] Apache CloudStack Plugin - Midokura Midonet ....... SUCCESS [4.181s]
[INFO] Apache CloudStack Plugin - Stratosphere SSP ....... SUCCESS [3.534s]
[INFO] Apache CloudStack Plugin - Network Opendaylight ... SUCCESS [3.141s]
[INFO] Apache CloudStack Plugin - Storage Allocator Random SUCCESS [1.079s]
[INFO] Apache CloudStack Plugin - User Authenticator LDAP SUCCESS [1.704s]
[INFO] Apache CloudStack Plugin - User Authenticator MD5 . SUCCESS [2.870s]
[INFO] Apache CloudStack Plugin - User Authenticator PBKDF2-SHA-256 SUCCESS [3.622s]
[INFO] Apache CloudStack Plugin - User Authenticator Plain Text SUCCESS [0.983s]
[INFO] Apache CloudStack Plugin - User Authenticator SAML2 SUCCESS [21.031s]
[INFO] Apache CloudStack Plugin - User Authenticator SHA256 Salted SUCCESS [6.691s]
[INFO] Apache CloudStack Plugin - Dns Notifier Example ... SUCCESS [1.791s]
[INFO] Apache CloudStack Plugin - Storage Image S3 provider SUCCESS [2.644s]
[INFO] Apache CloudStack Plugin - Storage Image Swift provider SUCCESS [3.209s]
[INFO] Apache CloudStack Plugin - Storage Image default provider SUCCESS [3.148s]
[INFO] Apache CloudStack Plugin - Storage Image sample provider SUCCESS [4.088s]
[INFO] Apache CloudStack Plugin - Storage Volume Nexenta Provider SUCCESS [5.345s]
[INFO] Apache CloudStack Plugin - Storage Volume CloudByte Provider SUCCESS [3.882s]
[INFO] Apache CloudStack Plugin - Storage Volume sample provider SUCCESS [3.815s]
[INFO] Apache CloudStack Plugin - SNMP Alerts ............ SUCCESS [7.045s]
[INFO] Apache CloudStack Plugin - Syslog Alerts .......... SUCCESS [4.206s]
[INFO] Apache CloudStack Plugin - Network VXLAN .......... SUCCESS [2.736s]
[INFO] Apache CloudStack Plugin - GloboDNS ............... SUCCESS [4.487s]
[INFO] Apache CloudStack Plugin - Quota Service .......... SUCCESS [3.718s]
[INFO] Apache CloudStack Framework - Spring Module ....... SUCCESS [3.682s]
[INFO] Apache CloudStack Secondary Storage Controller .... SUCCESS [1.430s]
[INFO] Apache CloudStack Client UI ....................... SUCCESS [7.698s]
[INFO] Apache CloudStack Console Proxy - RDP Client ...... SUCCESS [5.611s]
[INFO] Apache CloudStack Console Proxy ................... SUCCESS [0.190s]
[INFO] Apache CloudStack Console Proxy - Server .......... SUCCESS [2.677s]
[INFO] Apache CloudStack Framework - QuickCloud .......... SUCCESS [0.061s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 7:07.076s
[INFO] Finished at: Sat Dec 12 01:31:14 CET 2015
[INFO] Final Memory: 105M/814M
[INFO] ------------------------------------------------------------------------
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9146
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1224
----
commit 58046c60d351e3757704fedd5a71a4a087c4628e
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-12-12T00:32:11Z
CLOUDSTACK-9146: Refactor Hypervisor KVM into default Maven directory structure.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164157579
Nice one, @borisroman !
LGTM :+1:
Waiting for the test results. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164171043
@borisroman what benefits we will have?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164371097
@DaanHoogland @bhaisaab
The first thing is that using a standard is better than doing the way nobody else is doing. When one adopts a technology is essential to stick with what that technology has standardised. It help in the long run when other people, used to that technology, will join the project. In addition, ACS is not our only Maven project. So, sticking with the standard is great.
Nothing personal, but I'm not a fan of ```the only issue for me is that most users are not as agile as we want them to be.``` those kind or arguments. We have to improve, as much as we can, and it should not be stopped because other users cannot improve. What we do is to make our work better and also to help them see the better way of doing things. A bit philosophical, but I believe that we have to lead by example.
This code should have been merged before the 4.7 cut.
More on this: https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164169391
And btw LGTM! Nice one @borisroman
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164270707
@DaanHoogland @borisroman - I sincerely don't grok the benefits of these changes, which is why I'm asking what are the benefits of the changes?
Some potential issues I can think of, wrt changing file names and paths are: (1) doing branch maintenance will become difficult, so cherry-picks and backporting bugfixes will become error prone, (2) while switching branches IDEs will be slow as they would need to re-index files/paths, (3) it becomes difficult to diff across branches (like git diff branch1..branch2 some/file/path/file.txt) as files/paths have changed (I for example run sanity checks in db related files to make sure we don't change older db paths etc).
While I understand, Maven users want to have convention over configuration, other than that argument I don't understand the pros. I would request that you please hold this PR for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164174058
LGTM based on these tests (run on KVM):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \
component/test_password_server.py \
smoke/test_vpc_redundant.py \
smoke/test_routers_iptables_default_policy.py \
smoke/test_routers_network_ops.py \
smoke/test_vpc_router_nics.py \
smoke/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_vpc_vpn.py \
smoke/test_privategw_acl.py \
smoke/test_network.py
```
Result:
```
Check the password file in the Router VM ... === TestName: test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and check default routes ... === TestName: test_02_redundant_VPC_default_routes | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS ===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS ===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS ===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS ===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS ===
ok
test_01_vpc_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_rvpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_03_rvpc_privategw_static_routes | Status : SUCCESS ===
ok
Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 38 tests in 20402.881s
OK
```
And:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_service_offerings.py \
smoke/test_network.py \
component/test_vpc_offerings.py \
component/test_vpc_routers.py
```
Result:
```
Test router internal advanced zone ... === TestName: test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS ===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS ===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : SUCCESS ===
ok
Test reset virtual machine on reboot ... === TestName: test_01_reset_vm_on_reboot | Status : SUCCESS ===
ok
Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : SUCCESS ===
ok
Test migrate VM ... === TestName: test_08_migrate_vm | Status : SUCCESS ===
ok
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | Status : SUCCESS ===
ok
Test to create service offering ... === TestName: test_01_create_service_offering | Status : SUCCESS ===
ok
Test to update existing service offering ... === TestName: test_02_edit_service_offering | Status : SUCCESS ===
ok
Test to delete service offering ... === TestName: test_03_delete_service_offering | Status : SUCCESS ===
ok
Test for delete account ... === TestName: test_delete_account | Status : SUCCESS ===
ok
Test for Associate/Disassociate public IP address for admin account ... === TestName: test_public_ip_admin_account | Status : SUCCESS ===
ok
Test for Associate/Disassociate public IP address for user account ... === TestName: test_public_ip_user_account | Status : SUCCESS ===
ok
Test for release public IP address ... === TestName: test_releaseIP | Status : SUCCESS ===
ok
Test create VPC offering ... === TestName: test_01_create_vpc_offering | Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName: test_03_vpc_off_without_lb | Status : SUCCESS ===
ok
Test VPC offering without static NAT service ... === TestName: test_04_vpc_off_without_static_nat | Status : SUCCESS ===
ok
Test VPC offering without port forwarding service ... === TestName: test_05_vpc_off_without_pf | Status : SUCCESS ===
ok
Test VPC offering with invalid services ... === TestName: test_06_vpc_off_invalid_services | Status : SUCCESS ===
ok
Test update VPC offering ... === TestName: test_07_update_vpc_off | Status : SUCCESS ===
ok
Test list VPC offering ... === TestName: test_08_list_vpc_off | Status : SUCCESS ===
ok
test_09_create_redundant_vpc_offering (integration.component.test_vpc_offerings.TestVPCOffering) ... === TestName: test_09_create_redundant_vpc_offering | Status : SUCCESS ===
ok
Test start/stop of router after addition of one guest network ... === TestName: test_01_start_stop_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test reboot of router after addition of one guest network ... === TestName: test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to change service offering of router after addition of one guest network ... === TestName: test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test destroy of router after addition of one guest network ... === TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to stop and start router after creation of VPC ... === TestName: test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
ok
Test to reboot the router after creating a VPC ... === TestName: test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
ok
Tests to change service offering of the Router after ... === TestName: test_04_change_service_offerring_vpc | Status : SUCCESS ===
ok
Test to destroy the router after creating a VPC ... === TestName: test_05_destroy_router_after_creating_vpc | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 41 tests in 8459.729s
OK
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164163315
It works! Though please tests yourself for more confidence!
**Environment**
- 1 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
- Agent + Common RPMs built from source
**Integration test suite 1**
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \
component/test_password_server.py \
smoke/test_vpc_redundant.py \
smoke/test_routers_iptables_default_policy.py \
smoke/test_routers_network_ops.py \
smoke/test_vpc_router_nics.py \
smoke/test_router_dhcphosts.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_vpc_vpn.py \
smoke/test_privategw_acl.py \
smoke/test_network.py
```
**Result test suite 1**
```
Check the password file in the Router VM ... === TestName: test_isolate_network_password_server | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and check default routes ... === TestName: test_02_redundant_VPC_default_routes | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS ===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS ===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS ===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS ===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS ===
ok
test_01_vpc_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_rvpc_privategw_static_routes (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_03_rvpc_privategw_static_routes | Status : SUCCESS ===
ok
Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 38 tests in 20639.962s
OK
```
**Integration test suite 2**
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_service_offerings.py \
smoke/test_network.py \
component/test_vpc_offerings.py \
component/test_vpc_routers.py
```
**Result test suite 2**
```
Test router internal advanced zone ... === TestName: test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS ===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS ===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : SUCCESS ===
ok
Test reset virtual machine on reboot ... === TestName: test_01_reset_vm_on_reboot | Status : SUCCESS ===
ok
Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : SUCCESS ===
ok
Test migrate VM ... === TestName: test_08_migrate_vm | Status : SUCCESS ===
ok
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | Status : SUCCESS ===
ok
Test to create service offering ... === TestName: test_01_create_service_offering | Status : SUCCESS ===
ok
Test to update existing service offering ... === TestName: test_02_edit_service_offering | Status : SUCCESS ===
ok
Test to delete service offering ... === TestName: test_03_delete_service_offering | Status : SUCCESS ===
ok
Test for delete account ... === TestName: test_delete_account | Status : SUCCESS ===
ok
Test for Associate/Disassociate public IP address for admin account ... === TestName: test_public_ip_admin_account | Status : SUCCESS ===
ok
Test for Associate/Disassociate public IP address for user account ... === TestName: test_public_ip_user_account | Status : SUCCESS ===
ok
Test for release public IP address ... === TestName: test_releaseIP | Status : SUCCESS ===
ok
Test create VPC offering ... === TestName: test_01_create_vpc_offering | Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName: test_03_vpc_off_without_lb | Status : SUCCESS ===
ok
Test VPC offering without static NAT service ... === TestName: test_04_vpc_off_without_static_nat | Status : SUCCESS ===
ok
Test VPC offering without port forwarding service ... === TestName: test_05_vpc_off_without_pf | Status : SUCCESS ===
ok
Test VPC offering with invalid services ... === TestName: test_06_vpc_off_invalid_services | Status : SUCCESS ===
ok
Test update VPC offering ... === TestName: test_07_update_vpc_off | Status : SUCCESS ===
ok
Test list VPC offering ... === TestName: test_08_list_vpc_off | Status : SUCCESS ===
ok
test_09_create_redundant_vpc_offering (integration.component.test_vpc_offerings.TestVPCOffering) ... === TestName: test_09_create_redundant_vpc_offering | Status : SUCCESS ===
ok
Test start/stop of router after addition of one guest network ... === TestName: test_01_start_stop_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test reboot of router after addition of one guest network ... === TestName: test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to change service offering of router after addition of one guest network ... === TestName: test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test destroy of router after addition of one guest network ... === TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to stop and start router after creation of VPC ... === TestName: test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
ok
Test to reboot the router after creating a VPC ... === TestName: test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
ok
Tests to change service offering of the Router after ... === TestName: test_04_change_service_offerring_vpc | Status : SUCCESS ===
ok
Test to destroy the router after creating a VPC ... === TestName: test_05_destroy_router_after_creating_vpc | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 41 tests in 8952.549s
OK
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-173185348
Conflicts, won't resolve them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164169348
Since no one is making a PR to improve all modules, I would say that incremental improvement is better than no improvement at all. I have done the same to the NSX plugin and to the untold module.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164169626
@bhaisaab I think an incremental approach is better. I will also create issue for all other projects and move the each at a time. The plugin-hypervisor-kvm just happens to be the first. Once everything is moved we'll have benefits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164169497
@miguelaferreira I also think incremental is better. Keeps changed contained and documented. Else it would be a PR that changes "OVER 9999" files...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164402621
@wilderrodrigues nice rant and I agree with most except for the part where it should have been merged. There were objections so this is a clear example of a thing that shouldn't have been merged!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164272024
@bhaisaab me too, and I am willing to put it on a long track but let's investigate and discuss more
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164783572
@DaanHoogland, there was no strong argument about it. @bhaisaab doesn't as point that can stop a merge. He simply wants to make his daily tasks easier - probably because he has to keep old releases, like 4.4.x/4.5.x.
If we release 10 versions in an year, it will be a burden for certain business model - until they adapt. But that's what we want, because it will improve quality and many other things.
It should have been merged. It wasn't, but should have been. I'm not saying it has to. :)
I will let you guys decide about it.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164167703
This is codebase wide issue that we're not following the default maven directory structure for all the maven projects/modules. What is the motivation behind doing this only for KVM plugin, any benefit we would get out of this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164271374
@bhaisaab I don't like maven but we are using it! cherry-picking is really not an argument and backporting is difficult for worse reasons then this one.
Using maven we better adhere to the conventions in the maven world as keeping our diversions from it correct will become increasingly difficult over time. I will meet you half way so we can abandon 4.5 first and continue to prove our fwd-merge schedule over several versions. We will face issues in this respect as well, btw, if at the time of 4.11 we will be fixing things in 4.6 ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164271638
@DaanHoogland I'm not opposed to the change it is just that I think it makes my life challenging with some of the things I do on day-to-day basis :) We do follow all the Maven conventions except for the directory structure (src and test paths) which I thought was not end of the world.
Nevertheless, I'm curious to know what are the pros or cons of not following the Maven convention (specifically the src/ and test/ directory structure) in the long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-165057616
@wilderrodrigues ok, I see how you meant 'should' now, please convince Rohit, not me. I you want to convince me you have to argue why we should keep maven n favour of make;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164204798
LGTM, and I agree with @borisroman the incremental change is better as we had some initial problems with utils, After NSX and KVM I think we can accelerate. unless we do the wise thing and abandon maven and use make of course.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---