You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/30 12:26:00 UTC
[jira] [Commented] (FLINK-9274) Add thread name to Kafka Partition
Discovery
[ https://issues.apache.org/jira/browse/FLINK-9274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458524#comment-16458524 ]
ASF GitHub Bot commented on FLINK-9274:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/5942
[FLINK-9274][kafka] add thread name for partition discovery
## What is the purpose of the change
For debugging, threads should have names to filter on and get a quick overview. The Kafka partition discovery thread(s) currently don't have any name assigned.
## Brief change log
- set "Kafka Partition Discovery for <taskName>" as the partition discovery thread's name
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage. It was tested locally with a stacktrace of the end-to-end test.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-9274
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5942.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5942
----
----
> Add thread name to Kafka Partition Discovery
> --------------------------------------------
>
> Key: FLINK-9274
> URL: https://issues.apache.org/jira/browse/FLINK-9274
> Project: Flink
> Issue Type: Improvement
> Components: Kafka Connector
> Affects Versions: 1.4.0, 1.5.0, 1.4.1, 1.4.2, 1.6.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Major
>
> For debugging, threads should have names to filter on and get a quick overview. The Kafka partition discovery thread(s) currently don't have any name assigned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)