You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/10/05 17:20:38 UTC

svn commit: r1893918 - in /pdfbox/branches/2.0/pdfbox/src/test: java/org/apache/pdfbox/pdmodel/interactive/form/ resources/org/apache/pdfbox/pdmodel/interactive/form/

Author: tilman
Date: Tue Oct  5 17:20:38 2021
New Revision: 1893918

URL: http://svn.apache.org/viewvc?rev=1893918&view=rev
Log:
PDFBOX-5287: add test for comb alignment

Added:
    pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/CombAlignmentTest.java
      - copied, changed from r1893917, pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/CombAlignmentTest.java
    pdfbox/branches/2.0/pdfbox/src/test/resources/org/apache/pdfbox/pdmodel/interactive/form/CombTest.pdf
      - copied unchanged from r1893917, pdfbox/trunk/pdfbox/src/test/resources/org/apache/pdfbox/pdmodel/interactive/form/CombTest.pdf
    pdfbox/branches/2.0/pdfbox/src/test/resources/org/apache/pdfbox/pdmodel/interactive/form/combtest.pdf-1.png
      - copied unchanged from r1893917, pdfbox/trunk/pdfbox/src/test/resources/org/apache/pdfbox/pdmodel/interactive/form/combtest.pdf-1.png

Copied: pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/CombAlignmentTest.java (from r1893917, pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/CombAlignmentTest.java)
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/CombAlignmentTest.java?p2=pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/CombAlignmentTest.java&p1=pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/CombAlignmentTest.java&r1=1893917&r2=1893918&rev=1893918&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/CombAlignmentTest.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/CombAlignmentTest.java Tue Oct  5 17:20:38 2021
@@ -18,11 +18,10 @@ package org.apache.pdfbox.pdmodel.intera
 
 import java.io.File;
 import java.io.IOException;
-import org.apache.pdfbox.Loader;
 import org.apache.pdfbox.pdmodel.PDDocument;
 import org.apache.pdfbox.rendering.TestPDFToImage;
-import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
+import org.junit.Before;
+import org.junit.Test;
 
 /**
  *
@@ -35,7 +34,7 @@ public class CombAlignmentTest
     private static final String NAME_OF_PDF = "CombTest.pdf";
     private static final String TEST_VALUE = "1234567";
 
-    @BeforeEach
+    @Before
     public void setUp() throws IOException
     {
         OUT_DIR.mkdirs();
@@ -43,26 +42,26 @@ public class CombAlignmentTest
     
     // PDFBOX-5256
     @Test
-    void testCombFields() throws IOException
+    public void testCombFields() throws IOException
     {
-        try (PDDocument document = Loader.loadPDF(new File(IN_DIR, NAME_OF_PDF)))
+        PDDocument document = PDDocument.load(new File(IN_DIR, NAME_OF_PDF));
+        PDAcroForm acroForm = document.getDocumentCatalog().getAcroForm();
+        PDField field = acroForm.getField("PDFBoxCombLeft");
+        field.setValue(TEST_VALUE);
+        field = (PDTextField) acroForm.getField("PDFBoxCombMiddle");
+        field.setValue(TEST_VALUE);
+        field = (PDTextField) acroForm.getField("PDFBoxCombRight");
+        field.setValue(TEST_VALUE);
+        // compare rendering
+        File file = new File(OUT_DIR, NAME_OF_PDF);
+        document.save(file);
+        TestPDFToImage testPDFToImage = new TestPDFToImage(TestPDFToImage.class.getName());
+        if (!testPDFToImage.doTestFile(file, IN_DIR.getAbsolutePath(), OUT_DIR.getAbsolutePath()))
         {
-            PDAcroForm acroForm = document.getDocumentCatalog().getAcroForm();
-            PDField field = acroForm.getField("PDFBoxCombLeft");
-            field.setValue(TEST_VALUE);
-            field = (PDTextField) acroForm.getField("PDFBoxCombMiddle");
-            field.setValue(TEST_VALUE);
-            field = (PDTextField) acroForm.getField("PDFBoxCombRight");
-            field.setValue(TEST_VALUE);
-            // compare rendering
-            File file = new File(OUT_DIR, NAME_OF_PDF);
-            document.save(file);
-            if (!TestPDFToImage.doTestFile(file, IN_DIR.getAbsolutePath(), OUT_DIR.getAbsolutePath()))
-            {
-                // don't fail, rendering is different on different systems, result must be viewed manually
-                System.err.println("Rendering of " + file +
-                        " failed or is not identical to expected rendering in " + IN_DIR + " directory");
-            }
+            // don't fail, rendering is different on different systems, result must be viewed manually
+            System.err.println("Rendering of " + file +
+                    " failed or is not identical to expected rendering in " + IN_DIR + " directory");
         }
+        document.close();
     }
 }