You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by yo...@apache.org on 2023/06/19 07:42:33 UTC

[bookkeeper] 09/31: Cleanup CbThreadFactory (#3907)

This is an automated email from the ASF dual-hosted git repository.

yong pushed a commit to branch branch-4.16
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git

commit d3f8aa3389cc93f86a87f39368e1ddcbeaff9430
Author: houxiaoyu <ho...@apache.org>
AuthorDate: Wed Apr 12 22:37:52 2023 +0800

    Cleanup CbThreadFactory (#3907)
    
    * Cleanup CbThreadFactory
    
    * checkstyle
    
    (cherry picked from commit 912896deb2e748389e15e74c37539b2ff36302c7)
---
 .../src/main/java/org/apache/bookkeeper/bookie/Journal.java | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
index 4fd2c2f28d..99eaa23819 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
@@ -41,7 +41,6 @@ import java.nio.channels.FileChannel;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
-import java.util.concurrent.ThreadFactory;
 import java.util.concurrent.TimeUnit;
 import org.apache.bookkeeper.bookie.LedgerDirsManager.NoWritableLedgerDirException;
 import org.apache.bookkeeper.bookie.stats.JournalStats;
@@ -555,18 +554,6 @@ public class Journal extends BookieCriticalThread implements CheckpointSource {
         }
     }
 
-    private static class CbThreadFactory implements ThreadFactory {
-        private int counter = 0;
-        private String threadBaseName = "bookie-journal-callback";
-
-        public Thread newThread(Runnable r) {
-            int threadOrdinal = counter++;
-            Thread t = new Thread(r, threadBaseName + "-" + threadOrdinal);
-            ThreadRegistry.register(threadBaseName, threadOrdinal, t.getId());
-            return t;
-        }
-    }
-
     static final int PADDING_MASK = -0x100;
 
     static void writePaddingBytes(JournalChannel jc, ByteBuf paddingBuffer, int journalAlignSize)