You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/07/14 08:00:58 UTC
[GitHub] [cordova-plugin-camera] erisu opened a new pull request #628: Breaking/requirement bump
erisu opened a new pull request #628:
URL: https://github.com/apache/cordova-plugin-camera/pull/628
### Motivation and Context
Bump the project requirements.
- Cordova Android >= 9.0.0
- Cordova CLI >= 9.0.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] jcesarmobile commented on pull request #628: breaking: bump project requirements
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #628:
URL: https://github.com/apache/cordova-plugin-camera/pull/628#issuecomment-658269278
I think we should require cordova-ios 5.1.0, I see no reason to require 6.0.0 in this plugin.
Not being able to test on Xcode 10 is not a big problem, considering Apple requires Xcode 11 to submit apps.
I've created a thread on the mail list to talk about the engines and used this PR as an example of what I think we should be doing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] erisu commented on pull request #628: breaking: bump project requirements
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #628:
URL: https://github.com/apache/cordova-plugin-camera/pull/628#issuecomment-664821803
@jcesarmobile I set it to `cordova-ios >= 5.1.0` as you mentioned in previous comment but also debated if it should really be `>= 5.1.1`. `5.1.0` had a bug with the new WKWebViewOnly flag being and prepare ran before the platform existed. Or something like this if memory is correct. But `5.1.1` fix that prepare issue surrounding the flag.
Other then that, this PR I think is OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] jcesarmobile commented on pull request #628: breaking: bump project requirements
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #628:
URL: https://github.com/apache/cordova-plugin-camera/pull/628#issuecomment-664926104
I guess if people face the prepare bug will update from 5.1.0 to 5.1.1, but you can set it to 5.1.1 if you prefer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] erisu commented on pull request #628: Breaking/requirement bump
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #628:
URL: https://github.com/apache/cordova-plugin-camera/pull/628#issuecomment-658035149
@jcesarmobile Any thoughts on iOS requirements being set to 6.x?
I don't know if there are any breaking changes on the iOS side of this plugin, but from the current testing system standpoint (paramedic) I believe it always checks out the latest Cordova iOS (6.x) which requires Xcode 11 to be used. This means we might be only testing Xcode 11+... At least the additional tests do not pass on any version below Xcode 11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] erisu edited a comment on pull request #628: breaking: bump project requirements
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #628:
URL: https://github.com/apache/cordova-plugin-camera/pull/628#issuecomment-664821803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] erisu merged pull request #628: breaking: bump project requirements
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #628:
URL: https://github.com/apache/cordova-plugin-camera/pull/628
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org