You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2022/10/27 00:37:49 UTC
[GitHub] [guacamole-client] mike-jumper opened a new pull request, #770: GUACAMOLE-1594: Update all Java and JavaScript dependencies to latest compatible.
mike-jumper opened a new pull request, #770:
URL: https://github.com/apache/guacamole-client/pull/770
This change updates all direct Java and JavaScript dependencies to their latest compatible versions.
NOTES:
* Several WebPack plugins could not be updated as all plugins within WebPack's "webpack-contrib" have dropped support for WebPack v4 entirely, but Closure Compiler only supports WebPack v4.
* A notable exception for Java dependencies is JRadius, which appears abandoned (hasn't been updated in over six years).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] jmuehlner commented on pull request #770: GUACAMOLE-1594: Update all Java and JavaScript dependencies to latest compatible.
Posted by GitBox <gi...@apache.org>.
jmuehlner commented on PR #770:
URL: https://github.com/apache/guacamole-client/pull/770#issuecomment-1293845094
Aside from my one question above, this looks good to me. Just to be extra sure, I checked it out and built and tested the webapp and everything works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #770: GUACAMOLE-1594: Update all Java and JavaScript dependencies to latest compatible.
Posted by GitBox <gi...@apache.org>.
jmuehlner commented on code in PR #770:
URL: https://github.com/apache/guacamole-client/pull/770#discussion_r1007161585
##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/pom.xml:
##########
@@ -57,14 +57,35 @@
<dependency>
<groupId>org.mybatis</groupId>
<artifactId>mybatis</artifactId>
- <version>3.5.9</version>
+ <version>3.5.11</version>
</dependency>
<!-- MyBatis Guice -->
<dependency>
<groupId>org.mybatis</groupId>
<artifactId>mybatis-guice</artifactId>
- <version>3.10</version>
+ <version>3.17</version>
+ <exclusions>
+
+ <!-- This dependency appears to be necessary only to provide an
Review Comment:
I understand that this dependency isn't necessary for us, but I'm still unclear why it's being explicitly excluded. Doesn't seem like it could be for license reasons since it's MIT-licensed, and furthermore there's an explicit inclusion in `extensions/pom.xml` for the same artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #770: GUACAMOLE-1594: Update all Java and JavaScript dependencies to latest compatible.
Posted by GitBox <gi...@apache.org>.
jmuehlner commented on code in PR #770:
URL: https://github.com/apache/guacamole-client/pull/770#discussion_r1007209812
##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/pom.xml:
##########
@@ -57,14 +57,35 @@
<dependency>
<groupId>org.mybatis</groupId>
<artifactId>mybatis</artifactId>
- <version>3.5.9</version>
+ <version>3.5.11</version>
</dependency>
<!-- MyBatis Guice -->
<dependency>
<groupId>org.mybatis</groupId>
<artifactId>mybatis-guice</artifactId>
- <version>3.10</version>
+ <version>3.17</version>
+ <exclusions>
+
+ <!-- This dependency appears to be necessary only to provide an
Review Comment:
Cool, makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] jmuehlner merged pull request #770: GUACAMOLE-1594: Update all Java and JavaScript dependencies to latest compatible.
Posted by GitBox <gi...@apache.org>.
jmuehlner merged PR #770:
URL: https://github.com/apache/guacamole-client/pull/770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on pull request #770: GUACAMOLE-1594: Update all Java and JavaScript dependencies to latest compatible.
Posted by GitBox <gi...@apache.org>.
necouchman commented on PR #770:
URL: https://github.com/apache/guacamole-client/pull/770#issuecomment-1293551376
> A notable exception for Java dependencies is JRadius, which appears abandoned (hasn't been updated in over six years).
Yeah, and I haven't found a great replacement - RADIUS is dying a slow, painful death as a protocol, generally replaced by SSO protocols, but still widely-enough used to have some level of demand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on a diff in pull request #770: GUACAMOLE-1594: Update all Java and JavaScript dependencies to latest compatible.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on code in PR #770:
URL: https://github.com/apache/guacamole-client/pull/770#discussion_r1007196351
##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/pom.xml:
##########
@@ -57,14 +57,35 @@
<dependency>
<groupId>org.mybatis</groupId>
<artifactId>mybatis</artifactId>
- <version>3.5.9</version>
+ <version>3.5.11</version>
</dependency>
<!-- MyBatis Guice -->
<dependency>
<groupId>org.mybatis</groupId>
<artifactId>mybatis-guice</artifactId>
- <version>3.10</version>
+ <version>3.17</version>
+ <exclusions>
+
+ <!-- This dependency appears to be necessary only to provide an
Review Comment:
Well, the inclusion in `extensions/pom.xml` was an initial experiment that was inadvertently committed - I'll get rid of that.
It's excluded because we have that build-time sanity check that fails the build if any extension bundles SLF4J binaries (to prevent compatibility issues with the SLF4J bundled with the webapp). Thus, we have to do one of the following:
* Exclude the dependency if it can be verified that it's unused (I went this route)
* Override that enforcer rule within this `pom.xml` to explicitly allow bundling of `jcl-over-slf4j`.
I went the exclusion route as it was easy to verify that the code in question doesn't use commons-logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on a diff in pull request #770: GUACAMOLE-1594: Update all Java and JavaScript dependencies to latest compatible.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on code in PR #770:
URL: https://github.com/apache/guacamole-client/pull/770#discussion_r1007312799
##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/pom.xml:
##########
@@ -57,14 +57,35 @@
<dependency>
<groupId>org.mybatis</groupId>
<artifactId>mybatis</artifactId>
- <version>3.5.9</version>
+ <version>3.5.11</version>
</dependency>
<!-- MyBatis Guice -->
<dependency>
<groupId>org.mybatis</groupId>
<artifactId>mybatis-guice</artifactId>
- <version>3.10</version>
+ <version>3.17</version>
+ <exclusions>
+
+ <!-- This dependency appears to be necessary only to provide an
Review Comment:
Amended the commit to remove the change to `extensions/pom.xml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org