You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by pa-de-solminihac <gi...@git.apache.org> on 2016/04/22 19:17:13 UTC
[GitHub] cordova-android pull request: replace Integer.parseInt with BigInt...
GitHub user pa-de-solminihac opened a pull request:
https://github.com/apache/cordova-android/pull/298
replace Integer.parseInt with BigInteger so that you can use longer Android version codes
I used to have DNS like version codes (YYYYmmmddXX format) for my apps builds, and I can't go back in older apps because Google Play wont allow me to upload inferior version codes, so I thing we should to use BigInteger instead of Integer.parseInt
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pa-de-solminihac/cordova-android master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #298
----
commit db3bc3249e3e12e23a5d7bfc04de423a69f66ffd
Author: Pierre-Alexis de Solminihac <pa...@quai13.com>
Date: 2016-04-22T17:10:49Z
replace Integer.parseInt with BigInteger so that you can use longer Android version codes
I used to have DNS like version codes (YYYYmmmddXX format) for my apps builds, and I can't go back in older apps because Google Play wont allow me to upload inferior version codes, so I thing we should to use BigInteger instead of Integer.parseInt
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #298: CB-9465 replace Integer.parseInt with Big...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #298: CB-9465 replace Integer.parseInt with BigInteger...
Posted by pa-de-solminihac <gi...@git.apache.org>.
Github user pa-de-solminihac commented on the issue:
https://github.com/apache/cordova-android/pull/298
I am afraid this commit was useless (if not harmful), as [the documentation](https://developer.android.com/studio/publish/versioning.html#appversioning) states:
> Warning: The greatest value Google Play allows for versionCode is 2100000000.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #298: CB-9465 replace Integer.parseInt with BigInteger...
Posted by pa-de-solminihac <gi...@git.apache.org>.
Github user pa-de-solminihac commented on the issue:
https://github.com/apache/cordova-android/pull/298
## [Current coverage][cc-pull] is **36.13%**
> Merging [#298][cc-pull] into [master][cc-base-branch] will not change coverage
```diff
@@ master #298 diff @@
=====================================
Files 11 11
Lines 927 927
Methods 0 0
Branches 167 167
=====================================
Hits 335 335
Misses 592 592
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [e4ecbad...8d5180f][cc-compare]
[cc-base-branch]: https://codecov.io/gh/apache/cordova-android/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/apache/cordova-android/compare/e4ecbad3cb49f67db56e69a18583ed2310992262...8d5180fcb8f146ae8eadc3db973a0c4fa1ba0306
[cc-pull]: https://codecov.io/gh/apache/cordova-android/pull/298?src=pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org