You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/16 00:24:23 UTC
[GitHub] [arrow] rok opened a new pull request #12438: ARROW-15688: [C++] add_checked doesn't error out on duration overflow
rok opened a new pull request #12438:
URL: https://github.com/apache/arrow/pull/12438
This is to resolve [ARROW-15688](https://issues.apache.org/jira/browse/ARROW-15688).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12438: ARROW-15688: [C++] add_checked doesn't error out on duration overflow
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12438:
URL: https://github.com/apache/arrow/pull/12438#issuecomment-1041551621
Benchmark runs are scheduled for baseline = 07db461daad60792f7bffea4532e2ed813c2f7b8 and contender = 4f890abe1df27712e6001cbfe27b0ec4c21de8f1. 4f890abe1df27712e6001cbfe27b0ec4c21de8f1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/76a9c9d9ba9041c0b8f85e2e38a3436b...512dca59df44467b824af8547497d2f3/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4eba51f719f04a0aa17623c43d1e4264...ec54f51284ae4d5aa12d1630320d34c5/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c5291ca2c7e5481b824811831efa3d8a...c34de6fc98084acb8d16d1b067e1e870/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3af7f51b99974dd19c4a35328fd550ae...9fe74dd546974287bc6cafd87a3951dd/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12438: ARROW-15688: [C++] add_checked doesn't error out on duration overflow
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12438:
URL: https://github.com/apache/arrow/pull/12438#issuecomment-1041551621
Benchmark runs are scheduled for baseline = 07db461daad60792f7bffea4532e2ed813c2f7b8 and contender = 4f890abe1df27712e6001cbfe27b0ec4c21de8f1. 4f890abe1df27712e6001cbfe27b0ec4c21de8f1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/76a9c9d9ba9041c0b8f85e2e38a3436b...512dca59df44467b824af8547497d2f3/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4eba51f719f04a0aa17623c43d1e4264...ec54f51284ae4d5aa12d1630320d34c5/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c5291ca2c7e5481b824811831efa3d8a...c34de6fc98084acb8d16d1b067e1e870/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3af7f51b99974dd19c4a35328fd550ae...9fe74dd546974287bc6cafd87a3951dd/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on a change in pull request #12438: ARROW-15688: [C++] add_checked doesn't error out on duration overflow
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on a change in pull request #12438:
URL: https://github.com/apache/arrow/pull/12438#discussion_r807642118
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc
##########
@@ -28,13 +28,25 @@
#include "arrow/util/checked_cast.h"
#include "arrow/util/formatting.h"
#include "arrow/util/logging.h"
+#include "arrow/util/string.h"
namespace arrow {
using internal::StringFormatter;
namespace compute {
+template <typename... Elements>
+std::string MakeArray(Elements... elements) {
Review comment:
Looks this function is not very necessary. Can we directly write the test string at caller side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12438: ARROW-15688: [C++] add_checked doesn't error out on duration overflow
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12438:
URL: https://github.com/apache/arrow/pull/12438#issuecomment-1041551621
Benchmark runs are scheduled for baseline = 07db461daad60792f7bffea4532e2ed813c2f7b8 and contender = 4f890abe1df27712e6001cbfe27b0ec4c21de8f1. 4f890abe1df27712e6001cbfe27b0ec4c21de8f1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/76a9c9d9ba9041c0b8f85e2e38a3436b...512dca59df44467b824af8547497d2f3/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4eba51f719f04a0aa17623c43d1e4264...ec54f51284ae4d5aa12d1630320d34c5/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c5291ca2c7e5481b824811831efa3d8a...c34de6fc98084acb8d16d1b067e1e870/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3af7f51b99974dd19c4a35328fd550ae...9fe74dd546974287bc6cafd87a3951dd/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #12438: ARROW-15688: [C++] add_checked doesn't error out on duration overflow
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #12438:
URL: https://github.com/apache/arrow/pull/12438#discussion_r807811542
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc
##########
@@ -28,13 +28,25 @@
#include "arrow/util/checked_cast.h"
#include "arrow/util/formatting.h"
#include "arrow/util/logging.h"
+#include "arrow/util/string.h"
namespace arrow {
using internal::StringFormatter;
namespace compute {
+template <typename... Elements>
+std::string MakeArray(Elements... elements) {
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12438: ARROW-15688: [C++] add_checked doesn't error out on duration overflow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12438:
URL: https://github.com/apache/arrow/pull/12438#issuecomment-1040934145
https://issues.apache.org/jira/browse/ARROW-15688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12438: ARROW-15688: [C++] add_checked doesn't error out on duration overflow
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12438:
URL: https://github.com/apache/arrow/pull/12438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12438: ARROW-15688: [C++] add_checked doesn't error out on duration overflow
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12438:
URL: https://github.com/apache/arrow/pull/12438#issuecomment-1040934972
@pitrou thanks for spotting that one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12438: ARROW-15688: [C++] add_checked doesn't error out on duration overflow
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12438:
URL: https://github.com/apache/arrow/pull/12438#issuecomment-1041551621
Benchmark runs are scheduled for baseline = 07db461daad60792f7bffea4532e2ed813c2f7b8 and contender = 4f890abe1df27712e6001cbfe27b0ec4c21de8f1. 4f890abe1df27712e6001cbfe27b0ec4c21de8f1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/76a9c9d9ba9041c0b8f85e2e38a3436b...512dca59df44467b824af8547497d2f3/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4eba51f719f04a0aa17623c43d1e4264...ec54f51284ae4d5aa12d1630320d34c5/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c5291ca2c7e5481b824811831efa3d8a...c34de6fc98084acb8d16d1b067e1e870/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3af7f51b99974dd19c4a35328fd550ae...9fe74dd546974287bc6cafd87a3951dd/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org