You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cassandra.apache.org by Mick Semb Wever <mc...@apache.org> on 2023/08/25 15:13:30 UTC
[VOTE] Release Apache Cassandra 5.0-alpha1
Proposing the test build of Cassandra 5.0-alpha1 for release.
DISCLAIMER, this alpha release does not contain the expected 5.0
features: Vector Search (CEP-30), Transactional Cluster Metadata
(CEP-21) and Accord Transactions (CEP-15). These features will land
in a later alpha release.
Please also note that this is an alpha release and what that means, further
info at
https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle
sha1: 62cb03cc7311384db6619a102d1da6a024653fa6
Git: https://github.com/apache/cassandra/tree/5.0-alpha1-tentative
Maven Artifacts:
https://repository.apache.org/content/repositories/orgapachecassandra-1314/org/apache/cassandra/cassandra-all/5.0-alpha1/
The Source and Build Artifacts, and the Debian and RPM packages and
repositories, are available here:
https://dist.apache.org/repos/dist/dev/cassandra/5.0-alpha1/
The vote will be open for 72 hours (longer if needed). Everyone who has
tested the build is invited to vote. Votes by PMC members are considered
binding. A vote passes if there are at least three binding +1s and no -1's.
[1]: CHANGES.txt:
https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/CHANGES.txt
[2]: NEWS.txt:
https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/NEWS.txt
Re: [VOTE] Release Apache Cassandra 5.0-alpha1
Posted by Jeff Jirsa <jj...@gmail.com>.
Given the disclaimer, can you just confirm why we'd cut an alpha now -
we're trying to lock protocols and give other people an integration target,
presumably?
On Fri, Aug 25, 2023 at 8:14 AM Mick Semb Wever <mc...@apache.org> wrote:
>
> Proposing the test build of Cassandra 5.0-alpha1 for release.
>
> DISCLAIMER, this alpha release does not contain the expected 5.0
> features: Vector Search (CEP-30), Transactional Cluster Metadata
> (CEP-21) and Accord Transactions (CEP-15). These features will land
> in a later alpha release.
>
> Please also note that this is an alpha release and what that means,
> further info at
> https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle
>
> sha1: 62cb03cc7311384db6619a102d1da6a024653fa6
> Git: https://github.com/apache/cassandra/tree/5.0-alpha1-tentative
> Maven Artifacts:
> https://repository.apache.org/content/repositories/orgapachecassandra-1314/org/apache/cassandra/cassandra-all/5.0-alpha1/
>
> The Source and Build Artifacts, and the Debian and RPM packages and
> repositories, are available here:
> https://dist.apache.org/repos/dist/dev/cassandra/5.0-alpha1/
>
> The vote will be open for 72 hours (longer if needed). Everyone who has
> tested the build is invited to vote. Votes by PMC members are considered
> binding. A vote passes if there are at least three binding +1s and no -1's.
>
> [1]: CHANGES.txt:
> https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/CHANGES.txt
> [2]: NEWS.txt:
> https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/NEWS.txt
>
Re: [VOTE] Release Apache Cassandra 5.0-alpha1
Posted by "J. D. Jordan" <je...@gmail.com>.
+1 nb.
I think it’s good to get an alpha out there for people to starting trying out
the features which are done.
> On Aug 25, 2023, at 4:03 PM, Mick Semb Wever <mc...@apache.org> wrote:
>
>
>
>
>
>
>
> There was lazy consensus on this thread:
> <https://lists.apache.org/thread/mzj3dq8b7mzf60k6mkby88b9n9ywmsgw>
>
> and also the announcement about the staged release was out for a longer
> period of time to raise objections.
>
>
>
>
> Not that it's too late to object, just that it's been raised for attention
> twice now with no objections :-)
>
>
>
>
> For me, I'm keen to get it out simply because there's so many features
> coming in 5.0 it helps bring a bit more awareness to each. There's also a
> bit of a wait for TCM (from what I've heard off-thread) and we want all the
> testing we can get and it takes time to get people to come around to doing
> it.
>
>
>
>
>
>
>
> On Fri, 25 Aug 2023 at 10:36, German Eichberger via dev
> <[dev@cassandra.apache.org](mailto:dev@cassandra.apache.org)> wrote:
>
>
>> I concur. Those are major features...
>>
>> * * *
>>
>> **From:** C. Scott Andreas
<[scott@paradoxica.net](mailto:scott@paradoxica.net)>
> **Sent:** Friday, August 25, 2023 9:06 AM
> **To:** [dev@cassandra.apache.org](mailto:dev@cassandra.apache.org)
> <[dev@cassandra.apache.org](mailto:dev@cassandra.apache.org)>
> **Subject:** [EXTERNAL] Re: [VOTE] Release Apache Cassandra 5.0-alpha1
>>
>>
>>
>> |
>>
>> You don't often get email from
[scott@paradoxica.net](mailto:scott@paradoxica.net). [ Learn why this is
important](https://urldefense.com/v3/__https://aka.ms/LearnAboutSenderIdentification__;!!PbtH5S7Ebw!bvcEUfmrkyPMyuxx_Ft43Xnh8vlIjxTqWBm_34J5xeDKVOFlmlBYjPm3vXh_6EWumE90WYij-3Kwf-
UU$)
>>
>> |
>> ---|---|---
>>
>> A snapshot artifact seems more appropriate for early testing to me, rather
than a voted / released build issued by the project given how much has yet to
land.
>>
>>
>
>>
>> \- Scott
>>
>>
>
>>
>>> On Aug 25, 2023, at 8:46 AM, Ekaterina Dimitrova
<[e.dimitrova@gmail.com](mailto:e.dimitrova@gmail.com)> wrote:
>
>
>>
>>>
>>>
>>> +1
>>>
>>>
>
>>>
>>> On Fri, 25 Aug 2023 at 11:14, Mick Semb Wever
<[mck@apache.org](mailto:mck@apache.org)> wrote:
>
>>>
>>>>
> Proposing the test build of Cassandra 5.0-alpha1 for release.
>>>>
>>>>
>
>>>>
>>>> DISCLAIMER, this alpha release does not contain the expected 5.0
> features: Vector Search (CEP-30), Transactional Cluster Metadata
> (CEP-21) and Accord Transactions (CEP-15). These features will land
> in a later alpha release.
>>>>
>>>>
>
>>>>
>>>> Please also note that this is an alpha release and what that means,
further info at
<https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle>
>
> sha1: 62cb03cc7311384db6619a102d1da6a024653fa6
> Git: [
> https://github.com/apache/cassandra/tree/5.0-alpha1-tentative](https://github.com/apache/cassandra/tree/5.0-alpha1-tentative)
> Maven Artifacts: [
> https://repository.apache.org/content/repositories/orgapachecassandra-1314/org/apache/cassandra/cassandra-
> all/5.0-alpha1/](https://repository.apache.org/content/repositories/orgapachecassandra-1314/org/apache/cassandra/cassandra-
> all/5.0-alpha1/)
>
> The Source and Build Artifacts, and the Debian and RPM packages and
> repositories, are available here: [
> https://dist.apache.org/repos/dist/dev/cassandra/5.0-alpha1/](https://dist.apache.org/repos/dist/dev/cassandra/5.0-alpha1/)
>
> The vote will be open for 72 hours (longer if needed). Everyone who has
> tested the build is invited to vote. Votes by PMC members are considered
> binding. A vote passes if there are at least three binding +1s and no -1's.
>
> [1]: CHANGES.txt: [
> https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/CHANGES.txt](https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/CHANGES.txt)
> [2]: NEWS.txt: [
> https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/NEWS.txt](https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/NEWS.txt)
>
Re: [VOTE] Release Apache Cassandra 5.0-alpha1
Posted by Mick Semb Wever <mc...@apache.org>.
There was lazy consensus on this thread:
https://lists.apache.org/thread/mzj3dq8b7mzf60k6mkby88b9n9ywmsgw
and also the announcement about the staged release was out for a longer
period of time to raise objections.
Not that it's too late to object, just that it's been raised for attention
twice now with no objections :-)
For me, I'm keen to get it out simply because there's so many features
coming in 5.0 it helps bring a bit more awareness to each. There's also a
bit of a wait for TCM (from what I've heard off-thread) and we want all the
testing we can get and it takes time to get people to come around to doing
it.
On Fri, 25 Aug 2023 at 10:36, German Eichberger via dev <
dev@cassandra.apache.org> wrote:
> I concur. Those are major features...
> ------------------------------
> *From:* C. Scott Andreas <sc...@paradoxica.net>
> *Sent:* Friday, August 25, 2023 9:06 AM
> *To:* dev@cassandra.apache.org <de...@cassandra.apache.org>
> *Subject:* [EXTERNAL] Re: [VOTE] Release Apache Cassandra 5.0-alpha1
>
> You don't often get email from scott@paradoxica.net. Learn why this is
> important
> <https://urldefense.com/v3/__https://aka.ms/LearnAboutSenderIdentification__;!!PbtH5S7Ebw!bvcEUfmrkyPMyuxx_Ft43Xnh8vlIjxTqWBm_34J5xeDKVOFlmlBYjPm3vXh_6EWumE90WYij-3Kwf-UU$>
> A snapshot artifact seems more appropriate for early testing to me, rather
> than a voted / released build issued by the project given how much has yet
> to land.
>
> - Scott
>
> On Aug 25, 2023, at 8:46 AM, Ekaterina Dimitrova <e....@gmail.com>
> wrote:
>
>
> +1
>
> On Fri, 25 Aug 2023 at 11:14, Mick Semb Wever <mc...@apache.org> wrote:
>
>
> Proposing the test build of Cassandra 5.0-alpha1 for release.
>
> DISCLAIMER, this alpha release does not contain the expected 5.0
> features: Vector Search (CEP-30), Transactional Cluster Metadata
> (CEP-21) and Accord Transactions (CEP-15). These features will land
> in a later alpha release.
>
> Please also note that this is an alpha release and what that means,
> further info at
> https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle
>
> sha1: 62cb03cc7311384db6619a102d1da6a024653fa6
> Git: https://github.com/apache/cassandra/tree/5.0-alpha1-tentative
> Maven Artifacts:
> https://repository.apache.org/content/repositories/orgapachecassandra-1314/org/apache/cassandra/cassandra-all/5.0-alpha1/
>
> The Source and Build Artifacts, and the Debian and RPM packages and
> repositories, are available here:
> https://dist.apache.org/repos/dist/dev/cassandra/5.0-alpha1/
>
> The vote will be open for 72 hours (longer if needed). Everyone who has
> tested the build is invited to vote. Votes by PMC members are considered
> binding. A vote passes if there are at least three binding +1s and no -1's.
>
> [1]: CHANGES.txt:
> https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/CHANGES.txt
> [2]: NEWS.txt:
> https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/NEWS.txt
>
>
Re: [VOTE] Release Apache Cassandra 5.0-alpha1
Posted by German Eichberger via dev <de...@cassandra.apache.org>.
I concur. Those are major features...
________________________________
From: C. Scott Andreas <sc...@paradoxica.net>
Sent: Friday, August 25, 2023 9:06 AM
To: dev@cassandra.apache.org <de...@cassandra.apache.org>
Subject: [EXTERNAL] Re: [VOTE] Release Apache Cassandra 5.0-alpha1
You don't often get email from scott@paradoxica.net. Learn why this is important<https://aka.ms/LearnAboutSenderIdentification>
A snapshot artifact seems more appropriate for early testing to me, rather than a voted / released build issued by the project given how much has yet to land.
- Scott
On Aug 25, 2023, at 8:46 AM, Ekaterina Dimitrova <e....@gmail.com> wrote:
+1
On Fri, 25 Aug 2023 at 11:14, Mick Semb Wever <mc...@apache.org>> wrote:
Proposing the test build of Cassandra 5.0-alpha1 for release.
DISCLAIMER, this alpha release does not contain the expected 5.0
features: Vector Search (CEP-30), Transactional Cluster Metadata
(CEP-21) and Accord Transactions (CEP-15). These features will land
in a later alpha release.
Please also note that this is an alpha release and what that means, further info at https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle
sha1: 62cb03cc7311384db6619a102d1da6a024653fa6
Git: https://github.com/apache/cassandra/tree/5.0-alpha1-tentative
Maven Artifacts: https://repository.apache.org/content/repositories/orgapachecassandra-1314/org/apache/cassandra/cassandra-all/5.0-alpha1/
The Source and Build Artifacts, and the Debian and RPM packages and repositories, are available here: https://dist.apache.org/repos/dist/dev/cassandra/5.0-alpha1/
The vote will be open for 72 hours (longer if needed). Everyone who has tested the build is invited to vote. Votes by PMC members are considered binding. A vote passes if there are at least three binding +1s and no -1's.
[1]: CHANGES.txt: https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/CHANGES.txt
[2]: NEWS.txt: https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/NEWS.txt
Re: [VOTE] Release Apache Cassandra 5.0-alpha1
Posted by "C. Scott Andreas" <sc...@paradoxica.net>.
A snapshot artifact seems more appropriate for early testing to me, rather
than a voted / released build issued by the project given how much has yet to
land.
\- Scott
> On Aug 25, 2023, at 8:46 AM, Ekaterina Dimitrova <e....@gmail.com>
> wrote:
>
>
>
>
> +1
>
>
>
>
> On Fri, 25 Aug 2023 at 11:14, Mick Semb Wever
> <[mck@apache.org](mailto:mck@apache.org)> wrote:
>
>
>>
> Proposing the test build of Cassandra 5.0-alpha1 for release.
>>
>>
>
>>
>> DISCLAIMER, this alpha release does not contain the expected 5.0
> features: Vector Search (CEP-30), Transactional Cluster Metadata
> (CEP-21) and Accord Transactions (CEP-15). These features will land
> in a later alpha release.
>>
>>
>
>>
>> Please also note that this is an alpha release and what that means, further
info at
<https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle>
>
> sha1: 62cb03cc7311384db6619a102d1da6a024653fa6
> Git: <https://github.com/apache/cassandra/tree/5.0-alpha1-tentative>
> Maven Artifacts:
> <https://repository.apache.org/content/repositories/orgapachecassandra-1314/org/apache/cassandra/cassandra-
> all/5.0-alpha1/>
>
> The Source and Build Artifacts, and the Debian and RPM packages and
> repositories, are available here:
> <https://dist.apache.org/repos/dist/dev/cassandra/5.0-alpha1/>
>
> The vote will be open for 72 hours (longer if needed). Everyone who has
> tested the build is invited to vote. Votes by PMC members are considered
> binding. A vote passes if there are at least three binding +1s and no -1's.
>
> [1]: CHANGES.txt:
> <https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/CHANGES.txt>
> [2]: NEWS.txt:
> <https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/NEWS.txt>
>
Re: [VOTE] Release Apache Cassandra 5.0-alpha1
Posted by Ekaterina Dimitrova <e....@gmail.com>.
+1
On Fri, 25 Aug 2023 at 11:14, Mick Semb Wever <mc...@apache.org> wrote:
>
> Proposing the test build of Cassandra 5.0-alpha1 for release.
>
> DISCLAIMER, this alpha release does not contain the expected 5.0
> features: Vector Search (CEP-30), Transactional Cluster Metadata
> (CEP-21) and Accord Transactions (CEP-15). These features will land
> in a later alpha release.
>
> Please also note that this is an alpha release and what that means,
> further info at
> https://cwiki.apache.org/confluence/display/CASSANDRA/Release+Lifecycle
>
> sha1: 62cb03cc7311384db6619a102d1da6a024653fa6
> Git: https://github.com/apache/cassandra/tree/5.0-alpha1-tentative
> Maven Artifacts:
> https://repository.apache.org/content/repositories/orgapachecassandra-1314/org/apache/cassandra/cassandra-all/5.0-alpha1/
>
> The Source and Build Artifacts, and the Debian and RPM packages and
> repositories, are available here:
> https://dist.apache.org/repos/dist/dev/cassandra/5.0-alpha1/
>
> The vote will be open for 72 hours (longer if needed). Everyone who has
> tested the build is invited to vote. Votes by PMC members are considered
> binding. A vote passes if there are at least three binding +1s and no -1's.
>
> [1]: CHANGES.txt:
> https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/CHANGES.txt
> [2]: NEWS.txt:
> https://github.com/apache/cassandra/blob/5.0-alpha1-tentative/NEWS.txt
>
Re: [VOTE] Release Apache Cassandra 5.0-alpha1
Posted by "J. D. Jordan" <je...@gmail.com>.
These are not compiled code. They are serialized dumps of bloom filter data.
> On Aug 28, 2023, at 9:58 PM, Justin Mclean <jm...@apache.org> wrote:
>
> 1../test/data/serialization/3.0/utils.BloomFilter1000.bin
> 2. ./test/data/serialization/4.0/utils.BloomFilter1000.bin
[RESULT][VOTE] Release Apache Cassandra 5.0-alpha1
Posted by Mick Semb Wever <mc...@apache.org>.
vote failed with a binding veto.
On Tue, 29 Aug 2023 at 11:31, Mick Semb Wever <mc...@apache.org> wrote:
> If I were to vote on this, it would be -1 (non-binding) due to
>> non-compliance with ASF policy on releases.
>>
>> I checked:
>> - signatures and hashes are correct
>> - It looks like there might be compiled code in the release? [1][2]
>> - LICENSE is misisng some 3rd party code license information [5] This
>> contains code "Copyright DataStax, Inc." under ALv2, python-smhasher under
>> MIT, OrderedDict under MIT (copyright Raymond Hettinger) and code from
>> MagnetoDB under ALv2.
>> - LICENSE has no mention of 3rd party CRC code in [10]
>> - Note that any code under CC 4.0 is incompatible with the ALv2. [11]
>> - LICENSE also doesn't mention this file [9]
>> - In LICENSE LongTimSort.java incorrectly mentions two different
>> copyright owners
>> - In LICENSE, AbstractGuavaIterator.java is incorrectly mentioned as
>> AbstractIterator.java
>> - NOTICE seems OK but may also be missing some things due to misisng 3rd
>> party code in LICENSE under ALv2
>> - Files are misisng ASF headers [3][4][6][7][8] are these 3rd party files?
>> - I didn't try compiling from the source
>>
>
>
> I'll formalise that -1
> There's a few things here for us to fix, thanks for spending the time to
> find them.
>
Re: [VOTE] Release Apache Cassandra 5.0-alpha1
Posted by Benedict <be...@apache.org>.
Yes, my understanding is that the number is not itself copyrightable. We simply attribute in the source code as a courtesy and for future readers.
If you are concerned we can loop in legal.
> On 30 Aug 2023, at 12:29, Mick Semb Wever <mc...@apache.org> wrote:
>
>
>>
>>> - It looks like there might be compiled code in the release? [1][2]
>
>
> Non issue. Test resources.
>
>
>>> - LICENSE is missing some 3rd party code license information [5] This contains code "Copyright DataStax, Inc." under ALv2, python-smhasher under MIT, OrderedDict under MIT (copyright Raymond Hettinger) and code from MagnetoDB under ALv2.
>
>
> CASSANDRA-18807
>
>
>>> - LICENSE has no mention of 3rd party CRC code in [10]
>>> - Note that any code under CC 4.0 is incompatible with the ALv2. [11]
>
>
> This comes down to using an int number from Philip Koopman's CRC work.
> `private static final int CRC24_POLY = 0x1974F0B;`
>
> It was questioned whether a number can be copyrighted, in which case
> we would not be including third-party work here. The code comment
> explains this too.
>
> Benedict?
>
>
>>> - LICENSE also doesn't mention this file [9]
>
>
> CASSANDRA-18807
>
>
>>> - In LICENSE LongTimSort.java incorrectly mentions two different copyright owners
>>> - In LICENSE, AbstractGuavaIterator.java is incorrectly mentioned as AbstractIterator.java
>
>
> CASSANDRA-18807
>
>
>>> - NOTICE seems OK but may also be missing some things due to missing 3rd party code in LICENSE under ALv2
>
>
> No additions required.
>
>
>>> - Files are missing ASF headers [3][4][6][7][8] are these 3rd party files?
>
>
> Non issue. Doc files, or third-party files.
> Dockerfiles fixed in CASSANDRA-18807
>
>
>
>> 1../test/data/serialization/3.0/utils.BloomFilter1000.bin
>> 2. ./test/data/serialization/4.0/utils.BloomFilter1000.bin
>> 3. ./doc/modules/cassandra/examples/BASH/*.sh
>> 4. ./pylib/Dockerfile.ubuntu.*
>> 5. ./lib/cassandra-driver-internal-only-3.25.0.zip
>> 6. ./lib/cassandra-driver-3.25.0/cassandra/murmur3.py
>> 7. ./lib/cassandra-driver-3.25.0/cassandra/io/asyncioreactor.py
>> 8 ./lib/cassandra-driver-3.25.0/cassandra/io/libevwrapper.c
>> 9. ./tools/fqltool/src/org/apache/cassandra/fqltool/commands/Dump.java
>> 10. ./src/java/org/apache/cassandra/net/Crc.java
>> 11. https://www.apache.org/legal/resolved.html#cc-by
Re: [VOTE] Release Apache Cassandra 5.0-alpha1
Posted by Mick Semb Wever <mc...@apache.org>.
https://www.apache.org/legal/src-headers.html#faq-exceptions
On Thu, 31 Aug 2023 at 00:01, Justin Mclean <jm...@apache.org> wrote:
> Hi,
>
> > >> - It looks like there might be compiled code in the release? [1][2]
> > Non issue. Test resources.
>
> Test resources are not exempt - see [1]
>
> > >> - Files are missing ASF headers [3][4][6][7][8] are these 3rd party
> files?
> >
> > Non issue. Doc files, or third-party files.
> > Dockerfiles fixed in CASSANDRA-18807
>
> If they are 3rd party files, then the license needs to be included in
> LICENSE. [2] (point 2) Document files still need a header. [3]
>
> Kind Regards,
> Justin
>
> 1. https://www.apache.org/legal/release-policy.html#source-packages
> 2. https://www.apache.org/legal/src-headers.html#3party
> 3. https://www.apache.org/legal/src-headers.html#faq-docs
>
Re: [VOTE] Release Apache Cassandra 5.0-alpha1
Posted by Justin Mclean <jm...@apache.org>.
Hi,
> >> - It looks like there might be compiled code in the release? [1][2]
> Non issue. Test resources.
Test resources are not exempt - see [1]
> >> - Files are missing ASF headers [3][4][6][7][8] are these 3rd party files?
>
> Non issue. Doc files, or third-party files.
> Dockerfiles fixed in CASSANDRA-18807
If they are 3rd party files, then the license needs to be included in LICENSE. [2] (point 2) Document files still need a header. [3]
Kind Regards,
Justin
1. https://www.apache.org/legal/release-policy.html#source-packages
2. https://www.apache.org/legal/src-headers.html#3party
3. https://www.apache.org/legal/src-headers.html#faq-docs
Re: [VOTE] Release Apache Cassandra 5.0-alpha1
Posted by Mick Semb Wever <mc...@apache.org>.
>> - It looks like there might be compiled code in the release? [1][2]
Non issue. Test resources.
>> - LICENSE is missing some 3rd party code license information [5] This contains code "Copyright DataStax, Inc." under ALv2, python-smhasher under MIT, OrderedDict under MIT (copyright Raymond Hettinger) and code from MagnetoDB under ALv2.
CASSANDRA-18807
>> - LICENSE has no mention of 3rd party CRC code in [10]
>> - Note that any code under CC 4.0 is incompatible with the ALv2. [11]
This comes down to using an int number from Philip Koopman's CRC work.
`private static final int CRC24_POLY = 0x1974F0B;`
It was questioned whether a number can be copyrighted, in which case
we would not be including third-party work here. The code comment
explains this too.
Benedict?
>> - LICENSE also doesn't mention this file [9]
CASSANDRA-18807
>> - In LICENSE LongTimSort.java incorrectly mentions two different copyright owners
>> - In LICENSE, AbstractGuavaIterator.java is incorrectly mentioned as AbstractIterator.java
CASSANDRA-18807
>> - NOTICE seems OK but may also be missing some things due to missing 3rd party code in LICENSE under ALv2
No additions required.
>> - Files are missing ASF headers [3][4][6][7][8] are these 3rd party files?
Non issue. Doc files, or third-party files.
Dockerfiles fixed in CASSANDRA-18807
> 1../test/data/serialization/3.0/utils.BloomFilter1000.bin
> 2. ./test/data/serialization/4.0/utils.BloomFilter1000.bin
> 3. ./doc/modules/cassandra/examples/BASH/*.sh
> 4. ./pylib/Dockerfile.ubuntu.*
> 5. ./lib/cassandra-driver-internal-only-3.25.0.zip
> 6. ./lib/cassandra-driver-3.25.0/cassandra/murmur3.py
> 7. ./lib/cassandra-driver-3.25.0/cassandra/io/asyncioreactor.py
> 8 ./lib/cassandra-driver-3.25.0/cassandra/io/libevwrapper.c
> 9. ./tools/fqltool/src/org/apache/cassandra/fqltool/commands/Dump.java
> 10. ./src/java/org/apache/cassandra/net/Crc.java
> 11. https://www.apache.org/legal/resolved.html#cc-by
Re: [VOTE] Release Apache Cassandra 5.0-alpha1
Posted by Mick Semb Wever <mc...@apache.org>.
>
> If I were to vote on this, it would be -1 (non-binding) due to
> non-compliance with ASF policy on releases.
>
> I checked:
> - signatures and hashes are correct
> - It looks like there might be compiled code in the release? [1][2]
> - LICENSE is misisng some 3rd party code license information [5] This
> contains code "Copyright DataStax, Inc." under ALv2, python-smhasher under
> MIT, OrderedDict under MIT (copyright Raymond Hettinger) and code from
> MagnetoDB under ALv2.
> - LICENSE has no mention of 3rd party CRC code in [10]
> - Note that any code under CC 4.0 is incompatible with the ALv2. [11]
> - LICENSE also doesn't mention this file [9]
> - In LICENSE LongTimSort.java incorrectly mentions two different copyright
> owners
> - In LICENSE, AbstractGuavaIterator.java is incorrectly mentioned as
> AbstractIterator.java
> - NOTICE seems OK but may also be missing some things due to misisng 3rd
> party code in LICENSE under ALv2
> - Files are misisng ASF headers [3][4][6][7][8] are these 3rd party files?
> - I didn't try compiling from the source
>
I'll formalise that -1
There's a few things here for us to fix, thanks for spending the time to
find them.
Re: [VOTE] Release Apache Cassandra 5.0-alpha1
Posted by Henrik Ingo <he...@datastax.com>.
Reading this a week later, just wanted to point out that this discussion
already shows that releasing an alpha1 now was/is a good idea. It
immediately helped attract attention from a wider group of people, and we
can now address these issues with less stress than if all features were
already done, or there is an upcoming conference, or thanksgiving Holiday
or Christmas...
People often forget that the release machinery itself is a complex
technical system that very rarely "just works" when once a year you change
branches and version numbers...
And thanks Justin for such a pedantic review so early in our process. Very
helpful and convenient!
henrik
On Tue, Aug 29, 2023 at 5:59 AM Justin Mclean <jm...@apache.org> wrote:
> Hi,
>
> If I were to vote on this, it would be -1 (non-binding) due to
> non-compliance with ASF policy on releases.
>
> I checked:
> - signatures and hashes are correct
> - It looks like there might be compiled code in the release? [1][2]
> - LICENSE is misisng some 3rd party code license information [5] This
> contains code "Copyright DataStax, Inc." under ALv2, python-smhasher under
> MIT, OrderedDict under MIT (copyright Raymond Hettinger) and code from
> MagnetoDB under ALv2.
> - LICENSE has no mention of 3rd party CRC code in [10]
> - Note that any code under CC 4.0 is incompatible with the ALv2. [11]
> - LICENSE also doesn't mention this file [9]
> - In LICENSE LongTimSort.java incorrectly mentions two different copyright
> owners
> - In LICENSE, AbstractGuavaIterator.java is incorrectly mentioned as
> AbstractIterator.java
> - NOTICE seems OK but may also be missing some things due to misisng 3rd
> party code in LICENSE under ALv2
> - Files are misisng ASF headers [3][4][6][7][8] are these 3rd party files?
> - I didn't try compiling from the source
>
> Kind Regards,
> Justin
>
> 1../test/data/serialization/3.0/utils.BloomFilter1000.bin
> 2. ./test/data/serialization/4.0/utils.BloomFilter1000.bin
> 3. ./doc/modules/cassandra/examples/BASH/*.sh
> 4. ./pylib/Dockerfile.ubuntu.*
> 5. ./lib/cassandra-driver-internal-only-3.25.0.zip
> 6. ./lib/cassandra-driver-3.25.0/cassandra/murmur3.py
> 7. ./lib/cassandra-driver-3.25.0/cassandra/io/asyncioreactor.py
> 8 ./lib/cassandra-driver-3.25.0/cassandra/io/libevwrapper.c
> 9. ./tools/fqltool/src/org/apache/cassandra/fqltool/commands/Dump.java
> 10. ./src/java/org/apache/cassandra/net/Crc.java
> 11. https://www.apache.org/legal/resolved.html#cc-by
>
--
Henrik Ingo
c. +358 40 569 7354
w. www.datastax.com
<https://www.facebook.com/datastax> <https://twitter.com/datastax>
<https://www.linkedin.com/company/datastax/> <https://github.com/datastax/>
Re: [VOTE] Release Apache Cassandra 5.0-alpha1
Posted by Justin Mclean <jm...@apache.org>.
Hi,
If I were to vote on this, it would be -1 (non-binding) due to non-compliance with ASF policy on releases.
I checked:
- signatures and hashes are correct
- It looks like there might be compiled code in the release? [1][2]
- LICENSE is misisng some 3rd party code license information [5] This contains code "Copyright DataStax, Inc." under ALv2, python-smhasher under MIT, OrderedDict under MIT (copyright Raymond Hettinger) and code from MagnetoDB under ALv2.
- LICENSE has no mention of 3rd party CRC code in [10]
- Note that any code under CC 4.0 is incompatible with the ALv2. [11]
- LICENSE also doesn't mention this file [9]
- In LICENSE LongTimSort.java incorrectly mentions two different copyright owners
- In LICENSE, AbstractGuavaIterator.java is incorrectly mentioned as AbstractIterator.java
- NOTICE seems OK but may also be missing some things due to misisng 3rd party code in LICENSE under ALv2
- Files are misisng ASF headers [3][4][6][7][8] are these 3rd party files?
- I didn't try compiling from the source
Kind Regards,
Justin
1../test/data/serialization/3.0/utils.BloomFilter1000.bin
2. ./test/data/serialization/4.0/utils.BloomFilter1000.bin
3. ./doc/modules/cassandra/examples/BASH/*.sh
4. ./pylib/Dockerfile.ubuntu.*
5. ./lib/cassandra-driver-internal-only-3.25.0.zip
6. ./lib/cassandra-driver-3.25.0/cassandra/murmur3.py
7. ./lib/cassandra-driver-3.25.0/cassandra/io/asyncioreactor.py
8 ./lib/cassandra-driver-3.25.0/cassandra/io/libevwrapper.c
9. ./tools/fqltool/src/org/apache/cassandra/fqltool/commands/Dump.java
10. ./src/java/org/apache/cassandra/net/Crc.java
11. https://www.apache.org/legal/resolved.html#cc-by