You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Erel Segal (JIRA)" <ji...@apache.org> on 2008/08/13 15:14:45 UTC
[jira] Created: (SHINDIG-516) Frame Element channel is not used
Frame Element channel is not used
---------------------------------
Key: SHINDIG-516
URL: https://issues.apache.org/jira/browse/SHINDIG-516
Project: Shindig
Issue Type: Bug
Components: Features (Javascript)
Environment: Firefox 1+, 2+
Reporter: Erel Segal
While trying to make TypeRacer work on my server, I found out something that looks like a bug.
In gadgets.IfrGadget.prototype.getMainContent, there is the line:
gadgets.rpc.setAuthToken(iframeId, this.rpcToken);
This function calls setupFrame, which, if the best available channel is "fe", calls:
var frame = document.getElementById(frameId);
frame[FE_G2C_CHANNEL] = function(args) { ... }
However, the frame with that ID still does not exist - it is created only later in getMainContent :
continuation('<div class="' + this.cssClassGadgetContent + '"><iframe id="' + iframeId + ...")
I traced it using "sample2.html" and saw that there is really an exception in setupFrame saying "frame has no properties",
but the exception is caught and ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-516) Frame Element channel is not used
Posted by "John Hjelmstad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Hjelmstad resolved SHINDIG-516.
------------------------------------
Resolution: Fixed
I believe this is fixed with the last few changes to rpc.js.
> Frame Element channel is not used
> ---------------------------------
>
> Key: SHINDIG-516
> URL: https://issues.apache.org/jira/browse/SHINDIG-516
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript)
> Environment: Firefox 1+, 2+
> Reporter: Erel Segal
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> While trying to make TypeRacer work on my server, I found out something that looks like a bug.
> In gadgets.IfrGadget.prototype.getMainContent, there is the line:
> gadgets.rpc.setAuthToken(iframeId, this.rpcToken);
> This function calls setupFrame, which, if the best available channel is "fe", calls:
> var frame = document.getElementById(frameId);
> frame[FE_G2C_CHANNEL] = function(args) { ... }
> However, the frame with that ID still does not exist - it is created only later in getMainContent :
> continuation('<div class="' + this.cssClassGadgetContent + '"><iframe id="' + iframeId + ...")
> I traced it using "sample2.html" and saw that there is really an exception in setupFrame saying "frame has no properties",
> but the exception is caught and ignored.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.