You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chip Childers <ch...@sungard.com> on 2012/06/13 12:35:57 UTC
[PATCH] Correcting console proxy shell script exec headers.
All (David especially),
In my licensing changes for the console-proxy folder, I incorrectly
modified the header of the .sh scripts.
Here's the fix for all of the files:
-#!/usr/bin/env python
+#!/usr/bin/env bash
This really needs to get applied to the master branch quickly, as the
patch that introduces the issue was applied yesterday. If someone
with commit rights can please review and apply today, that would be
great.
Patch below (and attached):
----------------------------------------------------------------
>From 1734a56c71bdb2bfd59b2d4939358dd9f616e258 Mon Sep 17 00:00:00 2001
From: Chip Childers <ch...@gmail.com>
Date: Wed, 13 Jun 2012 04:45:01 -0400
Subject: [PATCH] Correcting console proxy shell script exec headers.
Signed-off-by: Chip Childers <ch...@gmail.com>
---
console-proxy/scripts/_run.sh | 2 +-
console-proxy/scripts/config_auth.sh | 2 +-
console-proxy/scripts/config_ssl.sh | 2 +-
console-proxy/scripts/ipfirewall.sh | 2 +-
console-proxy/scripts/run-proxy.sh | 2 +-
console-proxy/scripts/run.sh | 2 +-
console-proxy/scripts/ssvm-check.sh | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/console-proxy/scripts/_run.sh b/console-proxy/scripts/_run.sh
index ebe5c54..e408378 100755
--- a/console-proxy/scripts/_run.sh
+++ b/console-proxy/scripts/_run.sh
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env bash
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
diff --git a/console-proxy/scripts/config_auth.sh
b/console-proxy/scripts/config_auth.sh
index 3db5fb6..4b74f8e 100755
--- a/console-proxy/scripts/config_auth.sh
+++ b/console-proxy/scripts/config_auth.sh
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env bash
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
diff --git a/console-proxy/scripts/config_ssl.sh
b/console-proxy/scripts/config_ssl.sh
index b583426..8d80c47 100755
--- a/console-proxy/scripts/config_ssl.sh
+++ b/console-proxy/scripts/config_ssl.sh
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env bash
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
diff --git a/console-proxy/scripts/ipfirewall.sh
b/console-proxy/scripts/ipfirewall.sh
index a6fe39a..4711b8a 100755
--- a/console-proxy/scripts/ipfirewall.sh
+++ b/console-proxy/scripts/ipfirewall.sh
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env bash
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
diff --git a/console-proxy/scripts/run-proxy.sh
b/console-proxy/scripts/run-proxy.sh
index 83f6117..d6ccf7c 100644
--- a/console-proxy/scripts/run-proxy.sh
+++ b/console-proxy/scripts/run-proxy.sh
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env bash
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
diff --git a/console-proxy/scripts/run.sh b/console-proxy/scripts/run.sh
index 755ccdd..146d96f 100755
--- a/console-proxy/scripts/run.sh
+++ b/console-proxy/scripts/run.sh
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env bash
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
diff --git a/console-proxy/scripts/ssvm-check.sh
b/console-proxy/scripts/ssvm-check.sh
index b19961b..a401164 100644
--- a/console-proxy/scripts/ssvm-check.sh
+++ b/console-proxy/scripts/ssvm-check.sh
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env bash
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
--
1.7.7.5 (Apple Git-26)
Re: [PATCH] Correcting console proxy shell script exec headers.
Posted by David Nalley <da...@gnsa.us>.
Thanks for the catch and turn around. Applied.
--David
On Wed, Jun 13, 2012 at 6:35 AM, Chip Childers
<ch...@sungard.com> wrote:
> All (David especially),
>
> In my licensing changes for the console-proxy folder, I incorrectly
> modified the header of the .sh scripts.
>
> Here's the fix for all of the files:
> -#!/usr/bin/env python
> +#!/usr/bin/env bash
>
> This really needs to get applied to the master branch quickly, as the
> patch that introduces the issue was applied yesterday. If someone
> with commit rights can please review and apply today, that would be
> great.
>
> Patch below (and attached):
> ----------------------------------------------------------------
>
>
> From 1734a56c71bdb2bfd59b2d4939358dd9f616e258 Mon Sep 17 00:00:00 2001
> From: Chip Childers <ch...@gmail.com>
> Date: Wed, 13 Jun 2012 04:45:01 -0400
> Subject: [PATCH] Correcting console proxy shell script exec headers.
>
>
> Signed-off-by: Chip Childers <ch...@gmail.com>
> ---
> console-proxy/scripts/_run.sh | 2 +-
> console-proxy/scripts/config_auth.sh | 2 +-
> console-proxy/scripts/config_ssl.sh | 2 +-
> console-proxy/scripts/ipfirewall.sh | 2 +-
> console-proxy/scripts/run-proxy.sh | 2 +-
> console-proxy/scripts/run.sh | 2 +-
> console-proxy/scripts/ssvm-check.sh | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/console-proxy/scripts/_run.sh b/console-proxy/scripts/_run.sh
> index ebe5c54..e408378 100755
> --- a/console-proxy/scripts/_run.sh
> +++ b/console-proxy/scripts/_run.sh
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env bash
> # Licensed to the Apache Software Foundation (ASF) under one
> # or more contributor license agreements. See the NOTICE file
> # distributed with this work for additional information
> diff --git a/console-proxy/scripts/config_auth.sh
> b/console-proxy/scripts/config_auth.sh
> index 3db5fb6..4b74f8e 100755
> --- a/console-proxy/scripts/config_auth.sh
> +++ b/console-proxy/scripts/config_auth.sh
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env bash
> # Licensed to the Apache Software Foundation (ASF) under one
> # or more contributor license agreements. See the NOTICE file
> # distributed with this work for additional information
> diff --git a/console-proxy/scripts/config_ssl.sh
> b/console-proxy/scripts/config_ssl.sh
> index b583426..8d80c47 100755
> --- a/console-proxy/scripts/config_ssl.sh
> +++ b/console-proxy/scripts/config_ssl.sh
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env bash
> # Licensed to the Apache Software Foundation (ASF) under one
> # or more contributor license agreements. See the NOTICE file
> # distributed with this work for additional information
> diff --git a/console-proxy/scripts/ipfirewall.sh
> b/console-proxy/scripts/ipfirewall.sh
> index a6fe39a..4711b8a 100755
> --- a/console-proxy/scripts/ipfirewall.sh
> +++ b/console-proxy/scripts/ipfirewall.sh
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env bash
> # Licensed to the Apache Software Foundation (ASF) under one
> # or more contributor license agreements. See the NOTICE file
> # distributed with this work for additional information
> diff --git a/console-proxy/scripts/run-proxy.sh
> b/console-proxy/scripts/run-proxy.sh
> index 83f6117..d6ccf7c 100644
> --- a/console-proxy/scripts/run-proxy.sh
> +++ b/console-proxy/scripts/run-proxy.sh
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env bash
> # Licensed to the Apache Software Foundation (ASF) under one
> # or more contributor license agreements. See the NOTICE file
> # distributed with this work for additional information
> diff --git a/console-proxy/scripts/run.sh b/console-proxy/scripts/run.sh
> index 755ccdd..146d96f 100755
> --- a/console-proxy/scripts/run.sh
> +++ b/console-proxy/scripts/run.sh
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env bash
> # Licensed to the Apache Software Foundation (ASF) under one
> # or more contributor license agreements. See the NOTICE file
> # distributed with this work for additional information
> diff --git a/console-proxy/scripts/ssvm-check.sh
> b/console-proxy/scripts/ssvm-check.sh
> index b19961b..a401164 100644
> --- a/console-proxy/scripts/ssvm-check.sh
> +++ b/console-proxy/scripts/ssvm-check.sh
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env bash
> # Licensed to the Apache Software Foundation (ASF) under one
> # or more contributor license agreements. See the NOTICE file
> # distributed with this work for additional information
> --
> 1.7.7.5 (Apple Git-26)