[jira] Commented: (OFBIZ-3077) Error for productStoreId when click on productId link from showcart of purchase order

["Mridul Pathak (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778314#action_12778314 ] 

Mridul Pathak commented on OFBIZ-3077:
--------------------------------------

As Joe has already stated that we need to do few adjustments in the code based on presence of productStoreId.  I would vote for:

# Showing all reviews.
# Skipping surveys.

The third section, which is the most important one and needs productStoreId is getProductVariantTree service invoked in ProductDetail.groovy (line 232).  getProductVariantTree service needs productStoreId to get available inventory.  In case of PO's we don't need to check for available inventory at all.  Now for being able to use the same code to display product detail page in case of a PO, we will need to make modifications to getProductVariantTree service too, which can be done in two ways:
# Add a boolean IN attribute *checkInventory* to service definition, if its true check the available inventory and if false do not.
# A check on productStoreId in the implementation can serve our purpose too.

I like #1 more as it won't eliminate importance of productStoreId in case of a sales order.  Looking forward to suggestions from community to handle this situation.

> Error for productStoreId when click on productId link from showcart of purchase order
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3077
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3077
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Brajesh Patel
>             Fix For: SVN trunk
>
>
> Steps regenerate error:
> 1) Hit url: https://localhost:8443/ordermgr/control/orderentry
> 2) Select purchase order with supplier 
> 3) Add product for order
> 4) Click on the productId from showcart page
> it will generate error as following 
> org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://order/widget/ordermgr/OrderEntryCatalogScreens.xml#productdetail]: java.lang.NullPointerException: Cannot get property 'productStoreId' on null object (Cannot get property 'productStoreId' on null object)
> Thanks Rishi, Mridul and Ratnesh for discussion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.