You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Michael Sparer (JIRA)" <ji...@apache.org> on 2010/10/05 18:45:34 UTC
[jira] Created: (WICKET-3095) Adding AjaxFormSubmitBehavior to Form
leads to "Error: too much recursion" JS Error
Adding AjaxFormSubmitBehavior to Form leads to "Error: too much recursion" JS Error
-----------------------------------------------------------------------------------
Key: WICKET-3095
URL: https://issues.apache.org/jira/browse/WICKET-3095
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.12
Reporter: Michael Sparer
We did an upgrade from 1.4.9 to 1.4.12 and noticed that a custom subclass of Form behaves differently. To submit a form by means of Ajax, we added an AjaxFormSubmitBehavior to the form triggering the "onsubmit" event. This worked until we did the upgrade. Now the javascript error "Error: too much recursion" occurs on submitting the form. This leads to a non-ajax submit of the form. I suspect that the code that AjaxFormSubmitBehavior attaches to the onsubmit event triggers onsubmit again - leading to an infinite loop. We now downgraded to 1.4.10. So the bug _may_ first occur in 1.4.11 - but that version wasn't tested.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3095) Adding AjaxFormSubmitBehavior to
Form leads to "Error: too much recursion" JS Error
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918438#action_12918438 ]
Martin Grigorov commented on WICKET-3095:
-----------------------------------------
I think I know where the problem is.
> Adding AjaxFormSubmitBehavior to Form leads to "Error: too much recursion" JS Error
> -----------------------------------------------------------------------------------
>
> Key: WICKET-3095
> URL: https://issues.apache.org/jira/browse/WICKET-3095
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.12
> Reporter: Michael Sparer
> Assignee: Martin Grigorov
> Priority: Minor
>
> We did an upgrade from 1.4.9 to 1.4.12 and noticed that a custom subclass of Form behaves differently. To submit a form by means of Ajax, we added an AjaxFormSubmitBehavior to the form triggering the "onsubmit" event. This worked until we did the upgrade. Now the javascript error "Error: too much recursion" occurs on submitting the form. This leads to a non-ajax submit of the form. I suspect that the code that AjaxFormSubmitBehavior attaches to the onsubmit event triggers onsubmit again - leading to an infinite loop. We now downgraded to 1.4.10. So the bug _may_ first occur in 1.4.11 - but that version wasn't tested.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3095) Adding AjaxFormSubmitBehavior to
Form leads to "Error: too much recursion" JS Error
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918660#action_12918660 ]
Hudson commented on WICKET-3095:
--------------------------------
Integrated in Apache Wicket 1.4.x #190 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/190/])
WICKET-3095 Adding AjaxFormSubmitBehavior to Form leads to "Error: too much recursion" JS Error
Clean the attribute before returning.
WICKET-3095 Adding AjaxFormSubmitBehavior to Form leads to "Error: too much recursion" JS Error
Make the setting of the boolean attribute xhtml complaint.
suggested-by: ivaynberg
WICKET-3095 Adding AjaxFormSubmitBehavior to Form leads to "Error: too much recursion" JS Error
Set a temporary attribute to the form before calling its onsubmit handler to prevent endless loop.
> Adding AjaxFormSubmitBehavior to Form leads to "Error: too much recursion" JS Error
> -----------------------------------------------------------------------------------
>
> Key: WICKET-3095
> URL: https://issues.apache.org/jira/browse/WICKET-3095
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.12
> Reporter: Michael Sparer
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.4.13, 1.5-M3
>
> Attachments: recursion.jar
>
>
> We did an upgrade from 1.4.9 to 1.4.12 and noticed that a custom subclass of Form behaves differently. To submit a form by means of Ajax, we added an AjaxFormSubmitBehavior to the form triggering the "onsubmit" event. This worked until we did the upgrade. Now the javascript error "Error: too much recursion" occurs on submitting the form. This leads to a non-ajax submit of the form. I suspect that the code that AjaxFormSubmitBehavior attaches to the onsubmit event triggers onsubmit again - leading to an infinite loop. We now downgraded to 1.4.10. So the bug _may_ first occur in 1.4.11 - but that version wasn't tested.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3095) Adding AjaxFormSubmitBehavior to Form
leads to "Error: too much recursion" JS Error
Posted by "Michael Sparer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Sparer updated WICKET-3095:
-----------------------------------
Attachment: recursion.jar
Adding quickstart - run app and click on "submit" button.
> Adding AjaxFormSubmitBehavior to Form leads to "Error: too much recursion" JS Error
> -----------------------------------------------------------------------------------
>
> Key: WICKET-3095
> URL: https://issues.apache.org/jira/browse/WICKET-3095
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.12
> Reporter: Michael Sparer
> Assignee: Martin Grigorov
> Priority: Minor
> Attachments: recursion.jar
>
>
> We did an upgrade from 1.4.9 to 1.4.12 and noticed that a custom subclass of Form behaves differently. To submit a form by means of Ajax, we added an AjaxFormSubmitBehavior to the form triggering the "onsubmit" event. This worked until we did the upgrade. Now the javascript error "Error: too much recursion" occurs on submitting the form. This leads to a non-ajax submit of the form. I suspect that the code that AjaxFormSubmitBehavior attaches to the onsubmit event triggers onsubmit again - leading to an infinite loop. We now downgraded to 1.4.10. So the bug _may_ first occur in 1.4.11 - but that version wasn't tested.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3095) Adding AjaxFormSubmitBehavior to Form
leads to "Error: too much recursion" JS Error
Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Thomerson updated WICKET-3095:
-------------------------------------
Priority: Minor (was: Major)
Please provide a quickstart demonstrating this issue.
> Adding AjaxFormSubmitBehavior to Form leads to "Error: too much recursion" JS Error
> -----------------------------------------------------------------------------------
>
> Key: WICKET-3095
> URL: https://issues.apache.org/jira/browse/WICKET-3095
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.12
> Reporter: Michael Sparer
> Priority: Minor
>
> We did an upgrade from 1.4.9 to 1.4.12 and noticed that a custom subclass of Form behaves differently. To submit a form by means of Ajax, we added an AjaxFormSubmitBehavior to the form triggering the "onsubmit" event. This worked until we did the upgrade. Now the javascript error "Error: too much recursion" occurs on submitting the form. This leads to a non-ajax submit of the form. I suspect that the code that AjaxFormSubmitBehavior attaches to the onsubmit event triggers onsubmit again - leading to an infinite loop. We now downgraded to 1.4.10. So the bug _may_ first occur in 1.4.11 - but that version wasn't tested.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3095) Adding AjaxFormSubmitBehavior to
Form leads to "Error: too much recursion" JS Error
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3095.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M3
1.4.13
Fixed.
Thanks!
> Adding AjaxFormSubmitBehavior to Form leads to "Error: too much recursion" JS Error
> -----------------------------------------------------------------------------------
>
> Key: WICKET-3095
> URL: https://issues.apache.org/jira/browse/WICKET-3095
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.12
> Reporter: Michael Sparer
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.4.13, 1.5-M3
>
> Attachments: recursion.jar
>
>
> We did an upgrade from 1.4.9 to 1.4.12 and noticed that a custom subclass of Form behaves differently. To submit a form by means of Ajax, we added an AjaxFormSubmitBehavior to the form triggering the "onsubmit" event. This worked until we did the upgrade. Now the javascript error "Error: too much recursion" occurs on submitting the form. This leads to a non-ajax submit of the form. I suspect that the code that AjaxFormSubmitBehavior attaches to the onsubmit event triggers onsubmit again - leading to an infinite loop. We now downgraded to 1.4.10. So the bug _may_ first occur in 1.4.11 - but that version wasn't tested.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3095) Adding AjaxFormSubmitBehavior to
Form leads to "Error: too much recursion" JS Error
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3095:
---------------------------------------
Assignee: Martin Grigorov
> Adding AjaxFormSubmitBehavior to Form leads to "Error: too much recursion" JS Error
> -----------------------------------------------------------------------------------
>
> Key: WICKET-3095
> URL: https://issues.apache.org/jira/browse/WICKET-3095
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.12
> Reporter: Michael Sparer
> Assignee: Martin Grigorov
> Priority: Minor
>
> We did an upgrade from 1.4.9 to 1.4.12 and noticed that a custom subclass of Form behaves differently. To submit a form by means of Ajax, we added an AjaxFormSubmitBehavior to the form triggering the "onsubmit" event. This worked until we did the upgrade. Now the javascript error "Error: too much recursion" occurs on submitting the form. This leads to a non-ajax submit of the form. I suspect that the code that AjaxFormSubmitBehavior attaches to the onsubmit event triggers onsubmit again - leading to an infinite loop. We now downgraded to 1.4.10. So the bug _may_ first occur in 1.4.11 - but that version wasn't tested.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3095) Adding AjaxFormSubmitBehavior to
Form leads to "Error: too much recursion" JS Error
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918676#action_12918676 ]
Hudson commented on WICKET-3095:
--------------------------------
Integrated in Apache Wicket 1.5.x #384 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/384/])
WICKET-3095 Adding AjaxFormSubmitBehavior to Form leads to "Error: too much recursion" JS Error
merge r1005194, 1005195 and 1005196 from 1.4.x
Set a temporary attribute to the form before calling its onsubmit handler to prevent endless loop.
> Adding AjaxFormSubmitBehavior to Form leads to "Error: too much recursion" JS Error
> -----------------------------------------------------------------------------------
>
> Key: WICKET-3095
> URL: https://issues.apache.org/jira/browse/WICKET-3095
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.12
> Reporter: Michael Sparer
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.4.13, 1.5-M3
>
> Attachments: recursion.jar
>
>
> We did an upgrade from 1.4.9 to 1.4.12 and noticed that a custom subclass of Form behaves differently. To submit a form by means of Ajax, we added an AjaxFormSubmitBehavior to the form triggering the "onsubmit" event. This worked until we did the upgrade. Now the javascript error "Error: too much recursion" occurs on submitting the form. This leads to a non-ajax submit of the form. I suspect that the code that AjaxFormSubmitBehavior attaches to the onsubmit event triggers onsubmit again - leading to an infinite loop. We now downgraded to 1.4.10. So the bug _may_ first occur in 1.4.11 - but that version wasn't tested.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.