You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/19 12:02:09 UTC
[GitHub] [flink] zentol opened a new pull request #11137:
[FLINK-16168][build] Add build-debug profile
zentol opened a new pull request #11137: [FLINK-16168][build] Add build-debug profile
URL: https://github.com/apache/flink/pull/11137
Adds a `debug-build` profile for convenience that prints a dependency tree and shows active profiles.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11137: [FLINK-16168][build]
Add build-debug profile
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11137: [FLINK-16168][build] Add build-debug profile
URL: https://github.com/apache/flink/pull/11137#issuecomment-588209574
<!--
Meta data
Hash:095d1c7d7b8aee7ea2e094ad17ef81c620dc8158 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:095d1c7d7b8aee7ea2e094ad17ef81c620dc8158
-->
## CI report:
* 095d1c7d7b8aee7ea2e094ad17ef81c620dc8158 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #11137: [FLINK-16168][build]
Add build-debug profile
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #11137: [FLINK-16168][build] Add build-debug profile
URL: https://github.com/apache/flink/pull/11137#issuecomment-588782151
I would like to understand what information this gives us that other commands don't give us.
For the dependency printing, does this give you a different output than `mvn dependency:tree`?
Or is that to show the trees in all projects?
Similar for active profiles, can't you get this by invoking a specific target from the command line as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11137:
[FLINK-16168][build] Add build-debug profile
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11137: [FLINK-16168][build] Add build-debug profile
URL: https://github.com/apache/flink/pull/11137#issuecomment-588209574
<!--
Meta data
Hash:095d1c7d7b8aee7ea2e094ad17ef81c620dc8158 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5315 TriggerType:PUSH TriggerID:095d1c7d7b8aee7ea2e094ad17ef81c620dc8158
Hash:095d1c7d7b8aee7ea2e094ad17ef81c620dc8158 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149623153 TriggerType:PUSH TriggerID:095d1c7d7b8aee7ea2e094ad17ef81c620dc8158
-->
## CI report:
* 095d1c7d7b8aee7ea2e094ad17ef81c620dc8158 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149623153) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5315)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on issue #11137: [FLINK-16168][build] Add
build-debug profile
Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11137: [FLINK-16168][build] Add build-debug profile
URL: https://github.com/apache/flink/pull/11137#issuecomment-588897824
It's not different to invoking things from the command-line, but it provides an easy hook to activate these plugins when running on travis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on issue #11137: [FLINK-16168][build] Add
build-debug profile
Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11137: [FLINK-16168][build] Add build-debug profile
URL: https://github.com/apache/flink/pull/11137#issuecomment-588907993
Beyond that this also is a nice pointer for people who aren't so familiar with maven.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11137: [FLINK-16168][build]
Add build-debug profile
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11137: [FLINK-16168][build] Add build-debug profile
URL: https://github.com/apache/flink/pull/11137#issuecomment-588191200
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 095d1c7d7b8aee7ea2e094ad17ef81c620dc8158 (Wed Feb 19 12:06:49 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11137:
[FLINK-16168][build] Add build-debug profile
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11137: [FLINK-16168][build] Add build-debug profile
URL: https://github.com/apache/flink/pull/11137#issuecomment-588209574
<!--
Meta data
Hash:095d1c7d7b8aee7ea2e094ad17ef81c620dc8158 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5315 TriggerType:PUSH TriggerID:095d1c7d7b8aee7ea2e094ad17ef81c620dc8158
Hash:095d1c7d7b8aee7ea2e094ad17ef81c620dc8158 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149623153 TriggerType:PUSH TriggerID:095d1c7d7b8aee7ea2e094ad17ef81c620dc8158
-->
## CI report:
* 095d1c7d7b8aee7ea2e094ad17ef81c620dc8158 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149623153) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5315)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #11137: [FLINK-16168][build]
Add build-debug profile
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #11137: [FLINK-16168][build] Add build-debug profile
URL: https://github.com/apache/flink/pull/11137#issuecomment-588908154
In that case, it would be nice to keep it out of the `pom.xml`, in my opinion. That file is already overflowing, and this seems like a rare tool for which an almost equal alternative exists.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol closed pull request #11137: [FLINK-16168][build] Add
build-debug profile
Posted by GitBox <gi...@apache.org>.
zentol closed pull request #11137: [FLINK-16168][build] Add build-debug profile
URL: https://github.com/apache/flink/pull/11137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services