You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Dongjoon Hyun (JIRA)" <ji...@apache.org> on 2016/01/05 21:26:39 UTC
[jira] [Resolved] (REEF-1117) Update change_version.py by cleaning
up incubating-related logic
[ https://issues.apache.org/jira/browse/REEF-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dongjoon Hyun resolved REEF-1117.
---------------------------------
Resolution: Duplicate
Merged into original issue.
> Update change_version.py by cleaning up incubating-related logic
> ----------------------------------------------------------------
>
> Key: REEF-1117
> URL: https://issues.apache.org/jira/browse/REEF-1117
> Project: REEF
> Issue Type: Sub-task
> Reporter: Dongjoon Hyun
> Assignee: Dongjoon Hyun
> Priority: Minor
>
> This issue removes '<RemoveIncubating>' handling logics in `change_version.py`.
> {code}
> - r1 = re.compile('<RemoveIncubating>(.*?)</RemoveIncubating>')
> - r2 = re.compile('<IsSnapshot>(.*?)</IsSnapshot>')
> - r3 = re.compile('<SnapshotNumber>(.*?)</SnapshotNumber>')
> + r1 = re.compile('<IsSnapshot>(.*?)</IsSnapshot>')
> + r2 = re.compile('<SnapshotNumber>(.*?)</SnapshotNumber>')
> ...
> - if "<RemoveIncubating>" and "</RemoveIncubating>" in line and is_snapshot=="false":
> - old_remove_incubating = r1.search(line).group(1)
> - changed_str += line.replace(old_remove_incubating, "true")
> - elif "<IsSnapshot>" in line and "</IsSnapshot>" in line:
> - old_is_snapshot = r2.search(line).group(1)
> + if "<IsSnapshot>" in line and "</IsSnapshot>" in line:
> + old_is_snapshot = r1.search(line).group(1)
> changed_str += line.replace(old_is_snapshot, is_snapshot)
> elif "<SnapshotNumber>" in line and "</SnapshotNumber>" in line and is_snapshot=="false":
> - old_snapshot_number = r3.search(line).group(1)
> + old_snapshot_number = r2.search(line).group(1)
> changed_str += line.replace(old_snapshot_number, "00")
> else:
> changed_str += line
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)